[issue38753] AsyncMock not cited as new in 3.8
New submission from John Belmonte <john@neggie.net>: AsyncMock appears to be new in Python 3.8, but doc is missing info on when it was introduced. https://docs.python.org/3.8/library/unittest.mock.html#unittest.mock.AsyncMo... ---------- assignee: docs@python components: Documentation messages: 356290 nosy: John Belmonte, docs@python priority: normal severity: normal status: open title: AsyncMock not cited as new in 3.8 versions: Python 3.8 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
Change by Karthikeyan Singaravelan <tir.karthi@gmail.com>: ---------- nosy: +lisroach, xtreak _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
Karthikeyan Singaravelan <tir.karthi@gmail.com> added the comment: John, would you like to raise a PR for this? The fix would be to add versionadded sphinx directive to https://github.com/python/cpython/blob/master/Doc/library/unittest.mock.rst . I am marking it as easy. ---------- keywords: +easy, newcomer friendly stage: -> needs patch versions: +Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
John Belmonte <john@neggie.net> added the comment: yes, will do ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
Change by John Belmonte <john@neggie.net>: ---------- keywords: +patch pull_requests: +16608 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17102 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
Lisa Roach <lisaroach14@gmail.com> added the comment: New changeset 279d8df5e5e8bbd4429420649359f7afcb4c8cce by Lisa Roach (John Belmonte) in branch 'master': bpo-38753: AsyncMock added in version 3.8 (GH-17102) https://github.com/python/cpython/commit/279d8df5e5e8bbd4429420649359f7afcb4... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +16760 pull_request: https://github.com/python/cpython/pull/17268 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 8c0f0016e2d39f86589187db75012238c4e760e9 by Miss Islington (bot) in branch '3.8': bpo-38753: AsyncMock added in version 3.8 (GH-17102) https://github.com/python/cpython/commit/8c0f0016e2d39f86589187db75012238c4e... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
Karthikeyan Singaravelan <tir.karthi@gmail.com> added the comment: Thanks John for the report and patch. Closing it as resolved. ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38753> _______________________________________
participants (4)
-
John Belmonte -
Karthikeyan Singaravelan
-
Lisa Roach
-
miss-islington