Matheus Vieira Portela added the comment: Just checking, it would be required to update Objects/unicodeobject.c, Include/unicodeobject.h, and Doc/c-api/unicode.rst, right? As far as I saw, "unicode" means a Python object with unicode string, "u" is a UTF-8 encoded C string, "str" and "s" are encoded C strings (UTF-8, UTF-7, ASCII, Latin-1, among others). Is it alright to rename Python unicode objects to "unicode" and the others to simply "str"? These names are more meaningful than the single character alternatives. The same logic would be applied to the other types, always keeping the longer name rather than the single character ones. ---------- nosy: +matheus.v.portela _______________________________________ Python tracker http://bugs.python.org/issue18697 _______________________________________

Windson Yang added the comment: I agreed with @Matheus, it would be better than the current implementation ---------- nosy: +Windson Yang versions: +Python 3.6, Python 3.7 -Python 2.7, Python 3.4, Python 3.5 _______________________________________ Python tracker https://bugs.python.org/issue18697 _______________________________________

Change by Windson Yang : ---------- versions: -Python 2.7 _______________________________________ Python tracker https://bugs.python.org/issue18697 _______________________________________

Rune Tynan added the comment: I have some interest in making a fix for this. From discussion, I'm thinking that, barring names that already have clear meaning (EG, left/right for things with two parameters): - PyObject* that is unknown type remains `obj` - PyObject* with unicode string is `unicode` - const char*, const Py_UNICODE*, and const wchar* becomes `str` - const char, const Py_UNICODE, and const wchar become `ch` Those seem to be the intersect of most common and most descriptive names already seen. ---------- _______________________________________ Python tracker https://bugs.python.org/issue18697 _______________________________________

Change by Rune Tynan : ---------- keywords: +patch pull_requests: +12607 stage: needs patch -> patch review _______________________________________ Python tracker https://bugs.python.org/issue18697 _______________________________________

Rune Tynan added the comment: It has been over a month and I'm still waiting for an updated PR review. I understand if people are busy, but don't want this to just fall through the cracks. ---------- _______________________________________ Python tracker https://bugs.python.org/issue18697 _______________________________________

Change by Stéphane Wirtel : ---------- versions: +Python 3.8, Python 3.9 -Python 3.4, Python 3.5, Python 3.6 _______________________________________ Python tracker https://bugs.python.org/issue18697 _______________________________________