[issue18743] References to non-existant "StringIO" module
New submission from Jesús Cea Avión: Doing a "grep StringIO Doc/library/*.rst" shows a handful of references to the old StringIO library. Notably: gzip.rst mailbox.rst tempfile.rst test.rst unittest.mock.rst xml.dom.minidom.rst ---------- assignee: docs@python components: Documentation messages: 195231 nosy: docs@python, jcea priority: normal severity: normal status: open title: References to non-existant "StringIO" module versions: Python 3.3, Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- nosy: +serhiy.storchaka stage: -> needs patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- assignee: docs@python -> serhiy.storchaka _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Serhiy Storchaka added the comment: Here is a patch. Actually this is a small part of larger problem for which I will open several separated issues. ---------- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file31315/doc_StringIO_refs.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Jesús Cea Avión added the comment: Patch is incomplete. I found this error while reading "unittest.mock", that you are not patching. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Serhiy Storchaka added the comment: I don't see StringIO in Doc/library/unittest.mock.rst. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Serhiy Storchaka added the comment: Ah, I missed it. Here is completed patch. ---------- Added file: http://bugs.python.org/file31321/doc_StringIO_refs_2.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Terry J. Reedy added the comment: LGTM ---------- nosy: +terry.reedy stage: patch review -> commit review type: -> behavior _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Roundup Robot added the comment: New changeset b23ad357c214 by Serhiy Storchaka in branch '3.3': Issue #18743: Fix references to non-existant "StringIO" module. http://hg.python.org/cpython/rev/b23ad357c214 New changeset 3acbd7aca856 by Serhiy Storchaka in branch 'default': Issue #18743: Fix references to non-existant "StringIO" module. http://hg.python.org/cpython/rev/3acbd7aca856 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Serhiy Storchaka added the comment: Here is a patch which fixes references to StringIO in docstrings and comments and removes redundant code. ---------- Added file: http://bugs.python.org/file31362/src_StringIO_refs.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- stage: commit review -> patch review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Roundup Robot added the comment: New changeset 6c0f5af2f5a5 by Serhiy Storchaka in branch '3.3': Issue #18743: Fix references to non-existant "StringIO" module http://hg.python.org/cpython/rev/6c0f5af2f5a5 New changeset 676bbd5b0254 by Serhiy Storchaka in branch 'default': Issue #18743: Fix references to non-existant "StringIO" module http://hg.python.org/cpython/rev/676bbd5b0254 New changeset 8c768bbacd92 by Serhiy Storchaka in branch '2.7': Issue #18743: Improved cross-references to the StringIO class. http://hg.python.org/cpython/rev/8c768bbacd92 ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
Changes by Serhiy Storchaka <storchaka@gmail.com>: ---------- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18743> _______________________________________
participants (4)
-
Jesús Cea Avión -
Roundup Robot
-
Serhiy Storchaka
-
Terry J. Reedy