[issue29009] Outdated part in the doc of PyUnicode_RichCompare
New submission from Xiang Zhang: The sentence: "Note that Py_EQ and Py_NE comparisons can cause a UnicodeWarning in case the conversion of the arguments to Unicode fails with a UnicodeDecodeError." in the doc of PyUnicode_RichCompare is not true in 3.x. Proposed patch simply deletes it. ---------- assignee: docs@python components: Documentation files: doc-of-PyUnicode_RichCompare.patch keywords: patch messages: 283578 nosy: docs@python, haypo, xiang.zhang priority: normal severity: normal stage: patch review status: open title: Outdated part in the doc of PyUnicode_RichCompare versions: Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file45960/doc-of-PyUnicode_RichCompare.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29009> _______________________________________
Serhiy Storchaka added the comment: This sentence also is in the header. ---------- nosy: +serhiy.storchaka _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29009> _______________________________________
Xiang Zhang added the comment:
This sentence also is in the header.
Ohh, yes. Thanks Serhiy! ---------- Added file: http://bugs.python.org/file45961/doc-of-PyUnicode_RichCompare_v2.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29009> _______________________________________
Serhiy Storchaka added the comment: LGTM. ---------- assignee: docs@python -> xiang.zhang stage: patch review -> commit review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29009> _______________________________________
STINNER Victor added the comment: doc-of-PyUnicode_RichCompare_v2.patch LGTM. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29009> _______________________________________
Roundup Robot added the comment: New changeset 8f5ed2a38f64 by Xiang Zhang in branch '3.5': Issue #29009: Remove outdated doc of PyUnicode_RichCompare. https://hg.python.org/cpython/rev/8f5ed2a38f64 New changeset da958d01755a by Xiang Zhang in branch '3.6': Issue #29009: Merge 3.5. https://hg.python.org/cpython/rev/da958d01755a New changeset 9568343fde42 by Xiang Zhang in branch 'default': Issue #29009: Merge 3.6. https://hg.python.org/cpython/rev/9568343fde42 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29009> _______________________________________
Changes by Xiang Zhang <angwerzx@126.com>: ---------- resolution: -> fixed stage: commit review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29009> _______________________________________
participants (4)
-
Roundup Robot -
Serhiy Storchaka
-
STINNER Victor
-
Xiang Zhang