[issue29407] Remove redundant ensure_future() calls in factorial example
New submission from Berker Peksag: Unless I'm missing something, ensure_future() calls at https://docs.python.org/3.6/library/asyncio-task.html#example-parallel-execu... are redundant and can be removed. Off-topic: Can we use the async/await keywords in asyncio docs now? ---------- assignee: docs@python components: Documentation, asyncio files: ensure_future.diff keywords: patch messages: 286576 nosy: berker.peksag, docs@python, gvanrossum, yselivanov priority: normal severity: normal stage: patch review status: open title: Remove redundant ensure_future() calls in factorial example type: enhancement versions: Python 3.5, Python 3.6, Python 3.7 Added file: http://bugs.python.org/file46471/ensure_future.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Guido van Rossum added the comment: LGTM, and should be committed to 3.5 and merged upwards from there. And yes, it's time for the asyncio docs to converge on async/await everywhere, making `yield from` a footnoot to history. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Roundup Robot added the comment: New changeset e4f6874abda6 by Berker Peksag in branch '3.5': Issue #29407: Remove redundant ensure_future() calls in factorial example https://hg.python.org/cpython/rev/e4f6874abda6 New changeset 7196ab02b7ce by Berker Peksag in branch '3.6': Issue #29407: Merge from 3.5 https://hg.python.org/cpython/rev/7196ab02b7ce New changeset 0990a071751f by Berker Peksag in branch 'default': Issue #29407: Merge from 3.6 https://hg.python.org/cpython/rev/0990a071751f ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Berker Peksag added the comment: Thanks for the review, Guido. ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Roundup Robot added the comment: New changeset 94aa4efdf0196de9f99b6f1bd68322939d8d6974 by Berker Peksag in branch '3.6': Issue #29407: Remove redundant ensure_future() calls in factorial example https://github.com/python/cpython/commit/94aa4efdf0196de9f99b6f1bd68322939d8... New changeset 96104636fa5bd3054367d4667d86d43690c24293 by Berker Peksag in branch '3.6': Issue #29407: Merge from 3.5 https://github.com/python/cpython/commit/96104636fa5bd3054367d4667d86d43690c... ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Roundup Robot added the comment: New changeset 94aa4efdf0196de9f99b6f1bd68322939d8d6974 by Berker Peksag in branch '3.5': Issue #29407: Remove redundant ensure_future() calls in factorial example https://github.com/python/cpython/commit/94aa4efdf0196de9f99b6f1bd68322939d8... ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Roundup Robot added the comment: New changeset 94aa4efdf0196de9f99b6f1bd68322939d8d6974 by Berker Peksag in branch 'master': Issue #29407: Remove redundant ensure_future() calls in factorial example https://github.com/python/cpython/commit/94aa4efdf0196de9f99b6f1bd68322939d8... New changeset 96104636fa5bd3054367d4667d86d43690c24293 by Berker Peksag in branch 'master': Issue #29407: Merge from 3.5 https://github.com/python/cpython/commit/96104636fa5bd3054367d4667d86d43690c... New changeset 6b569a0de28e3c341837030d6aa739422d315a6f by Berker Peksag in branch 'master': Issue #29407: Merge from 3.6 https://github.com/python/cpython/commit/6b569a0de28e3c341837030d6aa739422d3... ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
Changes by Roundup Robot <devnull@psf.upfronthosting.co.za>: _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue29407> _______________________________________
participants (3)
-
Berker Peksag -
Guido van Rossum
-
Roundup Robot