Re: [docs] TypeError in smtpd module with string arguments (issue 26209)

http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst File Doc/library/smtpd.rst (right): http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode... Doc/library/smtpd.rst:35: *localaddr*. It will treat *remoteaddr* as an upstream SMTP relayer. Both On 2016/08/08 11:49:18, SilentGhost wrote:
Two spaces between the sentences are required.
Done. http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode... Doc/library/smtpd.rst:35: *localaddr*. It will treat *remoteaddr* as an upstream SMTP relayer. Both On 2016/08/08 11:49:18, SilentGhost wrote:
Two spaces between the sentences are required.
Done. http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode... Doc/library/smtpd.rst:36: the parameters localaddr and remoteaddr should a tuple in form ``("host",portnumber)``, On 2016/08/08 11:48:16, matrixise wrote:
should be a tuple
Done. http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode... Doc/library/smtpd.rst:36: the parameters localaddr and remoteaddr should a tuple in form ``("host",portnumber)``, On 2016/08/08 11:49:18, SilentGhost wrote:
Please make sure that each line fits into 80 columns.
Done. http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode... Doc/library/smtpd.rst:36: the parameters localaddr and remoteaddr should a tuple in form ``("host",portnumber)``, On 2016/08/08 11:49:18, SilentGhost wrote:
How about this wording: "Both *localaddr* and *remoteaddr* should be a two-tuple in the form ``('host', portnumber)``...
mentioning two-tuple would be confusing added this way "Both *localaddr* and *remoteaddr* should be a tuple... http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode... Doc/library/smtpd.rst:37: where *host* is a valid IP/FQDN. It inherits from :class:`asyncore.dispatcher`, On 2016/08/08 11:49:18, SilentGhost wrote:
Only single space between words.
Done. http://bugs.python.org/review/26209/diff/18091/Doc/library/smtpd.rst#newcode... Doc/library/smtpd.rst:37: where *host* is a valid IP/FQDN. It inherits from :class:`asyncore.dispatcher`, On 2016/08/08 11:49:18, SilentGhost wrote:
I'd suggest replacing "It" with "The object".
participants (1)
-
ram.pydev@gmail.com