[issue16554] The description of the argument of MAKE_FUNCTION and MAKE_CLOSURE is incorrect
New submission from Daniel Urban: The description of the argument of the MAKE_FUNCTION and MAKE_CLOSURE opcodes in the documentation of the dis module is incorrect. Patch attached. ---------- assignee: docs@python components: Documentation files: make_function_closure.patch keywords: needs review, patch messages: 176390 nosy: daniel.urban, docs@python priority: normal severity: normal stage: patch review status: open title: The description of the argument of MAKE_FUNCTION and MAKE_CLOSURE is incorrect versions: Python 3.3, Python 3.4 Added file: http://bugs.python.org/file28125/make_function_closure.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16554> _______________________________________
Andrew Svetlov added the comment: The patch is better than current doc. Would you like to replace textual description of stack layout with some kind of ascii-art or table? I think it can be more readable. ---------- nosy: +asvetlov _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16554> _______________________________________
Daniel Urban added the comment: Sorry, I won't have time for that in the following weeks. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16554> _______________________________________
Roundup Robot added the comment: New changeset c515b40a70eb by Antoine Pitrou in branch '3.4': Issue #16554: fix description for MAKE_CLOSURE. Initial patch by Daniel Urban. https://hg.python.org/cpython/rev/c515b40a70eb New changeset 2a41fb63c095 by Antoine Pitrou in branch '3.5': Issue #16554: fix description for MAKE_CLOSURE. Initial patch by Daniel Urban. https://hg.python.org/cpython/rev/2a41fb63c095 New changeset 7aed2d7e7dd5 by Antoine Pitrou in branch 'default': Issue #16554: fix description for MAKE_CLOSURE. Initial patch by Daniel Urban. https://hg.python.org/cpython/rev/7aed2d7e7dd5 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16554> _______________________________________
Antoine Pitrou added the comment: The description for MAKE_FUNCTION had already been fixed in the meantime, so I pushed the changes for MAKE_CLOSURE. Thank you! ---------- nosy: +pitrou resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue16554> _______________________________________
participants (4)
-
Andrew Svetlov -
Antoine Pitrou
-
Daniel Urban
-
Roundup Robot