Change by Géry : ---------- keywords: +patch pull_requests: +9677 stage: -> patch review _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

Géry added the comment: It looks like Barry Warsaw has not been fully updated the documentation after making the __spec__.loader attribute match with the __loader__ attribute, and the __spec__.file attribute match with the __file__ attribute for namespace packages. Here is a pull request to update the library documentation of importlib (your first link [1]) with the current Barry's implementation: https://github.com/python/cpython/pull/10016 Here is another pull request to update the reference documentation of the import system (your second link [2], but for a different paragraph, as I think the "To indicate to the import machinery that the spec represents a namespace portion the path entry finder sets “loader” on the spec to None" sentence is correct, since the `_bootstrap.ModuleSpec.loader` attribute of a namespace package remains `None` until the call to the `importlib._bootstrap._init_module_attrs` function): https://github.com/python/cpython/pull/10376 ---------- nosy: +brett.cannon, eric.snow, maggyero, ncoghlan _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

Cheryl Sabella added the comment: @barry, you started a review of PR10016 and I believe all your requested changes have been made, so please review again when you get a chance. Please also take a look at PR10376. Thanks! ---------- nosy: +cheryl.sabella type: -> enhancement versions: +Python 3.8 _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

Barry A. Warsaw added the comment: I've approved both PRs, however I am rather uncomfortable about the code snippet in import.rst. Géry's change is a good one AFAICT, and thanks for the contribution! I would feel much better about the long term correctness of this code snippet if we had a doctest to run over it. But that's for another time. ---------- _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

Géry added the comment: Oops, sorry, only one of the two PRs has been merged. ---------- _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

Barry A. Warsaw added the comment: Apologies for the long delay in reviewing this bug. I'm looking at it now, however since Python 3.7 is in security-only mode, this will only apply to 3.10, 3.9, and 3.8. ---------- versions: +Python 3.10, Python 3.9 -Python 3.7 _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

Change by miss-islington : ---------- pull_requests: +21814 pull_request: https://github.com/python/cpython/pull/22872 _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

miss-islington added the comment: New changeset 916ac9520108831d2099b13992a45884b112b193 by Miss Skeleton (bot) in branch '3.8': bpo-35181: Correct importlib documentation for some module attributes (GH-15190) https://github.com/python/cpython/commit/916ac9520108831d2099b13992a45884b11... ---------- _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________

Barry A. Warsaw added the comment: @maggyero - I haven't merged PR 10016, but I left some additional comments. Are you still interested in shepherding this PR? ---------- _______________________________________ Python tracker https://bugs.python.org/issue35181 _______________________________________