[issue18665] Typos in frame object related code
New submission from Vajrasky Kok: See the patch for details: diff -r 438cdc97d8ee Include/frameobject.h --- a/Include/frameobject.h Mon Aug 05 23:35:43 2013 +0200 +++ b/Include/frameobject.h Tue Aug 06 12:38:15 2013 +0800 @@ -36,7 +36,7 @@ non-generator frames. See the save_exc_state and swap_exc_state functions in ceval.c for details of their use. */ PyObject *f_exc_type, *f_exc_value, *f_exc_traceback; - /* Borrowed referenced to a generator, or NULL */ + /* Borrowed reference to a generator, or NULL */ PyObject *f_gen; PyThreadState *f_tstate; diff -r 438cdc97d8ee Lib/test/test_frame.py --- a/Lib/test/test_frame.py Mon Aug 05 23:35:43 2013 +0200 +++ b/Lib/test/test_frame.py Tue Aug 06 12:38:15 2013 +0800 @@ -93,7 +93,7 @@ @support.cpython_only def test_clear_refcycles(self): - # .clear() doesn't leave any refcycle behin + # .clear() doesn't leave any refcycle behind. with support.disable_gc(): class C: pass About the second comment, I am not sure to put dot or not. In that file, I saw some comments use dot, others don't. ---------- assignee: docs@python components: Documentation messages: 194523 nosy: docs@python, pitrou, vajrasky priority: normal severity: normal status: open title: Typos in frame object related code versions: Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18665> _______________________________________
Ezio Melotti added the comment: Can you attach the patch to the issue? Full stops for one-sentence comments can be omitted. ---------- nosy: +ezio.melotti stage: -> needs patch type: -> enhancement versions: +Python 2.7, Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18665> _______________________________________
Vajrasky Kok added the comment: Okay, attached the patch to fix the typo. ---------- keywords: +patch Added file: http://bugs.python.org/file31171/fix_typo_frame_object.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18665> _______________________________________
Roundup Robot added the comment: New changeset 89ce323357db by Antoine Pitrou in branch 'default': Issue #18665: fix typos. Patch by Vajrasky Kok. http://hg.python.org/cpython/rev/89ce323357db ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18665> _______________________________________
Antoine Pitrou added the comment: Thank you :) ---------- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed versions: -Python 2.7, Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue18665> _______________________________________
participants (4)
-
Antoine Pitrou
-
Ezio Melotti
-
Roundup Robot
-
Vajrasky Kok