[issue35649] http.client doesn't close. Infinite loop
Martin Panter <vadmium+py@gmail.com> added the comment: This was changed in Python 3.2+ in Issue 16723. The response object no longer sets the “closed” attribute when it runs out of data; it is only set when the “close” method is called. Perhaps the example should be amended so that it checks if “read” returned an empty string, rather than checking “closed”. Another problem with the example is that printing the chunk as a bytes object can trigger BytesWarning. I would add a “repr” call to avoid that. ---------- assignee: -> docs@python components: +Documentation nosy: +docs@python, martin.panter _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35649> _______________________________________
skorpeo <skorpeo11@gmail.com> added the comment: Ha, ok that would explain it. Yes, I think it would indeed be helpful to update the example, but then again I guess leaving it as is may be a good way to find out if people are reading the docs. On Thu, Jan 3, 2019 at 10:21 PM Martin Panter <report@bugs.python.org> wrote:
Martin Panter <vadmium+py@gmail.com> added the comment:
This was changed in Python 3.2+ in Issue 16723. The response object no longer sets the “closed” attribute when it runs out of data; it is only set when the “close” method is called. Perhaps the example should be amended so that it checks if “read” returned an empty string, rather than checking “closed”.
Another problem with the example is that printing the chunk as a bytes object can trigger BytesWarning. I would add a “repr” call to avoid that.
---------- assignee: -> docs@python components: +Documentation nosy: +docs@python, martin.panter
_______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35649> _______________________________________
---------- title: http.client doesn't close. Infinite loop -> http.client doesn't close. Infinite loop _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue35649> _______________________________________
participants (2)
-
Martin Panter
-
skorpeo