Change by Rahul Kumaresan : ---------- nosy: +rahul-kumi _______________________________________ Python tracker https://bugs.python.org/issue43978 _______________________________________

Change by Miguel Brito : ---------- keywords: +patch nosy: +miguendes nosy_count: 3.0 -> 4.0 pull_requests: +24450 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/25760 _______________________________________ Python tracker https://bugs.python.org/issue43978 _______________________________________

Ken Jin added the comment: Hi Miguel, with reference to https://github.com/python/cpython/pull/25760#issuecomment-830338306, Guido rejected the PR because he said that the current docs are correct. This is a major point of confusion for many people, but here's why a single feature can be added in 2 versions: PEP 484 (Type Hints) was initially accepted as 'Provisional' (you can see what this means in PEP 1). To spare you the details, it's a special pass for typing.py to add new features in point releases, and to backport new features to older versions - even if they aren't bugfixes! This goes against what most of CPython allows (new features usually aren't allowed to be backported). However, at the time, typing.py was pretty new, so there wasn't much existing code to break anyways. Another example is asyncio. Which has since lost its provisional status a long time ago AFAIK. typing.py became de-facto non-provisional in 3.7, though PEP 484 hasn't been updated yet. This is why you may see stuff overlapping between 3.5 and 3.6. I hope you learnt something cool :). Hope to see you around contributing to other parts of CPython! ---------- nosy: +kj resolution: -> not a bug stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker https://bugs.python.org/issue43978 _______________________________________

Ken Jin added the comment: To answer the person who posted this on docs mailing list, after much investigation, it seems that this made it into 3.7.0, 3.5.4 and 3.6.2 . Here's the 3.7.0 (alpha) commit for the initial implementation of typing.NoReturn: https://github.com/python/cpython/commit/f06e0218ef6007667f5d61184b85a81a046... The backport to 3.6 (at the time, this was 3.6.2rc1): https://github.com/python/cpython/commit/e612c28513b406779d187e5f816445c7d40... The backport to 3.5 (at the time, this was 3.5.4rc1): https://github.com/python/cpython/commit/4b15e45895ca56ac5f7837cacb8cd3ccc26... I'm sorry if I got anything wrong (this is somewhat confusing for me too). ---------- _______________________________________ Python tracker https://bugs.python.org/issue43978 _______________________________________