[issue20521] [PATCH] Cleanup for "dis" module documentation
New submission from Sven Berkvens-Matthijsse: The documentation for the "dis" module has a wrong opcode name in it (POP_STACK instead of POP_TOP). Furthermore, the patch fixes inconsistent use of markers for code and opcodes. ---------- assignee: docs@python components: Documentation files: dis-doc.patch keywords: patch messages: 210314 nosy: docs@python, svenberkvens priority: normal severity: normal status: open title: [PATCH] Cleanup for "dis" module documentation type: behavior versions: Python 3.4 Added file: http://bugs.python.org/file33929/dis-doc.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Changes by Berker Peksag <berker.peksag@gmail.com>: ---------- nosy: +ncoghlan stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Changes by Antoine Pitrou <pitrou@free.fr>: ---------- versions: +Python 2.7, Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Mark Lawrence added the comment: Could someone review the patch please, it doesn't appear to contain anything that's contentious. ---------- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Roundup Robot added the comment: New changeset 617feb5d8af2 by Berker Peksag in branch '3.4': Issue #20521: Change ``TOS`` to TOS in dis documentation. https://hg.python.org/cpython/rev/617feb5d8af2 New changeset a331d71bdc0a by Berker Peksag in branch 'default': Issue #20521: Change ``TOS`` to TOS in dis documentation. https://hg.python.org/cpython/rev/a331d71bdc0a ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Berker Peksag added the comment: Thanks for the patch, Sven. Most of the changes in your patch have already been fixed in issue 22845. Just committed the "``TOS`` -> TOS" part of the patch. ---------- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed title: [PATCH] Cleanup for "dis" module documentation -> Cleanup for "dis" module documentation _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Changes by Berker Peksag <berker.peksag@gmail.com>: ---------- nosy: +ncoghlan stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Changes by Antoine Pitrou <pitrou@free.fr>: ---------- versions: +Python 2.7, Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Mark Lawrence added the comment: Could someone review the patch please, it doesn't appear to contain anything that's contentious. ---------- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Roundup Robot added the comment: New changeset 617feb5d8af2 by Berker Peksag in branch '3.4': Issue #20521: Change ``TOS`` to TOS in dis documentation. https://hg.python.org/cpython/rev/617feb5d8af2 New changeset a331d71bdc0a by Berker Peksag in branch 'default': Issue #20521: Change ``TOS`` to TOS in dis documentation. https://hg.python.org/cpython/rev/a331d71bdc0a ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
Berker Peksag added the comment: Thanks for the patch, Sven. Most of the changes in your patch have already been fixed in issue 22845. Just committed the "``TOS`` -> TOS" part of the patch. ---------- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed title: [PATCH] Cleanup for "dis" module documentation -> Cleanup for "dis" module documentation _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue20521> _______________________________________
participants (5)
-
Antoine Pitrou -
Berker Peksag
-
Mark Lawrence
-
Roundup Robot
-
Sven Berkvens-Matthijsse