[issue28960] Small typo in Thread.join docs
New submission from Ryan: There is a '--' before a ',' that doesn't make sense here: https://docs.python.org/3/library/threading.html#threading.Thread.join ---------- assignee: docs@python components: Documentation files: fixdoc.patch keywords: patch messages: 283101 nosy: docs@python, rcorre priority: normal severity: normal status: open title: Small typo in Thread.join docs type: enhancement versions: Python 3.7 Added file: http://bugs.python.org/file45875/fixdoc.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28960> _______________________________________
Changes by Martin Panter <vadmium+py@gmail.com>: ---------- stage: -> commit review versions: +Python 3.5, Python 3.6 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28960> _______________________________________
Evan added the comment: I think the patch should remove the comma, not the double dash. This is a parenthetical remark and should end the same way it starts. See https://www.grammarly.com/handbook/punctuation/dash/2/dash-parenthetical-inf... ---------- nosy: +evan_ _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28960> _______________________________________
Ryan added the comment: Removing the comma instead of the double-dash ---------- Added file: http://bugs.python.org/file45898/fixdoc2.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28960> _______________________________________
Roundup Robot added the comment: New changeset 9347d0b2ee08 by Martin Panter in branch '3.5': Issue #28960: Drop comma attached to dash in Thread.join() description https://hg.python.org/cpython/rev/9347d0b2ee08 New changeset d70fcf1866ad by Martin Panter in branch '3.6': Issue #28960: Merge Thread.join() doc from 3.5 https://hg.python.org/cpython/rev/d70fcf1866ad New changeset cefcfacd87e4 by Martin Panter in branch 'default': Issue #28960: Merge Thread.join() doc from 3.6 https://hg.python.org/cpython/rev/cefcfacd87e4 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28960> _______________________________________
Martin Panter added the comment: I agree the second patch is more correct. This undoes the change as it was introduced in revision c4cf1b886d6b and matches the Python 2 text. ---------- nosy: +martin.panter resolution: -> fixed stage: commit review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28960> _______________________________________
beautifuljose <terryjosephinee@gmail.com> added the comment: I think both dash and comma should be removed Found a similar problem here: https://www.paperhelp.org/essay/buy-argumentative-essay.html ---------- nosy: +beautifuljose _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28960> _______________________________________
Change by Martin Panter <vadmium+py@gmail.com>: ---------- Removed message: https://bugs.python.org/msg328245 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28960> _______________________________________
participants (5)
-
beautifuljose -
Evan
-
Martin Panter
-
Roundup Robot
-
Ryan