[issue38467] Misspelled argument names for typing.get_origin and get_args
New submission from Sebastian Rittau <srittau@rittau.biz>: The arguments for typing.get_origin() and typing.get_args() are named "typ" in the documentation (https://docs.python.org/3.8/library/typing.html#typing.get_origin), while they are named "tp" in the implementation. Important if used as keyword argument. ---------- assignee: docs@python components: Documentation messages: 354590 nosy: docs@python, srittau priority: normal severity: normal status: open title: Misspelled argument names for typing.get_origin and get_args versions: Python 3.8 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
Change by Karthikeyan Singaravelan <tir.karthi@gmail.com>: ---------- nosy: +levkivskyi _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
Ivan Levkivskyi <levkivskyi@gmail.com> added the comment: I think adjusting the docs would be less disruptive than changing implementation. Would you like to make a PR? ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
Change by Sebastian Rittau <srittau@rittau.biz>: ---------- keywords: +patch pull_requests: +16326 stage: -> patch review pull_request: https://github.com/python/cpython/pull/16753 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
Sebastian Rittau <srittau@rittau.biz> added the comment: https://github.com/python/cpython/pull/16753 ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
Ivan Levkivskyi <levkivskyi@gmail.com> added the comment: New changeset fdfe2833ace93021278fe4c41c40e1d08d70abf9 by Ivan Levkivskyi (Sebastian Rittau) in branch 'master': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/fdfe2833ace93021278fe4c41c40e1d08d7... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +16327 pull_request: https://github.com/python/cpython/pull/16754 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset c732660b7b18352ba8524ac78d39975afe4392ef by Miss Islington (bot) in branch '3.8': bpo-38467: Fix argument name of typing functions (GH-16753) https://github.com/python/cpython/commit/c732660b7b18352ba8524ac78d39975afe4... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
Change by Ivan Levkivskyi <levkivskyi@gmail.com>: ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue38467> _______________________________________
participants (4)
-
Ivan Levkivskyi -
Karthikeyan Singaravelan
-
miss-islington
-
Sebastian Rittau