Christian Heimes <lists@cheimes.de> added the comment: Your PR changed way to many aspects of the code in one commit. I also don't like the fact, that you pushed such a big change without waiting for my feedback. For the past two weeks I have been travelling to conferences and had no time to review your PR. There was no need to rush it. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue33729> _______________________________________