Changes by Sandro Tosi : Added file: http://bugs.python.org/file24558/list_sort-py32.diff _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

Éric Araujo added the comment: If I had read your patched version when I was a beginner, I don’t think it would have helped me much. (Sorry for not coming up with an alternative right now, it’s late/early here and I’m tired :) ---------- nosy: +eric.araujo, terry.reedy _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

Éric Araujo added the comment: Nope, the expression would be hyphenated only when used as an adjective: - “This sorts the sequence in place” vs. ‑ “Performs an in-place rearrangement by birthdate” ---------- _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

Ezio Melotti added the comment:

Why do the patches attached to this issue not have a "review" link?

because

both (2.7 and 3.2) patches do not line up with the current 2.7 and 3.x tip, both hunks get rejected.

The "review" link only appears if the patch applies cleanly on the "default" branch. Preparing a new patch against "default" should make the link appear. ---------- type: -> enhancement versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

R. David Murray added the comment: The review link will also appear if the patch is generated via hg diff with diff.git turned *off*. You will note that both existing patches use --git, which omits parent changeset information, so our system can't figure out what to apply them against in order to generate the review link. ---------- nosy: +r.david.murray _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

Andy Maier added the comment: Uploaded patch version py34_v2, which contains the following changes relative to 3.4: 1. The changes in the description of list.sort() from "default" in list.sort(), by adding this text: (the arguments can be used for sort customization, see :func:`sorted` for their explanation) 2. The proposed extension of the description of list.sort() from patch version py32. 3. A statement that TypeError is raised if the ordering relationship is not established. 4. A reference where to look in order to establish ordering relationship for user-defined classes. (referencing the Basic customization section of the Language Reference). 5. A reference where the ordering relationships for built-in types are described (referencing the Comparison chapter of the Language Reference). -> Please review. Andy ---------- Added file: http://bugs.python.org/file35854/issue14050-list_sort-py34_v2.diff _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

Andy Maier added the comment: Comments on v2 of both patches: 1. The paragraph "Each item needs to ..." describes the requirement in terms of "ordering relationships between items". It would be both simpler and less ambiguous to describe the requirement in terms of "type must be orderable". See the text added to sorted() as part of the patch for issue10289, for details. ---------- _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

Martin Panter added the comment: The first paragraph in the patch already seems to have been applied, for Issue 21575. The Sorting How-to https://docs.python.org/dev/howto/sorting.html#odd-and-ends already guarantees that defining only __lt__() is sufficient for sorted() and list.sort(). And the list.sort() specification https://docs.python.org/dev/library/stdtypes.html#list.sort says “only < comparisons” are used, which implies that only __gt__() may also be sufficient. It might be good to change “ordering relationship” to “total ordering relationship”, but I think further explanation and other details are probably not worth adding to the tutorial. They could be clarified in the main documentation, but that is probably a separate issue. ---------- nosy: +vadmium _______________________________________ Python tracker http://bugs.python.org/issue14050 _______________________________________

Raymond Hettinger added the comment: New changeset 4109263a7edce11194e301138cf66fa2d07f7ce4 by Raymond Hettinger in branch 'master': bpo-14050: Note that not all data can be sorted (GH-15381) https://github.com/python/cpython/commit/4109263a7edce11194e301138cf66fa2d07... ---------- _______________________________________ Python tracker https://bugs.python.org/issue14050 _______________________________________

Raymond Hettinger added the comment: New changeset cb8de91dadf15925fb95069cb190398e1d485f56 by Raymond Hettinger (Miss Islington (bot)) in branch '3.8': bpo-14050: Note that not all data can be sorted (GH-15381) (GH-15395) https://github.com/python/cpython/commit/cb8de91dadf15925fb95069cb190398e1d4... ---------- _______________________________________ Python tracker https://bugs.python.org/issue14050 _______________________________________