[issue43954] Possible missing word on unittest doc
New submission from Julien Palard <julien+python@palard.fr>: In https://docs.python.org/3/library/unittest.html I see:
Note that you need to the top level directory too.
Trying to guess, the missing word may be "specify":
Changed in version 3.4: Test discovery supports namespace packages for start directory. Note that you need to specify the top level directory too. (e.g. python -m unittest discover -s root/namespace -t root).
Am I right? ---------- assignee: docs@python components: Documentation messages: 392060 nosy: docs@python, mdk, methane priority: normal severity: normal status: open title: Possible missing word on unittest doc versions: Python 3.10, Python 3.11, Python 3.7, Python 3.8, Python 3.9 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Raymond Hettinger <raymond.hettinger@gmail.com> added the comment: Yes, "specify" is likely the missing word. ---------- nosy: +rhettinger _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Change by Zackery Spytz <zspytz@gmail.com>: ---------- keywords: +patch nosy: +ZackerySpytz nosy_count: 4.0 -> 5.0 pull_requests: +24363 stage: -> patch review pull_request: https://github.com/python/cpython/pull/25672 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Inada Naoki <songofacandy@gmail.com> added the comment: namespace package support is broken since Python 3.7. See https://bugs.python.org/issue23882#msg387549 We can not use namespace package even if top level directory is specified. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Inada Naoki <songofacandy@gmail.com> added the comment: I propose to remove the namespace package support entirely. * No user (since it has been broken from Python 3.7) * Hard to maintain (we haven't noted it) * Hard to explain (need to specify the top directory. don't search recursively. See bpo-23882) ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment:
I propose to remove the namespace package support entirely.
I'm no unittest expert, but I have nothing against removing it. I totally agree to at least remove it from the doc while it does not work. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Change by Raymond Hettinger <raymond.hettinger@gmail.com>: ---------- nosy: +larry _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Change by Larry Hastings <larry@hastings.org>: ---------- nosy: -larry _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: New changeset 2abbd8f2add5e80b86a965625b9a77ae94a101cd by Zackery Spytz in branch 'master': bpo-43954: Fix a missing word in the unittest docs (GH-25672) https://github.com/python/cpython/commit/2abbd8f2add5e80b86a965625b9a77ae94a... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- nosy: +miss-islington nosy_count: 5.0 -> 6.0 pull_requests: +24431 pull_request: https://github.com/python/cpython/pull/25741 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: As far as this issue is concerned, it's fixed. The discussion about this feature not working can continue in the appropriate issue (23882) ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset a92d7387632de1fc64de51f22f6191acd0c6f5c0 by Miss Islington (bot) in branch '3.9': bpo-43954: Fix a missing word in the unittest docs (GH-25672) https://github.com/python/cpython/commit/a92d7387632de1fc64de51f22f6191acd0c... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue43954> _______________________________________
participants (6)
-
Inada Naoki -
Julien Palard
-
Larry Hastings
-
miss-islington
-
Raymond Hettinger
-
Zackery Spytz