[issue26213] Document BUILD_LIST_UNPACK & BUILD_TUPLE_UNPACK

New submission from Brett Cannon: Turns out the BUILD_TUPLE_UNPACK and BUILD_LIST_UNPACK opcodes are undocumented in the dis module. ---------- assignee: docs@python components: Documentation messages: 258985 nosy: benjamin.peterson, brett.cannon, docs@python priority: low severity: normal stage: needs patch status: open title: Document BUILD_LIST_UNPACK & BUILD_TUPLE_UNPACK versions: Python 3.6 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Brett Cannon added the comment: There are also BUILD_SET_UNPACK and BUILD_MAP_UNPACK as well. ---------- title: Document BUILD_LIST_UNPACK & BUILD_TUPLE_UNPACK -> Document BUILD_*_UNPACK opcodes _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Serhiy Storchaka added the comment: And BUILD_MAP_UNPACK_WITH_CALL. All these opcodes were added in issue2292 for implementing PEP 448, but are not documented even in the PEP. ---------- nosy: +Joshua.Landau, neil.g, serhiy.storchaka, twouters _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Serhiy Storchaka added the comment: At the same time the semantic of the BUILD_MAP opcode was changed. However the documentation was not updated and currently it doesn't match the implementation. This caused an issue in third-party projects that operate with bytecode. See also issue28810 for documenting bytecode changes in 3.6. ---------- priority: low -> high type: -> behavior versions: +Python 3.5, Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Changes by Berker Peksag <berker.peksag@gmail.com>: ---------- nosy: +berker.peksag _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Changes by Ivan Levkivskyi <levkivskyi@gmail.com>: ---------- nosy: +levkivskyi _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Changes by Ivan Levkivskyi <levkivskyi@gmail.com>: ---------- pull_requests: +200 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Changes by Brett Cannon <brett@python.org>: ---------- assignee: docs@python -> brett.cannon _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Changes by Brett Cannon <brett@python.org>: ---------- pull_requests: +366 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Changes by Brett Cannon <brett@python.org>: ---------- pull_requests: +367 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Brett Cannon added the comment: Thanks to Ivan for the PRs! ---------- resolution: -> fixed stage: needs patch -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Brett Cannon added the comment: New changeset 4d0630d9d5ff4919caa463a64887f32d671eaab8 by Brett Cannon in branch '3.5': bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (GH-441) https://github.com/python/cpython/commit/4d0630d9d5ff4919caa463a64887f32d671... ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Brett Cannon added the comment: New changeset 226af23e858e2914cf78dfa6fd441c7b90a4cc91 by Brett Cannon in branch '3.6': bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (GH-440) https://github.com/python/cpython/commit/226af23e858e2914cf78dfa6fd441c7b90a... ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________

Brett Cannon added the comment: New changeset 0705f66eb369aa6a6cdb699e24ff61e1ab2e0c56 by Brett Cannon (Ivan Levkivskyi) in branch 'master': bpo-26213: Document _UNPACK bytecodes and BUILD_MAP changes (#238) https://github.com/python/cpython/commit/0705f66eb369aa6a6cdb699e24ff61e1ab2... ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue26213> _______________________________________
participants (4)
-
Berker Peksag
-
Brett Cannon
-
Ivan Levkivskyi
-
Serhiy Storchaka