[issue12042] What's New multiprocessing example error
New submission from Davi Post <post@pobox.com>: In this section: http://docs.python.org/whatsnew/2.6.html#pep-371-the-multiprocessing-package This sentence follows the first example: "A Queue is used to communicate the input parameter N and the result." In the example, the queue is used only for the result, not the input parameter N. [P.S. I'd be happy to submit corrections, but don't want to have to install and learn Mercurial. Is there a simpler way?] ---------- assignee: docs@python components: Documentation messages: 135626 nosy: davipo, docs@python priority: normal severity: normal status: open title: What's New multiprocessing example error versions: Python 2.6 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Ezio Melotti <ezio.melotti@gmail.com> added the comment: The workflow to prepare a patch using Mercurial is pretty much the same as SVN: # get a clone (checkout) of the repository hg clone http://hg.python.org/cpython # select the branch where you want to fix the issue hg update 2.7 # make changes on the file(s) and make a patch hg diff > issue12042.diff See also http://docs.python.org/devguide/setup.html Also note that 2.6 only receives security fixes, so it can't be fixed there. All the "whatsnew" files are also included in the following versions though, so it might be worth preparing a patch against 2.7. ---------- nosy: +ezio.melotti versions: +Python 2.7 -Python 2.6 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Jordan Stadler <jordan.stadler@gmail.com> added the comment: I'll prepare the patch if davipo doesn't want to. I'm trying to become more comfortable with the patching process and this seems simple enough for me to handle. ---------- nosy: +jstadler _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Changes by Jordan Stadler <jordan.stadler@gmail.com>: ---------- keywords: +patch Added file: http://bugs.python.org/file22002/issue12042_2.7.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Jordan Stadler <jordan.stadler@gmail.com> added the comment: Patch is up for 2.7, minor change in the documentation. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Éric Araujo <merwok@netwok.org> added the comment: I’m not sure historical whatsnew documents get fixes. As long as the PEPs and docs get fixes, the whatsnew can stay as they are. ---------- nosy: +eric.araujo _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Davi Post <post@pobox.com> added the comment: The What's New docs are the place to find information on changes between versions. Upgrading to 2.7 from 2.5, I needed to read the 2.6 and 2.7 What's New docs to learn what changes I should be aware of. I hope errors in these docs will be fixed, at least for a few versions back. (This particular fix is not so important, but I'm trying to practice the habit of at least reporting problems I see, to make a contribution to Python.) ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Jordan Stadler <jordan.stadler@gmail.com> added the comment: Alright, should it be closed if we aren't going to touch it? ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Éric Araujo <merwok@netwok.org> added the comment: Let’s fix it in the open branches. ---------- versions: +Python 3.1, Python 3.2, Python 3.3 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Changes by Jordan Stadler <jordan.stadler@gmail.com>: Added file: http://bugs.python.org/file22127/issue12042_31.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Changes by Jordan Stadler <jordan.stadler@gmail.com>: Added file: http://bugs.python.org/file22128/issue12042_32.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Jordan Stadler <jordan.stadler@gmail.com> added the comment: Alright, patches are up for 3.1 and 3.2. I'm not sure if I can just make one for the 3.x's so I made both. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Davi Post <post@pobox.com> added the comment: Thanks Jordan. How about 2.7? Is that not an open branch? --Davi On Thu, May 26, 2011 at 12:17 PM, Jordan Stadler <report@bugs.python.org>wrote:
Jordan Stadler <jordan.stadler@gmail.com> added the comment:
Alright, patches are up for 3.1 and 3.2. I'm not sure if I can just make one for the 3.x's so I made both.
----------
_______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
---------- Added file: http://bugs.python.org/file22141/unnamed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Jordan Stadler <jordan.stadler@gmail.com> added the comment: To be honest, I'm getting a bit confused as to what is required. I thought the two most important patches would be 2.7 and 3.2, but we have 2.7, 3.1, 3.2, and 3.3 listed as versions affected. I posted the patch for 2.7 originally on May 14th. I'm not sure if there is a problem with that patch I posted, but Eric didn't seem content with the versions. At this time versions 3.1, 3.2, and 3.3 were added to the affected versions list. Today I did the patches for 3.1 and 3.2, but I am unsure of how to provide one for 3.3 as is is not listed in mercurial for me (I'm probably doing something wrong, but I couldn't see it). The change in the patch is so minor and I don't mind doing 3.3 if I can get my mercurial to update to 3.3. If the change I made in the patches is insufficient please let me know, I have no problem making adjustments. I'm still getting used to the patching process and how to properly contribute to the community. TLDR: Basically, I'm a little confused as to whether or not the patches I provided are sufficient. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
R. David Murray <rdmurray@bitdance.com> added the comment: Sometimes only one patch is needed, if it applies cleanly to both python2 and python3. If it doesn't, then two patches are useful, one for python2.7 and one for python3.2. (The last version of 3.1 is about to be released, so I don't think it likely that the fix will get in to that version.) We will use hg merge to merge it into 3.3, which is simply the 'default' head in the repository. ---------- nosy: +r.david.murray _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Changes by Raymond Hettinger <raymond.hettinger@gmail.com>: ---------- nosy: +rhettinger _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Jordan Stadler <jordan.stadler@gmail.com> added the comment: Alright, thanks for the clarification, that's pretty much how I thought it worked. Patches supplied should be good then. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Changes by Éric Araujo <merwok@netwok.org>: Removed file: http://bugs.python.org/file22141/unnamed _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Roundup Robot <devnull@psf.upfronthosting.co.za> added the comment: New changeset 3353f9747a39 by Sandro Tosi in branch '2.7': Issue #12042: a queue is only used to retrive results; preliminary patch by Jordan Stadler http://hg.python.org/cpython/rev/3353f9747a39 New changeset 0d4bb1356f39 by Sandro Tosi in branch '3.2': Issue #12042: a queue is only used to retrive results; preliminary patch by Jordan Stadler http://hg.python.org/cpython/rev/0d4bb1356f39 New changeset e379617b4c4c by Sandro Tosi in branch 'default': Issue #12042: merge with 3.2 http://hg.python.org/cpython/rev/e379617b4c4c ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
Sandro Tosi <sandro.tosi@gmail.com> added the comment: Thanks Davi for the report and Jordan for the patch! Jordan, a tip for your (hopefully) future contributions: for doc patches, please don't re-indent the whole paragraph, since it makes harder to identify the actual changes, just change what is needed, and the committer will take care (if needed) to re indent the paragraph. I've re-edited a bit and committed the fix in the active branches. ---------- nosy: +sandro.tosi resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: -Python 3.1 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue12042> _______________________________________
participants (8)
-
Davi Post -
Ezio Melotti
-
Jordan Stadler
-
R. David Murray
-
Raymond Hettinger
-
Roundup Robot
-
Sandro Tosi
-
Éric Araujo