[issue31146] Docs: On non-public translations, language picker fallback to "English"
New submission from Julien Palard: As, by default, "english" is selected, and as we're building translations far before rendering them public by adding them to the language switcher, there's a timespan where a human can voluntarily land on a translation with a language switcher unaware of this language. The language switcher currently defaults to english, so english is selected. As "english" is already selected, one can't select "english" to navigate to the english version. Solutions may be to just hide the select element on unknown translations, or display the unknown language tag. With more work and a "predicted" list of tags-names, it may be possible to also display the name of the language. Code is here: https://github.com/python/cpython/blob/master/Doc/tools/static/switchers.js I'll take a look, but if some want to do it, let me know. ---------- assignee: docs@python components: Documentation messages: 299932 nosy: docs@python, mdk priority: normal severity: normal status: open title: Docs: On non-public translations, language picker fallback to "English" type: enhancement versions: Python 2.7, Python 3.6, Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue31146> _______________________________________
Changes by Ned Deily <nad@python.org>: ---------- nosy: +ned.deily _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue31146> _______________________________________
Change by Karthikeyan Singaravelan <tir.karthi@gmail.com>: ---------- nosy: +xtreak _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
Change by Julien Palard <julien+python@palard.fr>: ---------- keywords: +patch pull_requests: +9804 stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
Julien Palard <julien+python@palard.fr> added the comment: New changeset 6b73bb523a176123a819e4ebac3727d31d861515 by Julien Palard in branch 'master': bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. (GH-10558) https://github.com/python/cpython/commit/6b73bb523a176123a819e4ebac3727d31d8... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +9852 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +9853 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +9854 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset df6374e15aadff7eb547fc210c0f4f28bbff7010 by Miss Islington (bot) in branch '3.7': bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. (GH-10558) https://github.com/python/cpython/commit/df6374e15aadff7eb547fc210c0f4f28bbf... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset c487cf9261c61f0db4e5d1df3c83a60384b330db by Miss Islington (bot) in branch '3.6': bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. (GH-10558) https://github.com/python/cpython/commit/c487cf9261c61f0db4e5d1df3c83a60384b... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset fcbcebadff46f907b38fcf2d79adb3209c5a205d by Miss Islington (bot) in branch '2.7': bpo-31146: Don't fallback switcher to english on not-yet pusblished languages. (GH-10558) https://github.com/python/cpython/commit/fcbcebadff46f907b38fcf2d79adb3209c5... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
Change by Julien Palard <julien+python@palard.fr>: ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue31146> _______________________________________
participants (4)
-
Julien Palard
-
Karthikeyan Singaravelan
-
miss-islington
-
Ned Deily