[issue23410] Document more BaseHTTPRequestHandler attributes
New submission from Martin Panter:
[Padding to avoid Error: 'utf8' codec can't decode bytes in position 189-190: invalid continuation byte]
This is a patch to document two attributes of http.server.BaseHTTPRequestHandler: “close_connection” and “requestline”. Normally these are set by the handle_one_request() method, but when overriding that method, you need to know to set these attributes.
----------
assignee: docs@python
components: Documentation
messages: 235554
nosy: docs@python, vadmium
priority: normal
severity: normal
status: open
title: Document more BaseHTTPRequestHandler attributes
type: enhancement
_______________________________________
Python tracker
Changes by Martin Panter
Changes by Demian Brecht
Demian Brecht added the comment:
Minor comment in Rietveld, otherwise LGTM.
----------
_______________________________________
Python tracker
Martin Panter added the comment:
Posting another patch which hopefully explains the “requestline” attribute a bit better. Let me know if you have any ideas for better wording.
----------
Added file: http://bugs.python.org/file38141/http-attributes.v2.patch
_______________________________________
Python tracker
Martin Panter added the comment:
Posting patch v3. It is based on Demian’s suggested wording for the requestline attribute, but adjusted to match the other entries, and to mention the empty string.
----------
Added file: http://bugs.python.org/file38157/http-attributes.v3.patch
_______________________________________
Python tracker
Demian Brecht added the comment:
LGTM
----------
_______________________________________
Python tracker
Demian Brecht added the comment:
Added Library component as there are a few newly added tests as well though and cosmetic changes were made to server.py.
----------
components: +Library (Lib)
_______________________________________
Python tracker
Changes by Berker Peksag
Roundup Robot added the comment:
New changeset f9ff2a5bbbe2 by Benjamin Peterson in branch '3.4':
document the requestline and close_connection attributes, use real booleans, and add tests (closes #23410)
https://hg.python.org/cpython/rev/f9ff2a5bbbe2
New changeset 6e3e252cf047 by Benjamin Peterson in branch 'default':
merge 3.4 (#23410)
https://hg.python.org/cpython/rev/6e3e252cf047
----------
nosy: +python-dev
resolution: -> fixed
stage: -> resolved
status: open -> closed
_______________________________________
Python tracker
participants (4)
-
Berker Peksag -
Demian Brecht
-
Martin Panter
-
Roundup Robot