[issue28677] difficult to parse sentence structure in "When an instance attribute is referenced that isn't a data attribute"
New submission from Viorel Tabara: Method objects are explained at: https://docs.python.org/3/tutorial/classes.html#method-objects I'd like to suggest a change from: When an instance attribute is referenced that isn’t a data attribute, its class is searched. to something along this line: When an instance attribute --- that isn’t a data attribute --- is referenced, the instance parent class will be searched. ---------- assignee: docs@python components: Documentation messages: 280671 nosy: docs@python, viorel priority: normal severity: normal status: open title: difficult to parse sentence structure in "When an instance attribute is referenced that isn't a data attribute" type: enhancement _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28677> _______________________________________
R. David Murray added the comment: "instance parent class" is not terminology used in our docs as far as I remember. "instance's class" would be more in line with the other docs. That would solve the pronoun reference problem more succinctly, I think. How about this version, which also improves the awkward phrasing, but without using em-dashes: "When a non-data attribute of an instance is referenced, the instance's class is searched." ---------- nosy: +r.david.murray _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28677> _______________________________________
Viorel Tabara added the comment: David, that sounds clear enough to me, thanks. However, English isn't my first language so I can't comment on the grammatical subtleties. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28677> _______________________________________
Terry J. Reedy added the comment: David's wording looks good. ---------- nosy: +terry.reedy _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue28677> _______________________________________
Change by Cheryl Sabella <chekat2@gmail.com>: ---------- keywords: +easy stage: -> needs patch versions: +Python 3.7, Python 3.8 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Change by Steven Downum <devilaether@gmail.com>: ---------- nosy: +steven.downum _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Change by Aaron Ang <awz.ang@gmail.com>: ---------- keywords: +patch pull_requests: +5952 stage: needs patch -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Tal Einat <taleinat@gmail.com> added the comment: New changeset c0f0a7669c73c0d444851dd4c5299de2479214cc by Tal Einat (Aaron Ang) in branch 'master': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/c0f0a7669c73c0d444851dd4c5299de2479... ---------- nosy: +taleinat _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +7985 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +7986 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +7993 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 1c8f6553ad5a7f97495972da8f35f4dabcb372d4 by Miss Islington (bot) in branch '2.7': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/1c8f6553ad5a7f97495972da8f35f4dabcb... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset cfadd1c2421e13d76d588982147d4fbdc71d5527 by Miss Islington (bot) in branch '3.6': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/cfadd1c2421e13d76d588982147d4fbdc71... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Tal Einat <taleinat@gmail.com> added the comment: New changeset ec02c58f5a6fdb06b769f53255fcb5d393812160 by Tal Einat (Miss Islington (bot)) in branch '3.7': bpo-28677: Improve phrasing of when instance attribute is referenced (GH-6208) https://github.com/python/cpython/commit/ec02c58f5a6fdb06b769f53255fcb5d3938... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
Tal Einat <taleinat@gmail.com> added the comment: Thanks for the PR, Aaron! ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7, Python 3.6 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue28677> _______________________________________
participants (8)
-
Aaron Ang -
Cheryl Sabella
-
miss-islington
-
R. David Murray
-
Steven Downum
-
Tal Einat
-
Terry J. Reedy
-
Viorel Tabara