Georg Brandl added the comment: Thanks for the patch! The amount of unrelated changes (mostly removing ">>>" empty prompts) makes this a bit hard to review. Also, I don't think it is too important to link to the "ctypes" module from within the docs of ctypes :) Please separate out the implementation of the Union classes into a separate patch. The Array docs look good to me. The _Pointer docs talk about "reading and writing the elements using standard subscript and slice accesses". That is true for pointers pointing to arrays, but ".contents" should be mentioned as well. ---------- nosy: +georg.brandl _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19023> _______________________________________

Adam Knight added the comment: Can someone add this in? What needs to be done to make it happen? Kind of need this for a project I'm working on... ---------- nosy: +ahknight _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19023> _______________________________________

Martin Panter added the comment: Here is the patch stripped of all the noise and the structure and union stuff, so you can see just the changes related to arrays and pointers. However I have not attempted to apply the patch, nor addressed Georg’s comment about the “contents” attribute. ---------- nosy: +vadmium Added file: http://bugs.python.org/file36188/arrays-pointers.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19023> _______________________________________

Changes by Martin Panter <vadmium+py@gmail.com>: ---------- stage: -> patch review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19023> _______________________________________

Martin Panter added the comment: Sye van der Veen: can you sign a contributor agreement <https://www.python.org/psf/contrib/contrib-form/>? I think it might be needed for this patch. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19023> _______________________________________

Roundup Robot added the comment: New changeset 732fdd03e708 by Martin Panter in branch '3.5': Issue #19023: Document ctypes array and pointer classes https://hg.python.org/cpython/rev/732fdd03e708 New changeset a78cbb2125a8 by Martin Panter in branch 'default': Issue #19023: Merge ctypes doc and tests from 3.5 https://hg.python.org/cpython/rev/a78cbb2125a8 ---------- nosy: +python-dev _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19023> _______________________________________

Martin Panter added the comment: Okay I have committed the Array and _Pointer stuff. I suggest if anyone wants to work on the Union classes, they open a separate report. (I never understood what they are for. C doesn’t have much little or big endian stuff; byte order mostly depends on the ABI, so why is ctypes different?) ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7, Python 3.6 -Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue19023> _______________________________________