STINNER Victor added the comment: PYTHONASYNCIODEBUG and PYTHONTRACEMALLOC are also missing. I didn't know that Python has a manual page :-) (Misc/python.man) Note: I added these 3 environment variables ;-) ---------- nosy: +haypo _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Joshua Jay Herman added the comment: Hi, I have alphabetized and added the missing Environment Variables according to Section 1.2 https://docs.python.org/3.6/using/cmdline.html#environment-variables . I also added the missing environment variables from that documentation section. Should Section 1.2 also be alphabetized? I noticed it wasn't. This is my first contribution to python (I also just filled out the contributor forms) any comments and criticism is appreciated. ---------- keywords: +patch nosy: +zitterbewegung Added file: http://bugs.python.org/file42932/addMissingEnvVarsAndAlphabetize.patch _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Berker Peksag added the comment:

Hi, I have alphabetized and [...]

Can you please de-alphabetize the list to make patch review a little bit easier? Thanks! ---------- nosy: +berker.peksag stage: needs patch -> patch review _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Berker Peksag added the comment: Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today. ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Joshua Jay Herman added the comment: I have reviewed the comments on Rietveld and made the changes to the patch. Attached is the revised version. ---------- Added file: http://bugs.python.org/file43248/addMissingEnvironmentVariables-review-1.pat... _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Changes by Stéphane Wirtel <stephane@wirtel.be>: ---------- nosy: +matrixise _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Joshua Jay Herman added the comment: Hi I performed the rebase on the default branch. ---------- Added file: http://bugs.python.org/file45041/rebased_addMissingEnvironmentalVariables.pa... _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Joshua Jay Herman added the comment: ping ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Berker Peksag added the comment: Thanks for the updated patch, Joshua. I will review and commit it this week. ---------- versions: +Python 3.7 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Changes by Antony Lee <anntzer.lee@gmail.com>: ---------- nosy: -Antony.Lee _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Berker Peksag added the comment: Thanks for the patch and sorry for my late response. I did some tweaks and am planning to commit the tweaked version of your patch this week. ---------- Added file: http://bugs.python.org/file46540/issue24459_cleanup.diff _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Joshua Jay Herman added the comment: Ping ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

STINNER Victor added the comment:

Was this ever merged?

No.

I'm not sure whats happening.

Hum, nothing is happening. In december, Berker wrote "Thanks for the updated patch, Joshua. I will review and commit it this week." and then it seems like he found issues, since he proposed a new patch. And then, nothing new happened. Nobody reviewed latest Berker's patch and Berker maybe forgot to push it. Can someone pick a recent patch and convert it to a GitHub PR? Berker, the author of the most recent patch, maybe? ---------- _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue24459> _______________________________________

Change by Berker Peksag <berker.peksag@gmail.com>: ---------- versions: -Python 3.5 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue24459> _______________________________________

Anant Prakash <anantprakashjsr@gmail.com> added the comment: Ignore my previous comment. My bad. ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue24459> _______________________________________

Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +7756 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue24459> _______________________________________

Berker Peksag <berker.peksag@gmail.com> added the comment: Thanks, Joshua! ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.6 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue24459> _______________________________________