[issue23554] EchoServerClientProtocol class should be called EchoServerProtocol
New submission from Giovanni Cannata: In 18.5.4.3.2. TCP echo server protocol the class in the example code is called EchoServerClientProtocol. It should be EchoServerProtocol. (The client protocol example is correctly called EchoClientProtocol). ---------- assignee: docs@python components: Documentation messages: 236932 nosy: docs@python, gc priority: normal severity: normal status: open title: EchoServerClientProtocol class should be called EchoServerProtocol versions: Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <http://bugs.python.org/issue23554> _______________________________________
Cheryl Sabella <cheryl.sabella@gmail.com> added the comment: Here's a link to the example that the original OP is referring to: https://docs.python.org/3/library/asyncio-protocol.html?highlight=echoserver... Since this doc page was recently rewritten, I'm not sure if this should be considered a typo. ---------- nosy: +cheryl.sabella, yselivanov versions: +Python 3.8 -Python 3.4 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
Andrew Svetlov <andrew.svetlov@gmail.com> added the comment: Agree, EchoServer is the better name ---------- nosy: +asvetlov _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
Cheryl Sabella <cheryl.sabella@gmail.com> added the comment: Thanks @asvetlov. I'm going to mark this as an Easy Documentation issue, good for a first-time contributor. ---------- keywords: +easy stage: -> needs patch type: -> enhancement _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
Andrew Svetlov <andrew.svetlov@gmail.com> added the comment: Cool! Thanks! ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
Change by Roundup Robot <devnull@psf.upfronthosting.co.za>: ---------- keywords: +patch pull_requests: +9227 stage: needs patch -> patch review _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
Yury Selivanov <yselivanov@gmail.com> added the comment: New changeset 43a5bd7b458f0ad2d62b00b033d025689d48d591 by Yury Selivanov (Braden Groom) in branch 'master': bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (GH-9859) https://github.com/python/cpython/commit/43a5bd7b458f0ad2d62b00b033d025689d4... ---------- _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
Change by miss-islington <mariatta.wijaya+miss-islington@gmail.com>: ---------- pull_requests: +9262 _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
Change by Yury Selivanov <yselivanov@gmail.com>: ---------- resolution: -> fixed stage: patch review -> resolved status: open -> closed _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
miss-islington <mariatta.wijaya+miss-islington@gmail.com> added the comment: New changeset 802de12d99d16e621537d454eac942d2f448afee by Miss Islington (bot) in branch '3.7': bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (GH-9859) https://github.com/python/cpython/commit/802de12d99d16e621537d454eac942d2f44... ---------- nosy: +miss-islington _______________________________________ Python tracker <report@bugs.python.org> <https://bugs.python.org/issue23554> _______________________________________
participants (6)
-
Andrew Svetlov -
Cheryl Sabella
-
Giovanni Cannata
-
miss-islington
-
Roundup Robot
-
Yury Selivanov