Hey Christoph On 10.09.2015 11:33, Christoph Groth wrote:
Thanks a lot for updating Arch Linux packaging of Kwant! Are you planning to maintain them for some time in future?
Sure, that's not a big deal, most of the work is done anyway
Your scripts look fine to me. I just noticed that we were still using *.sig for the signatures of the tinyarray tarballs. I now renamed those to *.asc (which seems to be more standard, e.g. it’s what PyPI requires). Can you take this change into account?
Will do.
Otherwise, you can verify that during the build Cython does not get run. It shouldn’t as the cythonized files are shipped in the tarball. If, however, during the Arch build process the files are copied and loose their proper timestamps it could happen that Cython will get run. In that case, there’s an option to setup.py to inhibit cython: --no-cython
I'll fix that, I just added it because I remembered my build failing due to a missing Cython in my virtualenv when I installed via pip yesterday. If the tarballs contain the cythonized files, this is an unnecessary dependency.
On debian / ubuntu we also build the documentation. Not sure whether it’s common to do this for Arch packages as well. The documentation is available online anyway.
I assume the documentation build process needs sphinx, is that correct? If so it might be easiest to factor out a documentation into a separate python2-kwant-doc package.
Also, could you please have a look at http://kwant-project.org/install#arch-linux and let me know if something could be improved there?
Yes! I forgot that in my last mail, a notice with which PGP key you make signatures and that this key needs to be added to the keyring of the user building the package would be most helpful. best, Jörg