Mailman 3 November 2005 - lxml - The Python XML Toolkit

[lxml-dev] _stripDeclaration underscore
by Martijn Faassen 11 Nov '05

11 Nov '05

Hi there, I think _stripDeclaration could be generally useful functionality, so perhaps we should remove the leading underscore? There's an issue with encodings that we may need to resolve in that case, but it might be worthwhile. Regards, Martijn

2 1

[lxml-dev] python segfault by XSLT tostring?
by Mechiel Lukkien 11 Nov '05

11 Nov '05

hi all, just tried lxml-0.8 and than the subversion lxml trunc, but both versions manage to segfault my python. libxml-2.6.16, libxslt-1.1.12, Pyrex-0.9.3, python-2.3.5, openbsd 3.8 is the configuration. in short: funicode at src/lxml/etree.pyx:1841 can get called with null/None as argument, after which isutf8 segfaults on it. this happens when i call tostring() on an lxml.etree.XSLT() object, with an empty document as argument (which was a result of a transformation). this is the code i ran: xsltfile = sys.argv[1] xmlfile = sys.argv[2] xsltdoc = lxml.etree.parse(open(xsltfile, 'r')) xslt = lxml.etree.XSLT(xsltdoc) xml = lxml.etree.parse(open(xmlfile, 'r')) result = xslt.apply(xml) print result print xslt.tostring(result) # can segfault python if result contains "empty document" this is the xslt file: <?xml version="1.0"?> <xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" version="1.0"> <xsl:template match="/"> </xsl:template> </xsl:stylesheet> and near-empty xml file: <?xml version="1.0"?> <blah></blah> i admit that i know next to nothing about xslt and very little about xml (i was just playing around), but lxml should never make python segfault, whatever stupid thing i do. my quick fix was to return an empty string at the start of funicode if the string is null. after this, it stopped segfaulting on this small example. good chance that breaks tostring() though. best regards, mechiel

4 7

[lxml-dev] Another simple test case that breaks the current element iterator implementation
by Stefan Behnel 11 Nov '05

11 Nov '05

I herefore declare the current implementation open for replacement. Index: src/lxml/tests/test_etree.py =================================================================== --- src/lxml/tests/test_etree.py (Revision 19543) +++ src/lxml/tests/test_etree.py (Arbeitskopie) @@ -409,6 +409,17 @@ del root[-1] self.assertEquals(['one', 'two'], result) + def test_iteration6(self): + XML = self.etree.XML + + root = XML('<doc><one/><two/></doc>') + result = [] + for el0 in root: + result.append(el0.tag) + for el1 in root: + result.append(el1.tag) + self.assertEquals(['one','one', 'two', 'two', 'one', 'two'], result) + def test_attribute_iterator(self): XML = self.etree.XML

3 24

[lxml-dev] PATCH: XMLSyntaxError
by Geert Jansen 08 Nov '05

08 Nov '05

Hi, the applied patch reparents two lxml exceptions from SyntaxError to Error. The advantage is that any lxml error can now be caught by trapping just lxml.etree.Error. At the moment you need to catch both lxml.etree.Error and SyntaxError which is a nuisance. Besides that it's common interface design to have an inheritance hierarchy with a single root. Regards, Geert Index: etree.pyx =================================================================== --- etree.pyx (revision 19574) +++ etree.pyx (working copy) @@ -36,7 +36,7 @@ class Error(Exception): pass -class XMLSyntaxError(SyntaxError): +class XMLSyntaxError(Error): pass class XPathError(Error): @@ -51,7 +51,7 @@ class XPathResultError(XPathError): pass -class XPathSyntaxError(SyntaxError): +class XPathSyntaxError(Error): pass class XSLTError(Error):

6 21

[lxml-dev] Namespace implementation, SAX I/O and XPath class/variables
by Stefan Behnel 07 Nov '05

07 Nov '05

Hi! I'd finally like to get my "bigfat.patch" a bit smaller. The main additions that are still pending are these four: * SAX I/O * XPath variables * XPath class for compiled XPath expressions * Custom classes for namespace implementation http://codespeak.net/pipermail/lxml-dev/2005-October/000510.html I think all of them make sense for lxml and since I depend on them for MathDOM, I'd prefer seeing them in rather sooner than later (makes my users happy :). Note that this is only about additional functionality, there should be no side effects regarding existing code. Any comments on these? Stefan

2 1

[lxml-dev] [PATCH] element parent access through Element.getparent()
by Stefan Behnel 06 Nov '05

06 Nov '05

Hi! Here's a little patch that adds a getparent() method to elements. It is missing from the ElementTree API, but libxml (obviously) provides it, so its trivial to expose it to the public API. Hoping for integration, Stefan

4 10

[lxml-dev] PATCH for formatting XML output
by Patrick Wagstrom 04 Nov '05

04 Nov '05

Hi, I'm a bit new to the project, but had a need to nicely format the output form lxml. Also, I have a need to leave the <?xml version="1.0"?> header at the top. So, I made a few changes to the write procedure. There are now two more arguments that can be called: format=0/1 (0 = default) whether or not the output should be pretty printed strip=0/1 (1 = default) whether or not the xml document definition should be stripped when using us-ascii or utf-8 encoding. I've attached the patch to this email. --Patrick

3 8

[lxml-dev] David Mertz' rnc2rng is non-working
by Stefan Behnel 04 Nov '05

04 Nov '05

One for the archive: I tried David Mertz' rnc2rng tool and it fails to parse most RNC schemas I tried. So it's absolutely unusable for lxml (or any other purpose). The little patch at the end of the mail (revision 19519:19521 in branch scoder1) contains the changes I made to implement the integration, just in case someone else finds a better converter. Stefan Index: src/lxml/tests/test_etree.py =================================================================== --- src/lxml/tests/test_etree.py (Revision 19519) +++ src/lxml/tests/test_etree.py (Revision 19521) @@ -2243,6 +2243,18 @@ self.assert_(schema.validate(tree_valid)) self.assert_(not schema.validate(tree_invalid)) + def test_relaxng_compact(self): + tree = self.parse('<a><b>B</b><c>C</c></a>') + schema = etree.RelaxNGC(''' +default namespace = "test" +element a { + element b { text }, + element c { text } +} +''') + self.assert_(schema.validate(tree)) + + def test_relaxng_invalid_schema(self): schema = self.parse('''\ <element name="a" xmlns="http://relaxng.org/ns/structure/1.0"> Index: src/lxml/etree.pyx =================================================================== --- src/lxml/etree.pyx (Revision 19519) +++ src/lxml/etree.pyx (Revision 19521) @@ -13,6 +13,7 @@ from xmlparser cimport xmlParserCtxt, xmlDict import _elementpath +from rnc import rnctree from StringIO import StringIO import sys @@ -1744,6 +1745,23 @@ raise RelaxNGValidateError, "Internal error in Relax NG validation" return ret == 0 +def RelaxNGC(schema=None, file=None): + if file is not None: + try: + schema = file.getvalue() + except AttributeError: + if isinstance(file, (str, unicode)): + file = open(file, 'r') + schema = file.read() + file.close() + else: + schema = file.read() + tokens = rnctree.token_list(schema) + root = rnctree.make_nodetree(tokens) + + etree = parse( StringIO(root.toxml()) ) + return RelaxNG(etree) + cdef class XMLSchema: """Turn a document into an XML Schema validator. """

2 1

[lxml-dev] lxml 0.8 released!
by Martijn Faassen 03 Nov '05

03 Nov '05

Hi there, I've just released lxml 0.8, to at least get rid of the backlog of long-standing changes that should've been released months ago. Now I hopefully get some breathing space to review the various exciting patches that are on the list and see how we integrate them for 0.9. Also for 0.9 I'd like to consider at least taking a step in the direction of creating an lxml egg. This way we can have lxml included in the cheeseshop.python.org easily and it can be used as a dependency in other projects (if at least libxml2/libxslt is installed in a proper version on the target machine). Windows versions of 0.8 are welcome. I think my plans/requirements for the Windows version (including libxml2, etc) were too complicated, so I'll just upload whatever version gets submitted. :) (but feel free to submit a better one!) Regards, Martijn

4 9

[lxml-dev] Work on branch "lxml-scoder1"
by Stefan Behnel 03 Nov '05

03 Nov '05

Stefan Behnel wrote: > I commited my original (final) patches one after the other, so you should now > have a trace of the changes. As I said, most of them do not depend on each > other, so each revision adds only the new features. > > The commited patches are: > (r18893) MANIFEST.in to enable setup.py targets like bdist_rpm > (r18894) _Element.getparent() > (r18895) SAX input and output of ElementTrees > > The next patch was made up by two, so I commited them separately: > (r18896) variable support in XPath expressions > (r18898) XPath class to support compiled expressions I forgot to say that these two depend on each other. > Then: > (r18899) support for namespace classes (r18903) incorporates a change from patch in 18899: I removed the class registry from ElementTree to keep it only at module level. This is actually more of a preparation for (r18907), where I saw that it doesn't really make sense to keep that functionality in _ElementTree. The next one is independent of the other patches: (r18904/5) (fix for a) fix for the bug reported by Carlos Pita And finally, I applied my big final patch that does the restructuring for ElementTree compliance. I first applied a partial patch with the test cases that compare ElementTree and etree to motivate the change. That's in (r18906). (r18907) contains the changes. It is so big because the structural modification required a significant bit of refactoring to adapt the rest of the implementation to the semantic changes. This revision passes the original test cases as well as the ones added in (r18906). I cc-ed the mailing list as I would really appreciate it if other people could test this branch, especially the final modifications. I'm specifically concerned about memory handling and this kind of stuff. There are not really any test cases for this, but I guess they are rather tricky to write. So please, test! :) For the volunteers: svn co http://codespeak.net/svn/lxml/branch/scoder1 lxml-scoder1 gives you a checkout of my branch into the directory lxml-scoder1. Stefan

3 4