Hi,
You're not gonna let go, are you? :)
Just found myself trying to imitate things I already know they will be there in the future...
But I think you're right. I'll patch those two in. I'll need you to check that these things work, though. The test coverage in that area is not very great, since I had to leave out a couple of those big test cases as they wouldn't work without having lxml also generate the prefixes.
As you're the one bagging for inclusion, what about writing some more test cases that work with 1.3? (and preferably also with 2.0 ...)
Gonna do that. My first try on running the tests produce a reproduceable core, however: $ make test PYTHON=python2.4 python2.4 setup.py build_ext -i Building lxml version 1.3-44288 running build_ext python2.4 test.py -p -v TESTED VERSION: Python: (2, 4, 4, 'final', 0) lxml.etree: (1, 3, 0, 44288) libxml used: (2, 6, 27) libxml compiled: (2, 6, 27) libxslt used: (1, 1, 20) libxslt compiled: (1, 1, 20) 552/552 (100.0%): Doctest: xpathxslt.txt ---------------------------------------------------------------------- Ran 552 tests in 1.264s OK make: *** [test_inplace] Illegal Instruction (core dumped) $ gdb python2.4 -c core GNU gdb 4.18 Copyright 1998 Free Software Foundation, Inc. GDB is free software, covered by the GNU General Public License, and you are welcome to change it and/or distribute copies of it under certain conditions. Type "show copying" to see the conditions. There is absolutely no warranty for GDB. Type "show warranty" for details. This GDB was configured as "sparc-sun-solaris2.6"... Core was generated by `python2.4 test.py -p -v'. Program terminated with signal 9, Killed. Reading symbols from /usr/lib/libresolv.so.2...done. Reading symbols from /usr/lib/libsocket.so.1...done. Reading symbols from /usr/lib/libnsl.so.1...done. Reading symbols from /usr/lib/librt.so.1...done. Reading symbols from /usr/lib/libdl.so.1...done. Reading symbols from /usr/lib/libpthread.so.1...done. Reading symbols from /usr/lib/libm.so.1...done. Reading symbols from /usr/lib/libc.so.1...done. Reading symbols from /usr/lib/libmp.so.2...done. Reading symbols from /usr/lib/libaio.so.1...done. Reading symbols from /usr/platform/SUNW,Sun-Fire-V440/lib/libc_psr.so.1...done. Reading symbols from /usr/lib/libthread.so.1...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/time.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/itertools.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/_curses.so...done. Reading symbols from /apps/prod/lib/libncurses.so.5...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/strop.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/_bisect.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/_heapq.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/cStringIO.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/math.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/binascii.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/_random.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/fcntl.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/operator.so...done. Reading symbols from /data/pydev/hjoukl/LXML/lxml-1.3/src/lxml/etree.so...done. Reading symbols from /apps/prod/lib/libxslt.so.1...done. Reading symbols from /apps/prod/lib/libexslt.so.0...done. Reading symbols from /apps/prod/lib/libxml2.so.2...done. Reading symbols from /apps/prod/lib/libz.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/struct.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/zlib.so...done. Reading symbols from /data/pydev/hjoukl/LXML/lxml-1.3/src/lxml/objectify.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/_locale.so...done. Reading symbols from /usr/lib/libintl.so.1... warning: Lowest section in /usr/lib/libintl.so.1 is .hash at 0x74 done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/collections.so...done. Reading symbols from /apps/prod/lib/python2.4/lib-dynload/readline.so...done. Reading symbols from /apps/prod/lib/libreadline.so...done. #0 0x50e070 in ?? () (gdb) where #0 0x50e070 in ?? () #1 0x576b0 in tupletraverse (o=0x3943cc, visit=0xb6c28 <visit_decref>, arg=0x0) at Objects/tupleobject.c:443 #2 0xb62fc in collect (generation=2) at Modules/gcmodule.c:294 #3 0xb6a68 in PyGC_Collect () at Modules/gcmodule.c:1196 #4 0xadf28 in Py_Finalize () at Python/pythonrun.c:353 #5 0xafefc in Py_Exit (sts=0) at Python/pythonrun.c:1593 #6 0xaeb70 in handle_system_exit () at Python/pythonrun.c:1050 #7 0xaeb9c in PyErr_PrintEx (set_sys_last_vars=1) at Python/pythonrun.c:1060 #8 0xafea8 in PyErr_Print () at Python/pythonrun.c:974 #9 0xae5f8 in PyRun_SimpleFileExFlags (fp=0xffffffff, filename=0xffbef8b6 "test.py", closeit=1, flags=0xffbef5d8) at Python/pythonrun.c:873 #10 0xaf8cc in PyRun_AnyFileExFlags (fp=0x12a938, filename=0xffbef8b6 "test.py", closeit=1, flags=0xffbef5d8) at Python/pythonrun.c:673 #11 0x1e9ec in Py_Main (argc=4, argv=0xffbef75c) at Modules/main.c:493 #12 0x1dfe4 in main (argc=4, argv=0xffbef75c) at ./Modules/python.c:23 (gdb) As the tests themselves seem to run successfully does this hint at some cleanup/destructor problem? Holger -- Ist Ihr Browser Vista-kompatibel? Jetzt die neuesten Browser-Versionen downloaden: http://www.gmx.net/de/go/browser