
Hi Steve, Steve Howe wrote:
Friday, June 2, 2006, 2:37:20 AM, you wrote:
No problem. Here's a patch that does that. Compiles nicely on my machine. Likely adds nothing but a microsecond to the setup time, but is a little harder to maintain as we have to remember to apply something alike when we update the error code constants. [...]
Thanks, it worked, but now we the same thing on line 972:
etree.c src\lxml\etree.c(972) : error C2026: string too big, trailing characters truncated
Every line above 32000 chars will not be compiled. I could be fixing those myself, but I think it's better to have it right in the trunk...
That's the same place as before. Are you sure the maximum is 32k? Because the patch I sent you should have cut the longest line down to some 13k... Maybe setup.py didn't rebuild etree.c? That's not done automatically because we only have it depend on etree.pyx (in which there were no changes). I sent you a generated etree.c where the longest line is below 8k. But I'll look into the issue to fix it on the trunk... Stefan