Marat Dakota, 12.01.2010 14:05:
Thanks a lot, it's looks reasonable at first glance and I'll take a closer look as soon as I get to it. If it works well, it should make it into 2.3.
Is there a roadmap date for 2.3 release?
Not yet, no.
Could you add a couple of tests to src/lxml/tests/test_xslt.py? That would help in making sure that it keeps working as expected even if I find that I need to rework the patch.
I've added tests, I've also renamed variables to fit your code better and added possibility to evaluate extension element's content directly to _AppendOnlyElementProxy as well as to _Element. It looks like I'm satisfied with the code now. I wonder what will you say about it.
Hmm, and did you *run* the tests? The test code actually contains obvious errors (such as non well-formed XML), so I wonder how you tested it at all. After fixing the tests, they even crash on my machine. So, sorry, but this patch isn't in an acceptable state. Could you please open up a ticket on launchpad for this? That would make it easier to track the progress of this patch. Stefan