Hi Holger and Stefan, thanks for the explanations and the change. I am looking forward to see what PyCharm will make of that :) cheers Oliver On Thu, 17 Mar 2016 at 17:43 Stefan Behnel <stefan_ml@behnel.de> wrote:
Holger Joukl schrieb am 17.03.2016 um 17:23:
XMLParser(self, encoding=None, attribute_defaults=False, dtd_validation=False, load_dtd=False, no_network=True, ns_clean=False, recover=False, XMLSchema schema=None, remove_blank_text=False, resolve_entities=True, remove_comments=False, remove_pis=False, strip_cdata=True, collect_ids=True, target=None, compact=True)
schema is the only parameter that is containing what I guess is a Cython type hint, which IMO does not belong in the API documentation.
I respectfully disagree. I think the API docs should provide whatever information it can give. The notation resembles C function signatures here so I think it's reasonably intuitive.
Maybe API docs with Python 3 type annotation syntax instead may be nicer for a Python API, regardless if it's implemented in Cython.
If it helps ...
https://github.com/lxml/lxml/commit/477e721dc083ed512182d9a2339bb64ee9f37937
Stefan
_________________________________________________________________ Mailing list for the lxml Python XML toolkit - http://lxml.de/ lxml@lxml.de https://mailman-mail5.webfaction.com/listinfo/lxml