Op 03-05-2024 om 20:59 schreef Gertjan Klein:

Op 03-05-2024 om 06:22 schreef Stefan Behnel:
> Do you want to propose a PR?

Yes, I will. It will take me a little while to figure out how to run the 
tests, seeing as the lxml tree doesn't compile, but if need be I'll just 
test the test method elsewhere before copying over. CI will then pick up 
any mistakes I may have made.

I ran the test out-of-tree, using the lxml build artifact, seeing as I haven't managed to get building working. I now created a pull request, even though CI failed, as the failures seem unrelated.

As to the CI failures: 4 "checks" were not successful. These are for macos-latest and Python 3.6 and 3.7, and are caused by these Python versions not being available. However, if I click on the summary, I see more errors under "Annotations". For example, in "ubuntu-latest, pypy-3.10, false, true", I see test failures:

https://github.com/gertjanklein/lxml/actions/runs/8949293511/job/24583430392#step:7:3594
FAILED (failures=29, errors=9)

Oddly, this CI run does get a green check mark. Anyway, I see you got the same errors on the last lxml CI run, so they were not introduced by my change. 🙂 The AppVeyor build failed on Python version that are too old (2.7, 3.5).

Kind regards,
Gertjan.