Bob Kline schrieb am 21.04.2017 um 21:44:
On Fri, Apr 21, 2017 at 1:46 PM, Bob Kline wrote:
I haven't done much contribution to open-source projects since before git/github took over the world. I can imagine that looking at the diff from the link I gave above would be a little annoying, since it gives the deltas with my previous attempt, which went in a somewhat different direction than the one Stefan in which which Stefan pointed me. What's the best approach here? Should I create a fresh clone and apply my proposed enhancement to that so you'll have a clean diff to look at? Any pointers to guides to github patch etiquette?
Ah, I just stumbled across git's interactive rebase, which is what I think I needed here. I was able to squash my two commits into one, which results in a more useful diff for the patch.
https://github.com/bkline/lxml/commit/e37ed9c6f7c1b6b8f481b6c34dc7919550e8a3...
The only odd thing with it is that GitHub shows the commit as having been made four days ago (even though it's the result of an action performed today), but I bet there's a way I could have adjusted that (and I bet I'll find it eventually).
At any rate, if I get confirmation that this is heading in a useful direction, I'll put in a pull request.
I left some comments, looks good otherwise. Could you also add a test for the new feature? I can't say in which cases libxml2 provides a node in the error info, but I think implementing the check as part of the schema tests in test_xmlschema.py would be a good start. Stefan