On 25-Nov-04, at 12:35 PM, Martijn Faassen wrote:
Hi there,
Just took a glance at the reshuffling branch. I'm glad you're doing this work. Some comments about it though:
it's now lxml.etree.etree and lxml.etree.dom
I actually haven't had a chance to touch the etree and dom packages yet as I couldn't get them to compile until today. On OSX we have the Fink project which is for all intents and purposes - Debian on OSX. I've got libxml2 2.6.11 and the etree and dom packages build properly from trunk now. Building against Fink On a side note - I find it incredibly amusing that Windows is a second class citizen next to Linux and OSX for this project. :) I'll move the etree and dom packages back up to lxml.etree and lxml.dom. I was primarily concerned with getting the unit tests to run and have a clean compile working.
Where did the testrunner test.py go? I see you moved all tests into a separate top-level test directory, but I've been following the pattern in use in Zope (2 and 3), Schooltool, Pypy and Twisted, to name just a few Python projects, where there's a 'tests' or 'test' directory in or next to the package/module being tested. Since these different subpackages can be developed more or less in isolation, this seems to be like a good thing to do, instead of putting them all in the same place. They're unit tests, and belong with the unit they're testing.
Shoot! You know I never noticed that? I couldn't figure out what was going on with the location of test files before. It does seem a little weird to me though since we still end up compiling lxml first and then we can run the tests. I'll reshuffle the files again.
I see you what looks like an empty __init__.py in the etree package. While that works fine on unixy systems, Windows tools like winzip sometimes have issues, not extracting empty files. I don't use Windows but want my software to be portable to it if possible, so I've therefore made it a habit to place a marker comment "# this is a package" in any __init__.py that I create.
I'll keep that in mind - I also don't have a Windows machine to test on so stuff like that would've slipped by - thanks. Ack.. Too much to do at work right now. I've got a friend who has used lxml a little on Windows now so he's willing to help out with the packaging on that platform once I get the new file structure sorted out. See ya, vic