27 May 2005 27 May '05
Martijn Faassen schrieb:
I notice you didn't run the lxml tests correctly after applying the patch; the tests do a lot of work with StringIO and your check:
if not tree.PyFile_Check(file): raise ValueError("Not a file!")
breaks these tests.
I think the case of StringIO has to be handled separately, as there probably is no underlying unix file descriptor for a StringIO object. One could use the xmlOutputBufferCreateIO function to implement this case. This function exspects custom write and read operations for the created xmlOutputBuffer as a parameter.
I will work this out on the weekend.