[lxml-dev] a patch for setup.py when libxml2 and libxslt are built to separate dir
Hello, I'm just starting to play with lxml and am quite pleased with it so far. Thank you for creating it. I have a small patch for setup.py that, if people think is reasonable, I'd like to see applied to lxml repo. Although probably not typical, one can build libxml2 and libxslt to separate directories. Say something like this: ~/opt/libxml2-2.6.22/... ~/opt/libxslt-1.1.15/... In that situation libxml2's "xml2-config" does not know how to return the proper compilation and link flags for both libxml2 and libxslt. However, libxslt (which depends on libxml2, of course) knows how: $ xml2-config --cflags -I/Users/trentm/opt/libxml2-2.6.22/include/libxml2 $ xslt-config --cflags -I/Users/trentm/opt/libxslt-1.1.15/include -I/Users/trentm/opt/libxml2-2.6.22/include/libxml2 My patch (see attached) changes guess_dirs() to use xslt-config. What do you think? Trent -- Trent Mick trentm@gmail.com
Trent Mick wrote:
My patch (see attached) changes guess_dirs() to use xslt-config. What do you think?
Sounds like a good idea. I'll check this in at first opportunity! Regards, Martijn
Hi Trent, Trent Mick wrote:
My patch (see attached) changes guess_dirs() to use xslt-config. What do you think?
Sorry for the delay -- I've finally checked in this patch. Regards, Martijn
participants (2)
-
Martijn Faassen
-
Trent Mick