Possible bug in lxml.objectify
Hi, By doing the cffi port, I noticed this suspect line in lxml.objectify.pyx (line 1689): elif c_ns.prefix is not NULL or c_ns.prefix[0] != c'\0': It seems to me that the connector should be "and" instead, otherwise a prefix of "" would yield a typename starting with a colon character... I haven't tried though. But it looks like a bad negation of a similar statement above. -- Amaury Forgeot d'Arc
Amaury Forgeot d'Arc, 17.06.2013 18:20:
By doing the cffi port, I noticed this suspect line in lxml.objectify.pyx (line 1689):
elif c_ns.prefix is not NULL or c_ns.prefix[0] != c'\0':
It seems to me that the connector should be "and" instead, otherwise a prefix of "" would yield a typename starting with a colon character... I haven't tried though. But it looks like a bad negation of a similar statement above.
Yes, that's a bug. Thanks! https://github.com/lxml/lxml/commit/1c6084a1754e83c45286fe2b112d2ef327cadc67 Stefan
participants (2)
-
Amaury Forgeot d'Arc -
Stefan Behnel