[lxml-dev] setup.py issues
Hi there, There are a couple regressions, and a feature request about the latest setup.py stuff: - Parsing the revision from svn 1.4 seems to have regressed. The attached patch replaces the code with a slightly modified version of the code in setuptools/commands/egg_info.py - Passing 'libraries' to 'Extension' needs to be made aware of '--static'. To be more precise, if --static is set, 'libraries' should have '<lib>_a' instead of '<lib>' (eg: 'xslt_a' instead of 'xslt'). - I would like to be able to pass 'static_include_dirs' and 'static_library_dirs' and 'static_cflags' as environment variables, which distutils already understands instead of changing setup.py. That would be 'INCLUDE' and 'LINK' environment variables on win32. -- Sidnei da Silva Enfold Systems http://enfoldsystems.com Fax +1 832 201 8856 Office +1 713 942 2377 Ext 214
I said the attached patch. -- Sidnei da Silva Enfold Systems http://enfoldsystems.com Fax +1 832 201 8856 Office +1 713 942 2377 Ext 214
Hi Sidnei, Sidnei da Silva wrote:
There are a couple regressions, and a feature request about the latest setup.py stuff:
- Parsing the revision from svn 1.4 seems to have regressed. The attached patch replaces the code with a slightly modified version of the code in setuptools/commands/egg_info.py
Thanks for the patch. Can't currently test if it works with SVN 1.4, but if you say it does, I'll just apply it.
- Passing 'libraries' to 'Extension' needs to be made aware of '--static'. To be more precise, if --static is set, 'libraries' should have '<lib>_a' instead of '<lib>' (eg: 'xslt_a' instead of 'xslt').
That's not always the case. Naming conventions differ between systems.
- I would like to be able to pass 'static_include_dirs' and 'static_library_dirs' and 'static_cflags' as environment variables, which distutils already understands instead of changing setup.py. That would be 'INCLUDE' and 'LINK' environment variables on win32.
... or CFLAGS and LDFLAGS in Unix environments. Want to come up with a patch here, too? Stefan
On 11/27/06, Stefan Behnel
... or CFLAGS and LDFLAGS in Unix environments. Want to come up with a patch here, too?
Here's a patch that works for me on Win32. Need to update it to work with *nix. -- Sidnei da Silva Enfold Systems http://enfoldsystems.com Fax +1 832 201 8856 Office +1 713 942 2377 Ext 214
Sidnei da Silva wrote:
Here's a patch that works for me on Win32. Need to update it to work with *nix.
Thanks. I applied it to the trunk for now - not sure how the "LIBRARY" variable would look like for gcc, though. Maybe it's just good the way it is. I also added the --without-threads option while I was at it, so lxml can now be compiled with and without internal threading support. Stefan
Hey, Sidnei da Silva wrote:
There are a couple regressions, and a feature request about the latest setup.py stuff:
My apologies for the regressions and thanks for the help!
- Parsing the revision from svn 1.4 seems to have regressed. The attached patch replaces the code with a slightly modified version of the code in setuptools/commands/egg_info.py
Thanks! I saw Stephan applied this.
- Passing 'libraries' to 'Extension' needs to be made aware of '--static'. To be more precise, if --static is set, 'libraries' should have '<lib>_a' instead of '<lib>' (eg: 'xslt_a' instead of 'xslt').
Oh, that sucks. I was hoping that distutils took care of such messes. :(
- I would like to be able to pass 'static_include_dirs' and 'static_library_dirs' and 'static_cflags' as environment variables, which distutils already understands instead of changing setup.py. That would be 'INCLUDE' and 'LINK' environment variables on win32.
Sounds like a good plan. I see you submitted a patch for this too. I hope my efforts at least made setup.py more hackable. :) Regards, Martijn
participants (3)
-
Martijn Faassen -
Sidnei da Silva -
Stefan Behnel