Re: [lxml-dev] [BUG] lxml-2* hangs on interpreter shutdown with gtk-mainloop
Hi, René 'Necoro' Neumann wrote:
I attached a patch that also works for me and (again) seems to work around the symptom you see.
This patch only works for me when passing a filename or file to parse(). When passing a StringIO instance it still hangs.
True, didn't realise that in my tests. Here is another patch that seems to work better for me (still no idea why).
What about the way simpler patch: Add the following lines somewhere, where they fit:
if base_url is None: base_url = ""
Because passing an empty base_url works too. Or does this have side-effects?
Yes. The URL is used to identify the document in a couple of places, and the base_url parameter is just a way to override the URL in cases where lxml can't determine it itself. Stefan
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey, Stefan Behnel schrieb: | Hi, | | René 'Necoro' Neumann wrote: |>> I attached a patch that also works for me and (again) seems to work |>> around the symptom you see. |> This patch only works for me when passing a filename or file to parse(). |> When passing a StringIO instance it still hangs. | | True, didn't realise that in my tests. | | Here is another patch that seems to work better for me (still no idea why). I did not test the patch - but I guess it does not change anything, does it? It just replaces "try ... except" with "if ... is not None" constructs :) Or is the "return None" important. Because StringIO instances have none of the tested attributes. Regards, Necoro -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH4Bep4UOg/zhYFuARArqiAJ4goMG7dHMRUWxwzHDrqASSvv54pgCdGTa7 FF6VwDzFpdPpLjpJ3g9aBDQ= =UO7H -----END PGP SIGNATURE-----
Hi, René 'Necoro' Neumann wrote:
Stefan Behnel wrote: | René 'Necoro' Neumann wrote: |>> I attached a patch that also works for me and (again) seems to work |>> around the symptom you see. |> This patch only works for me when passing a filename or file to parse(). |> When passing a StringIO instance it still hangs. | | True, didn't realise that in my tests. | | Here is another patch that seems to work better for me (still no idea why).
I did not test the patch - but I guess it does not change anything, does it? It just replaces "try ... except" with "if ... is not None" constructs :)
It works better, as I said. At least for me. The function I changed is the main difference between what works and what doesn't.
Or is the "return None" important. Because StringIO instances have none of the tested attributes.
The "return None" was there before. Stefan
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hey, I'm seeing announcements for new versions on this list :) - Any status update? - Is this bug fixed in one of the announced releases? - - Necoro -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH69v84UOg/zhYFuARAh3fAJwJsWw7JKjybPZMRKefPKPopn9gKwCgg6rX JgvArRG+kJUuHwJRMqDXVmI= =YB+H -----END PGP SIGNATURE-----
Hi, René 'Necoro' Neumann wrote:
I'm seeing announcements for new versions on this list :) - Any status update? - Is this bug fixed in one of the announced releases?
Your test script works for me, so please give it a try and report back. :) Stefan
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Stefan Behnel schrieb: | Hi, | | René 'Necoro' Neumann wrote: |> I'm seeing announcements for new versions on this list :) - Any status |> update? - Is this bug fixed in one of the announced releases? | | Your test script works for me, so please give it a try and report back. :) | | Stefan | | I know there was something to do ^^. Ok - I tested it, and it works for me with files and StringIO ... even if I don't understand why... (perhaps it is something in cython) Thanks :) René -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH6/nM4UOg/zhYFuARAu1GAJ9jhls3YWcH7i2t17hvba0XL7OHpgCdFeOM rYjGTr8V+6K4JQ+qdGnL1aE= =OcCa -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 René 'Necoro' Neumann schrieb:
Stefan Behnel schrieb: | Hi, | | René 'Necoro' Neumann wrote: |> I'm seeing announcements for new versions on this list :) - Any status |> update? - Is this bug fixed in one of the announced releases? | | Your test script works for me, so please give it a try and report back. :) | | Stefan | |
I know there was something to do ^^. Ok - I tested it, and it works for me with files and StringIO ... even if I don't understand why... (perhaps it is something in cython)
Thanks :)
René
Hmm ... an enigmail flaw. Sorry... So in case you were wondering ... the email really was sent by me, even if enigmail is telling something different ^^ (or is it just _my_ enigmail)? René -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH6/7e4UOg/zhYFuARAlF/AJ4o6XY/Nnf6j16KEHuYIWnA2EDrlACfc/ee 0EcB82O48+s1t6STw5AifRc= =bGtM -----END PGP SIGNATURE-----
Stefan Behnel schrieb:
Hi,
René 'Necoro' Neumann wrote:
I'm seeing announcements for new versions on this list :) - Any status update? - Is this bug fixed in one of the announced releases?
Your test script works for me, so please give it a try and report back. :)
Stefan
Ok ... just again (unsigned): Yes it works here too. But don't know why ;) (perhaps a cython issue?) <OT> Regarding the two other mails: Sorry for the spam. But your mailinglist software seems to have an error... I sent the last copy to myself too (BCC) - and there it was received ok and with correct signing. But the mailinglist seems to have altered the text... I only received it in Base64 coding (or something alike):
From the header: Content-Transfer-Encoding: base64 as opposed to the normal: Content-Transfer-Encoding: 8bit </OT>
participants (2)
-
René 'Necoro' Neumann -
Stefan Behnel