Mailman 3 December 2003 - Mailman-coders

[ mailman-Patches-760567 ] moderation request message content
by SourceForge.net 24 Dec '03

24 Dec '03

Patches item #760567, was opened at 2003-06-25 11:25 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=760567&group_i… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Richard Barrett (ppsys) Assigned to: Nobody/Anonymous (nobody) Summary: moderation request message content Initial Comment: This patch makes per-list configurable the inclusion of the body of messages that require moderation in the request messages sent to list moderators. This patch has similar objectives to those of patch #593674 but is a simpler implementation. This adds one list attribute, which can be set or unset via the web admin GUI, and which controls whether the moderated message body is included in the moderator request. Apply the attached patch file with the MM build directory as the current working directory using the command: patch -p1 < path-to-patch-file ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-24 12:29 Message: Logged In: YES user_id=12800 I'm going to defer this one until 2.1.5 since I don't want to add any new list attributes at this late date. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-09-30 16:43 Message: Logged In: YES user_id=75166 modinc-2.1.3-0.1.patch is a MM 2.1.3 compatible version of the patch ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-06-25 13:21 Message: Logged In: YES user_id=75166 Missed one changed file from initial patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=760567&group_i…

1 0

[ mailman-Patches-828811 ] Reduced listinfo and admin CGI process size
by SourceForge.net 24 Dec '03

24 Dec '03

Patches item #828811, was opened at 2003-10-23 06:30 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=828811&group_i… Category: Web UI Group: Mailman 2.1 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Barrett (ppsys) Assigned to: Nobody/Anonymous (nobody) Summary: Reduced listinfo and admin CGI process size Initial Comment: When the CGI scripts listinfo.py and admin.py are generating an overview page listing all the advertised mailing lists, they accumulate in memory a MailingList object for every mailing list to appear on the page. For sites with a large number of lists this can lead to the CGI process becoming quite large. This patch changes the behaviour so that what is accumulated in memory by the scripts is only the information about each list that is necessary to generate the overview page. This should reduce the maximum size reached by the CGI process during their execution. This patch can be applied by running the following command with either $build or $prefix as the current directory, that is, you can apply the patch in the build directory before running ./configure and make install or to the installed system: patch -p1 < path-to-patch-file ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-24 12:27 Message: Logged In: YES user_id=12800 Accepted for MM2.1.4 ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-10-23 11:39 Message: Logged In: YES user_id=12800 I haven't looked at the patch, but +1 on the idea. Thanks! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=828811&group_i…

1 0

[ mailman-Bugs-835332 ] Stops bloat in pipermail article databases
by SourceForge.net 24 Dec '03

24 Dec '03

Bugs item #835332, was opened at 2003-11-03 17:04 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=835332&group_i… Category: Pipermail Group: 2.1 (stable) >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Richard Barrett (ppsys) Assigned to: Nobody/Anonymous (nobody) Summary: Stops bloat in pipermail article databases Initial Comment: The standard pipermail archiving code saves the body text, in HTML format, of every article in the -article database of each archived list. This bloats the size of these databases. Because they are pickled data structures, which are loaded into memory in their entirety when archiving operations for a list are being handled, this bloat can substantially prejudice archiver performance and in the limit, for lists carrying heavy traffic and/or receiving large text postings, bring archiving to a grinding halt. This patch changes HyperArch.py and pipermail.py so that the data stored in the pipermail <code>$archives/private/ <listname>/database/<period>-article</code> does not include the body text, in HTML format, of each article. This reduces the size of the -article database for each list. The benefits of this are most pronounced with high traffic lists and those to which large text postings are made. The patch also adds a script $prefix/bin/rb-arch which will remove any body text, in HTML format, from existing - article databases; this junk HTML is no longer added when new articles are added to the databases but existing junk HTML is not deleted unless this script is run. The alternative is to run $prefix/bin/arch for a list. Apply the patch from within the Mailman build directory using the command: patch -p1 < path-to-patch-file You use this patch at your own risk and I would appreciate feedback about whether it works for you if you use it or/and any problems you encounter with the patch. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-24 11:59 Message: Logged In: YES user_id=12800 Accepted for MM2.1.4. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=835332&group_i…

1 0

[ mailman-Patches-657951 ] Generate RSS summary in archives
by SourceForge.net 23 Dec '03

23 Dec '03

Patches item #657951, was opened at 2002-12-23 19:17 Message generated for change (Comment added) made by codewhacker You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i… Category: Pipermail Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 9 Submitted By: A.M. Kuchling (akuchling) Assigned to: Nobody/Anonymous (nobody) Summary: Generate RSS summary in archives Initial Comment: Here's a first-draft patch. Things that need fixing: * The generated RSS feed needs to be validated. (It passed the W3C's RDF validator, but RSS validators still need to be checked.) * The date should be given in YYYY-MM-DD format, which requires parsing the .fromdate attribute. * How do I get the URL for an archived message? The generated RSS currently just uses the filename, which is wrong. How do I get at the PUBLIC_ARCHIVE_URL setting? * Getting the most recent N postings is inefficient; the code loops through all of the archived messages and takes the last N of them. We could add .last() and .prev() methods to the Database class, but that's more ambitious for 2.1beta than I like. (Would be nice to get this into 2.1final...) * The list index page should have a LINK element pointing to the RSS file. Please make any comments you have, and I'll rework the patch accordingly. ---------------------------------------------------------------------- Comment By: Roy M. Silvernail (codewhacker) Date: 2003-12-23 19:35 Message: Logged In: YES user_id=670974 I'm trying to enrich the RSS output by adding a proper [description] and a [content:encoded] module, but I am having the devil's own time locating the raw message text. Be happy to contribute a patch if you can point me to the raw content (without the italics markup for quoting). Thanks! ---------------------------------------------------------------------- Comment By: Michael Weber (wookiew) Date: 2003-09-10 16:29 Message: Logged In: YES user_id=863445 So far the patch is included (by the way: i hope that Defaults.py.in in the patch *means* Defaults.py ) and mailman get a restart. Hopefully i add the two lines in listinfo.html ( /de/ because we have german speaking lists) and take a look for the xml file). After search the whole device (only to be sure) i can say: There is no file like this. Is another patch need before? Another setup to make? I cant find any hint here... so i have to ask. But the idea is great... if it work on my lists its genious... regards, Michael running version 2.1.1 ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-09-02 04:15 Message: Logged In: YES user_id=12800 Bumping priority. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-07-15 18:55 Message: Logged In: YES user_id=11375 OK, done! This patch is now ready to go in: some people have looked at the RSS and haven't spotted any problems. Barry, can I please get CVS write access to check this in? ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-07-11 01:00 Message: Logged In: YES user_id=11375 Attaching correct version of the patch. ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2003-07-11 00:52 Message: Logged In: YES user_id=11375 Here at last is an updated version of the patch that's crawling closer to being complete. There's now a RSS_NUM_ARTICLES setting in Defaults.py, the generated URLs are correct, and I modified the English template to link to the RSS file. Remaining things: check the generated RSS for correctness; edit all of the other language templates to include the RSS file (I may ask for CVS write access to do that). It would be really nice if the Mailman upgrade script could update existing general list information pages to include the LINK element; any suggestion about how to go about that? ---------------------------------------------------------------------- Comment By: Dan Brickley (danbri) Date: 2003-06-22 15:00 Message: Logged In: YES user_id=7830 OK, I've regenerated the patch with some code which works for me. http://rdfweb.org/2003/06/mailman-rss/rsspatch Health warning: * I suspect it may fail in conditions when get_archives() returns a list not a string (does this ever happen?). * See also problems mentioned below, regenerating partial archives seems tricky. Hope this is useful anyways... Dan <danbri(a)w3.org> ---------------------------------------------------------------------- Comment By: Dan Brickley (danbri) Date: 2003-06-22 11:48 Message: Logged In: YES user_id=7830 I thought I'd have a look at this myself, though have modest knowledge of both Python and MailMan. In the course of trying to patch the patch, I tried running the archiver over just the last couple of messages, to speed things along: "../../bin/arch -s 4390 rdfweb-dev". Traceback (most recent call last): File "../../bin/arch", line 187, in ? main() File "../../bin/arch", line 177, in main archiver.close() File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 310, in close self.write_TOC() File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 1082, in write_TOC rss.write(self.RSS()) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 769, in RSS date, msgid = self.database.dateIndex.first() AttributeError: HyperDatabase instance has no attribute 'dateIndex' Not sure what's going on there, but this seemed as good a place of any to keep note of it. Investigating... ---------------------------------------------------------------------- Comment By: Dan Brickley (danbri) Date: 2003-06-22 11:04 Message: Logged In: YES user_id=7830 Does anyone have a patch to remove the hardwiring of "2002-December" and get the appropriate date from mailman somehow? ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-04-18 22:43 Message: Logged In: YES user_id=12800 Andrew, to get the url for the archived message use mlist.GetBaseArchiveURL(), which knows about private vs. public archives, the host name and the list name. From there you should be able to tack on just the part of the path under "archives/private/listname". See Mailman/Handlers/Scrubber.py for an example. Only other minor comment: NUM_ARTICLES can probably go in Defaults.py.in ---------------------------------------------------------------------- Comment By: Justin Mason (jmason) Date: 2003-03-26 21:49 Message: Logged In: YES user_id=935 big thumbs up from me too. Much better solution than http://taint.org/mmrss/ ;) ---------------------------------------------------------------------- Comment By: Uche Ogbuji (uche) Date: 2003-03-18 01:09 Message: Logged In: YES user_id=38966 I'd like to add my vote to this item. This is a fantastic idea, Andrew. Thanks. --Uche ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2002-12-23 20:42 Message: Logged In: YES user_id=11375 Updated patch: * Dates are now rendered as ISO-8601 (date only, not the time of the message) * By hard-wiring 2002-December, I got the RSS to validate using Mark Pilgrim's validator. ---------------------------------------------------------------------- Comment By: captain larry (captainlarry) Date: 2002-12-23 19:36 Message: Logged In: YES user_id=147905 Just voting for support here. This is *great* thanks for the patch and I hope the maintainers include it as soon as it's appropriate :) Adam. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 19:27 Message: Logged In: YES user_id=12800 Deferring until post-2.1 ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2002-12-23 19:21 Message: Logged In: YES user_id=11375 Argh; SF choked on the file upload. Attaching the patch again... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i…

1 0

[ mailman-Bugs-864700 ] Extra period in attachment name problem
by SourceForge.net 22 Dec '03

22 Dec '03

Bugs item #864700, was opened at 2003-12-22 14:33 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864700&group_i… Category: None Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Kevin W. Gagel (kwgagel) Assigned to: Nobody/Anonymous (nobody) Summary: Extra period in attachment name problem Initial Comment: Having more than one period "." in the name of an attachment causes mailman to disregard portions of the file name, including the extention of the file. For example a file named: PRESIDENT'S NEWSLETTER NO. 2 - 2003-2004 ACADEMIC December.pdf Results in a file attachment of: PRESIDENT'S_NEWSLETTER_NO._2_-_2003- 2004_ACADEMIC (the above is wraped by the textbox input). Sending the same file attachment directly to a user does not cause this problem. Sending it through mailman does result in the change to the file name and extenton. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864700&group_i…

1 0

[ mailman-Bugs-864676 ] Not able to substitute user login with admin login
by SourceForge.net 22 Dec '03

22 Dec '03

Bugs item #864676, was opened at 2003-12-22 22:47 Message generated for change (Comment added) made by berndts You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864676&group_i… Category: Web/CGI Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Stephan Berndts (berndts) Assigned to: Nobody/Anonymous (nobody) Summary: Not able to substitute user login with admin login Initial Comment: As a site or list admin I sometimes want to view the private archives of a mailing list. This was possible without problems in older Mailman installations. Mailman 2.1 rejects my login attempts. I even found the reason for the problem: For example in Mailman/Cgi/private.py (nearly the same code exists in roster.py) the authentication is done by calling the following code in line 116: <code> if not mlist.WebAuthenticate((mm_cfg.AuthUser, mm_cfg.AuthListModerator, mm_cfg.AuthListAdmin, mm_cfg.AuthSiteAdmin), password, username): </code> If I try to login with the site password I do not enter a username. Keep this in mind :) In <code>WebAuthenticate</code> (found in SecurityManager. py, l. 203) the authcontexts are passed to <code>Authenticate</code> (also in SecurityManager.py, l. 124) if no cookie exists yet. There the function <code>authenticateMember</code> (OldStyleMemberships.py, l. 105) is called (l. 195) for the first entry in authcontexts (AuthUser) and calls <code>getMemberPassword</code> (OldStyleMemberships.py, l. 99) which raises an <code>Errors.NotAMemberError</code> exception; that's ok as I did not provide a username. But: The exception is first handled in <code>WebAuthenticate</code>, bypassing <code>Authenticate</code> were all possible authcontexts should be given a try before returning a failure. I submitted a patch (#864674) which puts a try-except-block around the call of <code>authenticateMember</code> in SecurityManager.py (l. 195) which prevents exiting the for-loop before all possible authcontexts are checked. ---------------------------------------------------------------------- >Comment By: Stephan Berndts (berndts) Date: 2003-12-22 22:59 Message: Logged In: YES user_id=129854 Sorry for the <code>-stuff. It makes the bug report hard to read -- I intented the opposite :( I hoped it would work ... and found no documentation about reporting bugs. Stephan ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864676&group_i…

1 0

[ mailman-Bugs-864676 ] Not able to substitute user login with admin login
by SourceForge.net 22 Dec '03

22 Dec '03

Bugs item #864676, was opened at 2003-12-22 22:47 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864676&group_i… Category: Web/CGI Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Stephan Berndts (berndts) Assigned to: Nobody/Anonymous (nobody) Summary: Not able to substitute user login with admin login Initial Comment: As a site or list admin I sometimes want to view the private archives of a mailing list. This was possible without problems in older Mailman installations. Mailman 2.1 rejects my login attempts. I even found the reason for the problem: For example in Mailman/Cgi/private.py (nearly the same code exists in roster.py) the authentication is done by calling the following code in line 116: <code> if not mlist.WebAuthenticate((mm_cfg.AuthUser, mm_cfg.AuthListModerator, mm_cfg.AuthListAdmin, mm_cfg.AuthSiteAdmin), password, username): </code> If I try to login with the site password I do not enter a username. Keep this in mind :) In <code>WebAuthenticate</code> (found in SecurityManager. py, l. 203) the authcontexts are passed to <code>Authenticate</code> (also in SecurityManager.py, l. 124) if no cookie exists yet. There the function <code>authenticateMember</code> (OldStyleMemberships.py, l. 105) is called (l. 195) for the first entry in authcontexts (AuthUser) and calls <code>getMemberPassword</code> (OldStyleMemberships.py, l. 99) which raises an <code>Errors.NotAMemberError</code> exception; that's ok as I did not provide a username. But: The exception is first handled in <code>WebAuthenticate</code>, bypassing <code>Authenticate</code> were all possible authcontexts should be given a try before returning a failure. I submitted a patch (#864674) which puts a try-except-block around the call of <code>authenticateMember</code> in SecurityManager.py (l. 195) which prevents exiting the for-loop before all possible authcontexts are checked. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=864676&group_i…

1 0

[ mailman-Patches-864674 ] Fix: Not able to substitute user login with admin login
by SourceForge.net 22 Dec '03

22 Dec '03

Patches item #864674, was opened at 2003-12-22 22:46 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=864674&group_i… Category: Web UI Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Stephan Berndts (berndts) Assigned to: Nobody/Anonymous (nobody) Summary: Fix: Not able to substitute user login with admin login Initial Comment: As a site admin one sometimes wants to view the private archives of a mailing list. This was possible without problems in older Mailman (2.0.x) installations. Mailman 2.1.3 rejects such login attempts. This patch solves this problem, which I also reported as a bug. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=864674&group_i…

1 0

[ mailman-Bugs-861346 ] "From" needs to be escaped in archives
by SourceForge.net 22 Dec '03

22 Dec '03

Bugs item #861346, was opened at 2003-12-16 18:15 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=861346&group_i… Category: None Group: 2.0.x Status: Closed Resolution: Wont Fix Priority: 5 Submitted By: Tim Altman (roynuj) Assigned to: Nobody/Anonymous (nobody) Summary: "From" needs to be escaped in archives Initial Comment: Problem: List archives are stored in the MBOX format, according to RFC 822 and Unix man pages[1]. Lines in message bodies starting with the word "From" need to be correctly escaped/stuffed in the archives (according to the Unix man pages[1] or RFC2646 §4. 1), so clients importing the messages may correctly recognize message boundaries. This does not occur in Mailman MBOX archives. [1] http://www.gsp.com/cgi-bin/man.cgi? section=5&topic=mbox ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-22 12:58 Message: Logged In: YES user_id=12800 Yes, in 2.1.3. ---------------------------------------------------------------------- Comment By: Tim Altman (roynuj) Date: 2003-12-19 02:08 Message: Logged In: YES user_id=932696 Is this already fixed in 2.1.x, then? ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-12-18 10:04 Message: Logged In: YES user_id=12800 Please upgrade to Mailman 2.1. This won't be fixed in the 2.0.x line. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=861346&group_i…

1 0

[ mailman-Bugs-863989 ] Postfix delayed notification not recognized.
by SourceForge.net 21 Dec '03

21 Dec '03

Bugs item #863989, was opened at 2003-12-21 16:49 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=863989&group_i… Category: bounce detection Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Matthias Andree (m-a) Assigned to: Nobody/Anonymous (nobody) Summary: Postfix delayed notification not recognized. Initial Comment: Hi, I am running Mailman 2.1.3 (stable) with Postfix 2.0.16-20031022. It seems to be running fine with the VERP patch (it is comfortably surprising to see how much Mailman has matured since the unusable 1.1 version - I hated 1.1 but I do like 2.1! You've done wonderful work.) However I have one problem that I cannot resolve myself: Mailman apparently does not parse Postfix' delayed notification which is apparently RFC-1894 conformant (Postfix hasn't been updated to RFC-3464 yet). On superficial inspection, it looks as though Mailman's Bouncers/DSN.py should handle it and return "Stop", as but I'm getting this "uncaught bounce" message which I interpret as "haven't figured anything reasonable from this bounce". The unintelligible bounce is attached and has had mail addresses changed (sed) and the delayed mail header removed for privacy reasons. I can provide the full message to a developer on request, but I cat not put it into a public bug tracker. The MIME structure of Postfix' delay notification is: 1 multipart/report 1.1 text/plain 1.2 message/delivery-status 1.3 text/rfc822-headers The message/delivery-status part has "Action: delayed" in the 2nd header block. See for yourself. Am I misunderstanding Mailman or is Mailman misunderstanding Postfix? Thanks in advance. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=863989&group_i…

1 0