Mailman 3 February 2003 - Mailman-coders

[ mailman-Patches-691055 ] Patch to fix a base64 decode error in Scrubber
by SourceForge.net Feb. 22, 2003

Feb. 22, 2003

Patches item #691055, was opened at 2003-02-22 01:19 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=691055&group_i… Category: None >Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Simon Coggins (scoggins) Assigned to: Nobody/Anonymous (nobody) Summary: Patch to fix a base64 decode error in Scrubber Initial Comment: The base64 decode of attachments isn't always checked to see if an exception was raised. Call were placed around one of the get_payload() calls, so i removed that one and put a try/except in the _bdecode() function. I also removed a redunent if not s: return s in there too. This is a fix for bug http://sourceforge.net/tracker/index.php?func=detail&aid=691039&group_id=10… ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=691055&group_i…

1 0

[ mailman-Patches-670167 ] fix i18n attachment description in archive
by SourceForge.net Feb. 22, 2003

Feb. 22, 2003

Patches item #670167, was opened at 2003-01-18 05:58 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i… Category: Pipermail Group: Mailman 2.1 Status: Open Resolution: Accepted Priority: 6 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: fix i18n attachment description in archive Initial Comment: Bug-ID 669081 (Major attachment handling bug!) is caused inaccurate handling of charset in Scrubber.py. This is caused by misuse of email functions (or by bug in email package). In Scrubber.py, attempt is made to get message charset by part.get_charset() but it returns only None, as far as I experimented. In this patch, message charset is extracted from regular expression pattern in content-type header. This also set the charset of internally crafted message part. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-22 07:05 Message: Logged In: YES user_id=67709 This patch for Scrubber.py now include Bug-ID #691039. save_attachment() now returns (url, size), because in previous code, get_paylaod() is called before calling save_attachment() only to get the size. save_attachment() calls get_payload() inside. We might be able to discard the attachment if get_payload(decode=1) fail. (TBD: return discard message and size 0 ?) ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:31 Message: Logged In: YES user_id=67709 Increment priority because this is now a bug fix. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-04 06:08 Message: Logged In: YES user_id=67709 I made a new patch to fix embedded multipart messages are stripped bug. this patch is for CVS. see http://mail.python.org/pipermail/mailman-users/2003-February/026071.html ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 05:13 Message: Logged In: YES user_id=12800 Reopening so this issue doesn't get lost. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-20 04:03 Message: Logged In: YES user_id=67709 We, Japanese, need additional process of stringify and regenerate message instance.. Internal message is in 'euc-jp' but return value of get_content_charset() becomes 'iso-2022-jp' even though the get_payload() returns euc-jp text. The message and part body is converted to iso-2022-jp when it is output to SMTP (or whatever accepts in string format). ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 02:18 Message: Logged In: YES user_id=12800 Accepted, with changes. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-19 00:52 Message: Logged In: YES user_id=67709 Update of patch. Please backout the first one if you have already applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i…

1 0

[ mailman-Bugs-691039 ] Scrubber broken on bad base64 messages
by SourceForge.net Feb. 22, 2003

Feb. 22, 2003

Bugs item #691039, was opened at 2003-02-22 15:57 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=691039&group_i… Category: Pipermail Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Simon Coggins (scoggins) Assigned to: Nobody/Anonymous (nobody) Summary: Scrubber broken on bad base64 messages Initial Comment: This is a stupid virus email that got thru to one of our lists. I'm happy to remove it from the archive, but I'm guessing if this was sent to a list again, it would cause the same error in the delivery and not just in the archiver. Pickling archive state into /usr/local/mailman/archives/private/sage-au/pipermail.pck Traceback (most recent call last): File "/usr/local/mailman/bin/arch", line 187, in ? main() File "/usr/local/mailman/bin/arch", line 175, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 544, in processUnixMailbox m = mbox.next() File "/usr/local/lib/python2.2/mailbox.py", line 34, in next return self.factory(_Subfile(self.fp, start, stop)) File "/usr/local/mailman/Mailman/Mailbox.py", line 79, in scrubber return mailbox.scrub(msg) File "/usr/local/mailman/Mailman/Mailbox.py", line 99, in scrub return self._scrubber(self._mlist, msg) File "/usr/local/mailman/Mailman/Handlers/Scrubber.py", line 252, in process payload = part.get_payload(decode=1) File "/usr/local/mailman/pythonlib/email/Message.py", line 189, in get_payload return Utils._bdecode(payload) File "/usr/local/mailman/pythonlib/email/Utils.py", line 75, in _bdecode value = base64.decodestring(s) File "/usr/local/lib/python2.2/base64.py", line 44, in decodestring return binascii.a2b_base64(s) binascii.Error: Incorrect padding ---------------------------------------------------------------------- >Comment By: Simon Coggins (scoggins) Date: 2003-02-22 17:21 Message: Logged In: YES user_id=92263 I've added a patch (http://sourceforge.net/tracker/index.php?func=detail&aid=691055&group_id=10…) That fixes this problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=691039&group_i…

1 0

[ mailman-Patches-691055 ] Patch to fix a base64 decode error in Scrubber
by SourceForge.net Feb. 22, 2003

Feb. 22, 2003

Patches item #691055, was opened at 2003-02-22 17:19 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=691055&group_i… Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Simon Coggins (scoggins) Assigned to: Nobody/Anonymous (nobody) Summary: Patch to fix a base64 decode error in Scrubber Initial Comment: The base64 decode of attachments isn't always checked to see if an exception was raised. Call were placed around one of the get_payload() calls, so i removed that one and put a try/except in the _bdecode() function. I also removed a redunent if not s: return s in there too. This is a fix for bug http://sourceforge.net/tracker/index.php?func=detail&aid=691039&group_id=10… ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=691055&group_i…

1 0

[ mailman-Bugs-691039 ] Scrubber broken on bad base64 messages
by SourceForge.net Feb. 22, 2003

Feb. 22, 2003

Bugs item #691039, was opened at 2003-02-22 15:57 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=691039&group_i… Category: Pipermail Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Simon Coggins (scoggins) Assigned to: Nobody/Anonymous (nobody) Summary: Scrubber broken on bad base64 messages Initial Comment: This is a stupid virus email that got thru to one of our lists. I'm happy to remove it from the archive, but I'm guessing if this was sent to a list again, it would cause the same error in the delivery and not just in the archiver. Pickling archive state into /usr/local/mailman/archives/private/sage-au/pipermail.pck Traceback (most recent call last): File "/usr/local/mailman/bin/arch", line 187, in ? main() File "/usr/local/mailman/bin/arch", line 175, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 544, in processUnixMailbox m = mbox.next() File "/usr/local/lib/python2.2/mailbox.py", line 34, in next return self.factory(_Subfile(self.fp, start, stop)) File "/usr/local/mailman/Mailman/Mailbox.py", line 79, in scrubber return mailbox.scrub(msg) File "/usr/local/mailman/Mailman/Mailbox.py", line 99, in scrub return self._scrubber(self._mlist, msg) File "/usr/local/mailman/Mailman/Handlers/Scrubber.py", line 252, in process payload = part.get_payload(decode=1) File "/usr/local/mailman/pythonlib/email/Message.py", line 189, in get_payload return Utils._bdecode(payload) File "/usr/local/mailman/pythonlib/email/Utils.py", line 75, in _bdecode value = base64.decodestring(s) File "/usr/local/lib/python2.2/base64.py", line 44, in decodestring return binascii.a2b_base64(s) binascii.Error: Incorrect padding ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=691039&group_i…

1 0

[ mailman-Patches-690448 ] MailList.py patch to fix a few bugs
by SourceForge.net Feb. 21, 2003

Feb. 21, 2003

Patches item #690448, was opened at 2003-02-21 02:38 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=690448&group_i… Category: internationalization Group: Mailman 2.1 Status: Open Resolution: None Priority: 6 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: MailList.py patch to fix a few bugs Initial Comment: There are bugs in MailList.py handling subscribe/unsbuscribe code. 1. Bug #677668 Subscription confirmation fails when a user chose different language in English list 2. When a user enter a latin/CJK name in full-name in Englush list. 3. Admin unsubscription notify is not sent. This patch fix these. (as far as my test goes) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=690448&group_i…

1 0

[ mailman-Patches-664209 ] best effort to keep text/plain
by SourceForge.net Feb. 20, 2003

Feb. 20, 2003

Patches item #664209, was opened at 2003-01-08 06:14 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i… Category: internationalization Group: Mailman 2.1 Status: Open Resolution: None Priority: 6 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: best effort to keep text/plain Initial Comment: When a message come in different charset than list specific one, Decorate.py adds the header and footer in mime attatchments. This patch tries to keep the good-old plain text format by making these texts into unicode and encode in list preferred charset. If it fails, the messages will get mime-multiparted as was the case without this patch. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 11:42 Message: Logged In: YES user_id=67709 Sorry, there was a error in the previous patch. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:24 Message: Logged In: YES user_id=67709 Refine the code and increment priority. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-08 07:34 Message: Logged In: YES user_id=67709 Expand this patch to base64 encoded plain text. apply the second patch Decorate.py.diff2 to the original Decorate.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i…

1 0

[ mailman-Patches-670167 ] fix i18n attachment description in archive
by SourceForge.net Feb. 20, 2003

Feb. 20, 2003

Patches item #670167, was opened at 2003-01-18 05:58 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i… Category: Pipermail Group: Mailman 2.1 Status: Open Resolution: Accepted >Priority: 6 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: fix i18n attachment description in archive Initial Comment: Bug-ID 669081 (Major attachment handling bug!) is caused inaccurate handling of charset in Scrubber.py. This is caused by misuse of email functions (or by bug in email package). In Scrubber.py, attempt is made to get message charset by part.get_charset() but it returns only None, as far as I experimented. In this patch, message charset is extracted from regular expression pattern in content-type header. This also set the charset of internally crafted message part. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:31 Message: Logged In: YES user_id=67709 Increment priority because this is now a bug fix. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-04 06:08 Message: Logged In: YES user_id=67709 I made a new patch to fix embedded multipart messages are stripped bug. this patch is for CVS. see http://mail.python.org/pipermail/mailman-users/2003-February/026071.html ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 05:13 Message: Logged In: YES user_id=12800 Reopening so this issue doesn't get lost. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-20 04:03 Message: Logged In: YES user_id=67709 We, Japanese, need additional process of stringify and regenerate message instance.. Internal message is in 'euc-jp' but return value of get_content_charset() becomes 'iso-2022-jp' even though the get_payload() returns euc-jp text. The message and part body is converted to iso-2022-jp when it is output to SMTP (or whatever accepts in string format). ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 02:18 Message: Logged In: YES user_id=12800 Accepted, with changes. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-19 00:52 Message: Logged In: YES user_id=67709 Update of patch. Please backout the first one if you have already applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i…

1 0

[ mailman-Patches-664209 ] best effort to keep text/plain
by SourceForge.net Feb. 20, 2003

Feb. 20, 2003

Patches item #664209, was opened at 2003-01-08 06:14 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i… Category: internationalization Group: Mailman 2.1 Status: Open Resolution: None >Priority: 6 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: best effort to keep text/plain Initial Comment: When a message come in different charset than list specific one, Decorate.py adds the header and footer in mime attatchments. This patch tries to keep the good-old plain text format by making these texts into unicode and encode in list preferred charset. If it fails, the messages will get mime-multiparted as was the case without this patch. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:24 Message: Logged In: YES user_id=67709 Refine the code and increment priority. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-08 07:34 Message: Logged In: YES user_id=67709 Expand this patch to base64 encoded plain text. apply the second patch Decorate.py.diff2 to the original Decorate.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i…

1 0

[ mailman-Patches-664209 ] best effort to keep text/plain
by SourceForge.net Feb. 20, 2003

Feb. 20, 2003

Patches item #664209, was opened at 2003-01-08 06:14 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i… Category: internationalization Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: best effort to keep text/plain Initial Comment: When a message come in different charset than list specific one, Decorate.py adds the header and footer in mime attatchments. This patch tries to keep the good-old plain text format by making these texts into unicode and encode in list preferred charset. If it fails, the messages will get mime-multiparted as was the case without this patch. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:24 Message: Logged In: YES user_id=67709 Refine the code and increment priority. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-08 07:34 Message: Logged In: YES user_id=67709 Expand this patch to base64 encoded plain text. apply the second patch Decorate.py.diff2 to the original Decorate.py ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=664209&group_i…

1 0