Mailman 3 March 2003 - Mailman-coders

[ mailman-Bugs-707604 ] remove_members doesn't use default setting
by SourceForge.net 21 Mar '03

21 Mar '03

Bugs item #707604, was opened at 2003-03-21 16:37 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=707604&group_i… Category: command line scripts Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Ricardo Kustner (rixhq) Assigned to: Nobody/Anonymous (nobody) Summary: remove_members doesn't use default setting Initial Comment: bin/remove_members turns on "userack" by default... even though it's supposed to use the list config setting whether or not it should send a message to the unsubscribers (line 111 in remove_members says "userack = 1"). is this a bug or has this been done intentionally? the danger is that even if you have "nouserack" set in your system, using "remove_members -a" will always mail all unsubscribers unless you specifically tell it not to through the command line... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=707604&group_i…

1 0

[ mailman-Patches-444884 ] Integration of Mailman & htdig for archi
by SourceForge.net 20 Mar '03

20 Mar '03

Patches item #444884, was opened at 2001-07-26 18:27 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=444884&group_i… Category: Unofficial 2.0 patch Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 3 Submitted By: Richard Barrett (ppsys) Assigned to: Barry A. Warsaw (bwarsaw) Summary: Integration of Mailman & htdig for archi Initial Comment: This patch is applicable to Mailman 2.0.6 release that has had search enhancement patch 444879 patch installed - if your Defaults.py has the ARCHIVE_INDEXING_ENABLE and ARCHIVE_INDEXING_DISABLE in it then you've got that patch. It replaces earlier patches 401670 and 402423 and is mainly to correct some problems arising from fixes introduced into Mailman by bug fix releases since the 402423 patch. This patch integrates htdig with Mailman and provides: 1. per list search facility with a search form on the list's TOC page. 2. maintenance of privacy of private archives which requires the user to establish their credentials via the normal private archive access before any access via htdig is allowed. 3. a common base URL for both public and private archive access via htsearch results so that htdig indices are unaffected by changingan archive from private to public and vice versa. All access to archives via htdig is controlled by a new wrapped cgi- bin script called htdig.py. 4. a new cron activated script and extra crontab entry which runs htdig regularly to maintain the per list search indices. 5. automatic creation, deletion and maintenance of htdig configuration files and such. Beyond installing htdig and telling Mailman where it is via mm_cfg you do not have to do any other setup. Well not quite you do have to set up a single per installation symlink to allow htdig to find the automatically generated per list htdig configuration files. You probably want to run this patch as follows: cd <mailman 2.0.6 untarred and unzipped directory> patch -p1 < <this patch file> ---------------------------------------------------------------------- >Comment By: Richard Barrett (ppsys) Date: 2003-03-20 14:10 Message: Logged In: YES user_id=75166 htdig-2.1.1-0.2.patch.gz close a security exploit which allows leakage of information held in htdig's per-list search indexes to users not authorized to view private list archives. Read file INSTALL.htdig-mm installed by this patch for details and instructions for upgrading MM installations using earlier versions of this patch ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-02-10 15:50 Message: Logged In: YES user_id=75166 htdig-2.1.1-0.1.patch.gz introduces no functional change but applies without offset warnings to MM 2.1.1 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-02-05 18:12 Message: Logged In: YES user_id=75166 It seems it is possible, if this patch is installed, for a list's htdig conf file and the list specific htdig index db files to be read directly through the web interface for list archives. Even if this patch isn't installed it seems a list's pipermail.pck file can also be read directly through the web interface for list archives. This seems to be true for accesses via /pipermail for public lists and via /mailman/private for private lists. The problem does not occur for htdig search results accessed via /mailman/htdig as the htdig.py script is more protective than private.py Broadly speaking the data affected is availble to a user in normal operation which is why I do not consider the issue to be a security breach as such. Adding the following RewriteRule to Apache's httpd.conf prevents the situation, assuming you got the RewriteEngine On: RewriteRule ^(/pipermail/.*)/(pipermail.pck|htdig/[^/]*)$ $1/index.html [F] RewriteRule ^(/mailman/private/.*)/(pipermail.pck|htdig/[^/]*)$ $1/index.htm l [F] You could, of course, substitute an R flag for the F flag on the RewriteRules and be more hacker friendly. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-01-22 14:20 Message: Logged In: YES user_id=75166 htdig-2.1-0.3.patch corrects yet another bug in htdig.py. Hope that all of them! Stops use of obsolete config variable DEFAULT_HOST in several files. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-01-15 20:18 Message: Logged In: YES user_id=75166 htdig-2.1-0.2.patch corrects a bug in htdig.py and deals with an adverse interaction between htdig.py and a bug in $prefix/scripts/driver (see #668685 for a patch to fix this). It also improves the content type and security handling by htdig.py for MM 2.1 version of patch ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-01-15 20:14 Message: Logged In: YES user_id=75166 Uploaded wrong file mailer-2.0.13-0.4.patch on last attempt. Should have been htdig-2.0.13-0.4.patch which improves the content type and security handling by htdig.py for MM 2.0.13 version of patch. Please ignore mailer-2.0.13-0.4.patch file ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-01-15 20:09 Message: Logged In: YES user_id=75166 mailer-2.0.13-0.4.patch improves the content type and security handling by htdig.py for MM 2.0.13 version of patch ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-01-02 16:07 Message: Logged In: YES user_id=75166 htdig-2.1-0.1.patch is a revised version of the patch that is compatible with MM 2.1 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-12-11 11:48 Message: Logged In: YES user_id=75166 htdig-2.1b6-0.1.patch is a revised version of the patch that is compatible with MM 2.1b6 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-12-04 10:53 Message: Logged In: YES user_id=75166 htdig-2.0.13-0.3.patch corrects a minor typo in text appearing in the list TOC after the patch is applied. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-11-27 10:24 Message: Logged In: YES user_id=75166 htdig-2.1b5-0.1.patch is a revised version of the patch that is compatible with MM 2.1b5 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-10-30 11:43 Message: Logged In: YES user_id=75166 htdig-2.1b4-0.1.patch is a revised version of the patch that is compatible with MM 2.1b4 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-10-14 11:50 Message: Logged In: YES user_id=75166 htdig-2.1b3-0.3.patch removes use of the file() function, used instead of the open() function, in three cron scripts added by the patch. Use of the file() function created an unnecessary dependency on Python 2.2 ---------------------------------------------------------------------- Comment By: Colin Mackinlay (cmackinlay) Date: 2002-10-12 16:51 Message: Logged In: YES user_id=624179 Got a workaround! The line referred to in the traceback: file(rundig_run_file, 'w').close() is used to create a 'rundig_last_run' file of lenght 0 bytes Creating this manually (or copying it) means the line isn't called and everything seems to work. Either file() is not a valid function call or my python is broken - I'm not literate enough in python to know the answer though! ---------------------------------------------------------------------- Comment By: Colin Mackinlay (cmackinlay) Date: 2002-10-06 14:18 Message: Logged In: YES user_id=624179 Just rebuilt MM as 2.1b3 with htdig. Upgraded lists which had htdig before work fine New lists give the obvious error: Unable to read word database file Did you run htmerge? Running the cronjob doesn't fix as it used to, message is: Output from command /usr/bin/python - S /usr/local/mailman/cron/nightly_htdig .. Traceback (most recent call last): File "/usr/local/mailman/cron/nightly_htdig", line 153, in ? main() File "/usr/local/mailman/cron/nightly_htdig", line 118, in main file(rundig_run_file, 'w').close() NameError: global name 'file' is not defined The archive/htdig folder only contains the xx.conf file, but no db.xx files If I copy in db.xx files from another list then the problem goes away (except I've now got an invalid set of references!) Is this my elementary error or is it more sinister?! ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-08-15 11:02 Message: Logged In: YES user_id=75166 htdig-2.1b3-0.2.patch corrects a dumb syntax error in htdig- 2.1b3-0.1.patch which will typically show up as logged errors in the operation of the ArchRunner qrunner at line 721 of HyperArch.py ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-08-14 16:51 Message: Logged In: YES user_id=75166 htdig-2.1b3-0.1.patch is a revised version of the patch that is compatible with MM 2.1b3 ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-08-08 16:33 Message: Logged In: YES user_id=12800 I've sent Richard some comments off-line about this patch. Meta comments: the 2.0.x patches can't be officially supported, but I'm going to create an unofficial patches page off the wiki for where the 2.0 patches can be migrated. I think this patch set is too big for MM2.1, but if it's cleaned up as per my private message, let's re-evaluate it for MM2.2 (or 3.0). ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-08-05 10:11 Message: Logged In: YES user_id=75166 htdig-2.0.13-0.2.patch just adds a GPL notice to the patch ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-08-01 16:35 Message: Logged In: YES user_id=75166 htdig-2.1b2-0.1.patch is a revised version of the patch that is compatible with MM 2.1b2 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-07-30 11:25 Message: Logged In: YES user_id=75166 htdig-2.0.13-0.1.patch is purely cosmetic to get no mumble application to MM 2.0.13 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-07-25 15:07 Message: Logged In: YES user_id=75166 Do not use htdig-2.0.12-0.1.patch there is an error in it. Use htdig-2.0.12-0.2.patch instead ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-07-25 14:10 Message: Logged In: YES user_id=75166 htdig-2.0.12-0.1.patch is a revised version of the patch that applies without complaint to MM 2.0.12. It also add a facility for adding site wide htdig configuration attributes to all list specific htdig configuration files. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-05-23 09:59 Message: Logged In: YES user_id=75166 htdig-2.0.11-0.1.patch is a revised version of the patch that is compatible with MM 2.0.11 This version removes an incompatibility with Python 2.2 which caused warning messages to be generated when any of the family cron/nightly_htdig scripts were run. Some guidance on file access permissions for some htdig database files needed by rundig have been added to installation notes. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-04-19 10:59 Message: Logged In: YES user_id=75166 htdig-2.0.10-0.1.patch is a revised version of the patch that is compatible with MM 2.0.10 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-04-08 17:46 Message: Logged In: YES user_id=75166 htdig-2.0.9-0.1.patch is a revised version of the patch that is compatible with MM 2.0.9 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2002-03-06 16:22 Message: Logged In: YES user_id=75166 htdig-2.1cvs-20020306.patch is a revised version of the patch that is compatible with the code published in mailman CVS on sourceforge as 12:30 GMT 6 Mar 2002 Known deficiency is that the non-English versions of files under $build/templates still contain text in English and need translations I cannot do. Also the necessary pygettext activity and subsequent translations in files under $build/messages remain to be done. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2001-12-17 16:56 Message: Logged In: YES user_id=75166 htdig-2.1cvs-20011217.patch is a revised version of the patch that is compatible with the code published in mailman CVS on sourceforge as 11:50 GMT 17 Dec 2001 The only known deficiency is that the non-English versions of files under $build/templates still contain text in English and need translations I cannot do. Also the necessary pygettext activity and subsequent translations in files under $build/messages remain to be done. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2001-12-13 16:58 Message: Logged In: YES user_id=75166 htdig-2.1a3-0.1.patch is a revised version of the patch that is compatible with the code published in mailman-2.1a3.tgz on sourceforge. The only known deficiency is that the non-English versions of files under $build/templates still contain text in English and need translations I cannot do. Also the necessary pygettext activity and subsequent translations in files under $build/messages remain to be done. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2001-11-28 17:33 Message: Logged In: YES user_id=75166 The htdig-2.0.8-0.1.patch version of the patch resolves a problem that can arise with htdig indexing if the web_page_url for a list uses other than the http addressing (some folks want to use https). While specified as for MM 2.0.8 the revised patch should work OK with 2.0.7, 2.0.6 and probably back as far as 2.0.3. If you do not have the requirement for using other than http addressing in you lists web_page_urls it probably isn't worth the trouble of upgrading to this patch level. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2001-11-28 11:08 Message: Logged In: YES user_id=75166 This patch should also apply without problems to MM 2.0.8 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2001-11-27 12:00 Message: Logged In: YES user_id=75166 This patch should also apply without problems to Mm 2.0.7 ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2001-11-09 11:54 Message: Logged In: YES user_id=75166 The htdig-2.0.6-03.patch version of the patch makes some previously hard-coded things configurable and enhances the capability to run the htdig searches and indexing on a different machine to the one delivering Mailman and Mailman's web UI. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=444884&group_i…

1 0

[ mailman-Bugs-705982 ] cvs-version: header-errors with long listnames
by SourceForge.net 18 Mar '03

18 Mar '03

Bugs item #705982, was opened at 2003-03-19 01:31 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=705982&group_i… Category: None Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Jan Kellermann (werk21) Assigned to: Nobody/Anonymous (nobody) Summary: cvs-version: header-errors with long listnames Initial Comment: since updating to the cvs-version, a blank line is inserted into the headers of lists with long listnames. the effect is that the header-lines after the empty line are shown in the mailclient. It seems to correspondate with the length of the listname and indirect with the line-length in the header. the lists worked correctly before updating. any ideas? Example: (you see 2 blank lines after the long lines and comma) From: "Jan Kellermann" <jan.kellermann(a)werk21.de> To: <ein-ganz-langer-listen-name-zum- testen(a)werk21server.de> Date: Tue, 18 Mar 2003 20:07:20 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailman-Approved-At: Tue, 18 Mar 2003 19:52:42 +0100 Subject: [Ein-ganz-langer-listen-name-zum-testen] test X-BeenThere: ein-ganz-langer-listen-name-zum- testen(a)werk21server.de X-Mailman-Version: 2.1.1+ Precedence: list List-Id: <ein-ganz-langer-listen-name-zum- testen.werk21server.de> List-Unsubscribe: <http://www.werk21server.de/mailman/listinfo/ein-ganz- langer-listen-name-zum-testen>, <mailto:ein-ganz-langer-listen-name-zum- testen-request(a)werk21server.de? subject=unsubscribe> List-Archive: <http://www.werk21server.de/mailarchiv/ein-ganz- langer-listen-name-zum-testen> List-Post: <mailto:ein-ganz-langer-listen-name-zum- testen(a)werk21server.de> List-Help: <mailto:ein-ganz-langer-listen-name-zum- testen-request(a)werk21server.de?subject=help> List-Subscribe: <http://www.werk21server.de/mailman/listinfo/ein-ganz- langer-listen-name-zum-testen>, <mailto:ein-ganz-langer-listen-name-zum- testen-request(a)werk21server.de?subject=subscribe> Sender: ein-ganz-langer-listen-name-zum-testen- bounces+kelly=werk21.de(a)werk21server.de Errors-To: ein-ganz-langer-listen-name-zum-testen- bounces+kelly=werk21.de(a)werk21server.de ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=705982&group_i…

1 0

[ mailman-Bugs-705794 ] TimeOutError / NotLockedError
by SourceForge.net 18 Mar '03

18 Mar '03

Bugs item #705794, was opened at 2003-03-18 20:35 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=705794&group_i… Category: None Group: 2.1 beta Status: Open Resolution: None Priority: 5 Submitted By: Peer Heinlein (pheinlein) Assigned to: Nobody/Anonymous (nobody) Summary: TimeOutError / NotLockedError Initial Comment: With the newest CVS I have several notes about TimeOutError/NotLockedError in my error-log and mails are shunted. Traceback (most recent call last): File "/usr/lib/mailman/scripts/driver", line 87, in run_main main() File "/usr/lib/mailman/Mailman/Cgi/admin.py", line 169, in main change_options(mlist, category, subcat, cgidata, doc) File "/usr/lib/mailman/Mailman/Cgi/admin.py", line 1260, in change_options mlist.InviteNewMember(userdesc, invitation) File "/usr/lib/mailman/Mailman/MailList.py", line 693, in InviteNewMember cookie = Pending.new(Pending.SUBSCRIPTION, userdesc) File "/usr/lib/mailman/Mailman/Pending.py", line 61, in new lock.lock(timeout=30) File "/usr/lib/mailman/Mailman/LockFile.py", line 293, in lock raise TimeOutError TimeOutError ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=705794&group_i…

1 0

[ mailman-Patches-657951 ] Generate RSS summary in archives
by SourceForge.net 17 Mar '03

17 Mar '03

Patches item #657951, was opened at 2002-12-23 19:17 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i… Category: Pipermail Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 5 Submitted By: A.M. Kuchling (akuchling) Assigned to: Nobody/Anonymous (nobody) Summary: Generate RSS summary in archives Initial Comment: Here's a first-draft patch. Things that need fixing: * The generated RSS feed needs to be validated. (It passed the W3C's RDF validator, but RSS validators still need to be checked.) * The date should be given in YYYY-MM-DD format, which requires parsing the .fromdate attribute. * How do I get the URL for an archived message? The generated RSS currently just uses the filename, which is wrong. How do I get at the PUBLIC_ARCHIVE_URL setting? * Getting the most recent N postings is inefficient; the code loops through all of the archived messages and takes the last N of them. We could add .last() and .prev() methods to the Database class, but that's more ambitious for 2.1beta than I like. (Would be nice to get this into 2.1final...) * The list index page should have a LINK element pointing to the RSS file. Please make any comments you have, and I'll rework the patch accordingly. ---------------------------------------------------------------------- Comment By: Uche Ogbuji (uche) Date: 2003-03-18 01:09 Message: Logged In: YES user_id=38966 I'd like to add my vote to this item. This is a fantastic idea, Andrew. Thanks. --Uche ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2002-12-23 20:42 Message: Logged In: YES user_id=11375 Updated patch: * Dates are now rendered as ISO-8601 (date only, not the time of the message) * By hard-wiring 2002-December, I got the RSS to validate using Mark Pilgrim's validator. ---------------------------------------------------------------------- Comment By: captain larry (captainlarry) Date: 2002-12-23 19:36 Message: Logged In: YES user_id=147905 Just voting for support here. This is *great* thanks for the patch and I hope the maintainers include it as soon as it's appropriate :) Adam. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-23 19:27 Message: Logged In: YES user_id=12800 Deferring until post-2.1 ---------------------------------------------------------------------- Comment By: A.M. Kuchling (akuchling) Date: 2002-12-23 19:21 Message: Logged In: YES user_id=11375 Argh; SF choked on the file upload. Attaching the patch again... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=657951&group_i…

1 0

[ mailman-Patches-645297 ] Add PGP support
by SourceForge.net 17 Mar '03

17 Mar '03

Patches item #645297, was opened at 2002-11-28 15:54 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645297&group_i… Category: None Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 5 Submitted By: Ben Laurie (benl) >Assigned to: Thomas Wouters (twouters) Summary: Add PGP support Initial Comment: Support PGP encrypted lists using GnuPG. ---------------------------------------------------------------------- >Comment By: Thomas Wouters (twouters) Date: 2003-03-17 23:17 Message: Logged In: YES user_id=34209 I'll look at incorporating this when I look at the SecureList patch by NAH6 (SF patch #646989, currently.) ---------------------------------------------------------------------- Comment By: Nicolas Marchildon (elecnix) Date: 2003-02-06 06:16 Message: Logged In: YES user_id=106549 My vote goes to a PGP whitelist and blacklist feature. Messages signed with a key present in the whitelist could go skip moderation, messages in the blacklist would be either ignored or rejected, and all other messages could go through moderation. That way, PGP signatures are not required, but those using them would see their messages delivered quickly. Mailman would have two keyrings, and would manage them by specifying --keyring to gpg. PGP keys would be retreived from a PGP key server. When moderating a message that was signed with a key missing from the whitelist, there would be an option named "Add key to whitelist", and an other one for the blacklist. Keys could be added to the white/blacklist through the web interface by specifying at least a key ID, and mailman would ask gpg to fetch the key from mailman's default key server. Initially proposed in French on: http://www.linux-quebec.org/archives/general/msg03787.html Nicolas Marchildon ---------------------------------------------------------------------- Comment By: David Shaw (dmshaw) Date: 2003-01-04 20:59 Message: Logged In: YES user_id=606006 Another vote of support. I actually submitted an enhancement request earlier today for exactly this. ---------------------------------------------------------------------- Comment By: captain larry (captainlarry) Date: 2002-12-23 20:37 Message: Logged In: YES user_id=147905 Adding a vote of support for this patch. Please add it as soon as it's appropriate! I've been waiting a long time for this functionality and I'd hate to see the patch bitrot. :-) Adam. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-12-12 04:56 Message: Logged In: YES user_id=12800 I have to defer this patch until after MM2.1 since we're about ready for the first release candidate. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=645297&group_i…

1 0

[ mailman-Bugs-670535 ] qrunner stops for no apparent reason
by SourceForge.net 17 Mar '03

17 Mar '03

Bugs item #670535, was opened at 2003-01-18 21:04 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=670535&group_i… Category: mail delivery Group: 2.1 (stable) Status: Open Resolution: None Priority: 8 Submitted By: David Gibbs (midrangeman) Assigned to: Nobody/Anonymous (nobody) Summary: qrunner stops for no apparent reason Initial Comment: About once every day or so, qrunner will stop for no apparent reason. The qrunner log file has the following ... Jan 18 14:29:09 2003 (3443) IncomingRunner qrunner caught SIGTERM. Stopping. Jan 18 14:29:09 2003 (3443) IncomingRunner qrunner exiting. Jan 18 14:29:09 2003 (3441) BounceRunner qrunner caught SIGTERM. Stopping. Jan 18 14:29:09 2003 (3441) BounceRunner qrunner exiting. Jan 18 14:29:09 2003 (3445) OutgoingRunner qrunner caught SIGTERM. Stopping. Jan 18 14:29:09 2003 (3445) OutgoingRunner qrunner exiting. Jan 18 14:29:09 2003 (3442) CommandRunner qrunner caught SIGTERM. Stopping. Jan 18 14:29:09 2003 (3442) CommandRunner qrunner exiting. Jan 18 14:29:09 2003 (3446) VirginRunner qrunner caught SIGTERM. Stopping. Jan 18 14:29:09 2003 (3446) VirginRunner qrunner exiting. Jan 18 14:29:09 2003 (3440) ArchRunner qrunner caught SIGTERM. Stopping. Jan 18 14:29:09 2003 (3440) ArchRunner qrunner exiting. Jan 18 14:29:10 2003 (3444) NewsRunner qrunner caught SIGTERM. Stopping. Jan 18 14:29:12 2003 (3444) NewsRunner qrunner exiting. No other log has any indication of what might be happening. Is there a way to increase the logging somewhere so the cause can be identified? ---------------------------------------------------------------------- >Comment By: David Gibbs (midrangeman) Date: 2003-03-17 11:44 Message: Logged In: YES user_id=86339 Additional environment details: Redhat Linux 8.0, uname = "Linux xxx.midrange.com 2.4.18- 26.8.0 #1 Mon Feb 24 10:21:42 EST 2003 i686 i686 i386 GNU/Linux" Python: 2.2.1 CPU: P4 2.4ghz, 512mb RAM Dunno if this makes a difference, but I have the following directories ... /usr/lib/python1.5 /usr/lib/python2.1 /usr/lib/python2.2 Any chance there is a conflict? ---------------------------------------------------------------------- Comment By: David Gibbs (midrangeman) Date: 2003-01-24 12:31 Message: Logged In: YES user_id=86339 I added some debug code to mailmanctl and found out that the sigalarm handler is firing just before the qrunners are terminating. ---------------------------------------------------------------------- Comment By: David Gibbs (midrangeman) Date: 2003-01-22 15:31 Message: Logged In: YES user_id=86339 After some further research, QRUNNER seems to stop after exactly 24 hours of operation. That is, 24 hours after qrunner starts, it ends as if someone killed it with SIGTERM. I know for a fact that nobody is actually doing this ... and no process on my system should be aware of the fact that qrunner is actually running. I will not discount the possiblity that this is an environmental factor, but it seems to me that a daemon process should not be affected by environmental factors. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-19 16:46 Message: Logged In: YES user_id=12800 I'm not sure what kind of logging would help. Some process somewhere is SIGTERMing the mailmanctl controller process. There's no way to know where a signal is coming from, so I'm not sure what more you could do in mailmanctl. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=670535&group_i…

1 0

[ mailman-Bugs-704912 ] Invitation bug
by SourceForge.net 17 Mar '03

17 Mar '03

Bugs item #704912, was opened at 2003-03-17 11:51 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=704912&group_i… Category: (un)subscribing Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Daniel Buchmann (avalon) Assigned to: Nobody/Anonymous (nobody) Summary: Invitation bug Initial Comment: There seems to be a bug in parsing the confirmation of an invitation to join a mailing list. I suspect this has something to do with MIME decoding of the Subject: header. When sending a reply to the autogenerated invitation (in my case, using pine), with this header: Subject: Re: =?iso-8859-1?q?confirm_55ed0163ec2f0a56ac257f708b 470b6a892935f2?= nothing happened. But when sending a reply with this header (which was the case if I used Netscape Mail or Evolution): Subject: Re: confirm 9924a8cb2e31d2f1605ca6228ff210901ff17aba I was subscribed. Maybe Mailman doesn't decode the Subject: before parsing it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=704912&group_i…

1 0

[ mailman-Patches-534577 ] Add SpamAssassin filter to mail pipeline
by SourceForge.net 16 Mar '03

16 Mar '03

Patches item #534577, was opened at 2002-03-25 16:17 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=534577&group_i… Category: list administration >Group: Mailman 2.1 Status: Open Resolution: None Priority: 1 Submitted By: James Henstridge (jhenstridge) Assigned to: Nobody/Anonymous (nobody) Summary: Add SpamAssassin filter to mail pipeline Initial Comment: This filter adds support for discarding or holding spam sent to the mailing list. It contacts a spamd daemon (from SpamAssassin -- http://spamassassin.taint.org) to score the message. If the score is above a certain threshold (default 10), the message is discarded and an entry is written to the vette log. If the score is above another lower threshold (default 5), the message is held for moderation. The SpamAssassin.py file should be installed in Mailman/Handlers/. The LIST_PIPELINE variable in Mailman/Handlers/HandlerAPI.py should be modified to include a 'SpamAssassin' item (I put it just after the existing 'SpamDetect' item). To change the defaults, the following can be added to the mm_cfg.py file: SPAMASSASSIN_HOST = 'host:port' # how to contact SA SPAMASSASSIN_DISCARD_SCORE = 10 SPAMASSASSIN_HOLD_SCORE = 5 If you don't want to discard messages, then DISCARD_SCORE can be set to something very high (1000 should do it). It looks the MM2.1 filter APIs have changed a bit, so this filter will need some modifications to work with that version. When I get round to upgrading, I might look into updating it. ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2003-03-17 13:46 Message: Logged In: YES user_id=146903 Attached is an updated version of the filter for adding SpamAssassin support to mailman. This version is targetted at Mailman 2.1.x. The code for talking to spamd has been split out into a separate file, so that it can be updated independently of the Mailman specific code. It has also been updated to work with SpamAssassin 2.50 (and should be a lot more robust to future additions to the spamd protocol). The filter has also been changed to use the list name as the username passed to spamd, which means that separate auto-whitelists and bayes databases can be maintained for each list. Installation is trivial. Simply copy spamd.py and SpamAssassin.py to the Mailman/Handlers directory and add the following line to Mailman/mm_cfg.py: GLOBAL_PIPELINE.insert(1, 'SpamAssassin') ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-08-23 14:32 Message: Logged In: YES user_id=81797 That last one had a missing quote. Try this patch: *** SpamAssassin.py.orig Fri Aug 23 00:28:59 2002 --- SpamAssassin.py Fri Aug 23 00:31:00 2002 *************** *** 30,45 **** from Mailman.Logging.Syslog import syslog from Hold import hold_for_approval ! SPAMD_PORT = 0 ! try: ! SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST ! i = string.find(SPAMD_HOST, ':') ! if i >= 0: ! SPAMD_HOST, SPAMD_PORT = SPAMD_HOST[:i], host[i+1:] ! try: SPAMD_PORT = int(SPAMD_PORT) ! except: SPAMD_PORT = None ! except: ! SPAMD_HOST = 'localhost' if not SPAMD_PORT: SPAMD_PORT = 783 try: DISCARD_SCORE = mm_cfg.SPAMASSASSIN_DISCARD_SCORE --- 30,44 ---- from Mailman.Logging.Syslog import syslog from Hold import hold_for_approval ! SPAMD_HOST = 'localhost' ! SPAMD_PORT = None ! if hasattr(mm_cfg, 'SPAMASSASSIN_HOST'): ! SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST ! try: ! SPAMD_HOST, SPAMD_PORT = string.split(SPAMD_HOST, ':', 1) ! SPAMD_PORT = int(SPAMD_PORT) ! except ValueError: ! SPAMD_PORT = None if not SPAMD_PORT: SPAMD_PORT = 783 try: DISCARD_SCORE = mm_cfg.SPAMASSASSIN_DISCARD_SCORE Sean ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-08-23 14:19 Message: Logged In: YES user_id=81797 How about changing that chunk of code to: SPAMD_HOST = 'localhost' SPAMD_PORT = None if hasattr(mm_cfg, 'SPAMASSASSIN_HOST): SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST try: SPAMD_HOST, SPAMD_PORT = string.split(SPAMD_HOST, ':', 1) SPAMD_PORT = int(SPAMD_PORT) except ValueError: SPAMD_PORT = None if not SPAMD_PORT: SPAMD_PORT = 783 This gets rid of the "bare except"s, and I think it's a little clearer than the previous code. The ValueError will be tripped if the string doesn't have a : in it, or if the int coercion fails. Though perhaps in that instance you'd want to log an error or something... Sean ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-08-23 14:18 Message: Logged In: YES user_id=81797 How about changing that chunk of code to: SPAMD_HOST = 'localhost' SPAMD_PORT = None if hasattr(mm_cfg, 'SPAMASSASSIN_HOST): SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST try: SPAMD_HOST, SPAMD_PORT = string.split(SPAMD_HOST, ':', 1) SPAMD_PORT = int(SPAMD_PORT) except ValueError: SPAMD_PORT = None if not SPAMD_PORT: SPAMD_PORT = 783 This gets rid of the "bare except"s, and I think it's a little clearer than the previous code. The ValueError will be tripped if the string doesn't have a : in it, or if the int coercion fails. Though perhaps in that instance you'd want to log an error or something... Sean ---------------------------------------------------------------------- Comment By: dann frazier (dannf) Date: 2002-08-18 02:11 Message: Logged In: YES user_id=146718 hey James, found a typo. also wanted to point out: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=139942&repeatmerged=yes --- SpamAssassin.py.orig Sat Aug 17 12:05:41 2002 +++ SpamAssassin.py Sat Aug 17 12:06:13 2002 @@ -35,7 +35,7 @@ SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST i = string.find(SPAMD_HOST, ':') if i >= 0: - SPAMD_HOST, SPAMD_PORT = SPAMD_HOST[:i], host[i+1:] + SPAMD_HOST, SPAMD_PORT = SPAMD_HOST[:i], SPAMD_HOST[i+1:] try: SPAMD_PORT = int(SPAMD_PORT) except: SPAMD_PORT = None except: ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-25 17:00 Message: Logged In: YES user_id=146903 remembering to check the "upload file" checkbox this time ... ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-25 16:59 Message: Logged In: YES user_id=146903 Yet another new version that fixes a small typo. With previous messages, you couldn't approve messages that had been identified as spam once (they would get identified again when the queue got processed, instead of passing the message through). ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-10 08:19 Message: Logged In: YES user_id=146903 The Mailman installation on mail.gnome.org also uses this filter. I don't think there are any stability problems with the filter. ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-07-10 05:16 Message: Logged In: YES user_id=81797 FYI, I ran the previous version since installation and it seemed to work fine. I didn't run into any problems, with probably 500 messages handled. I've updated to the new version and it seems ok so far, but I've only sent about 10 messages through. Sean ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-03 12:02 Message: Logged In: YES user_id=146903 Yet another version. There were some bugs in handling of certain error conditions when talking to spamd. These would result in exceptions and the messages staying in the delivery queue :( With the new version, the message will be passed through unchecked under these conditions, and a message will be added to the error log. ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-06-13 05:48 Message: Logged In: YES user_id=81797 FYI: I've been running the 2002-05-14 version of this patch with spamassassin 2.20 for the last day on our main mailman box and it seems to be working great. ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-05-14 14:04 Message: Logged In: YES user_id=146903 This version is essentially the same as the previous version, but adds compatibility with python > 1.5.2, which doesn't like you passing two arguments to socket.connect(). ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-04-27 14:17 Message: Logged In: YES user_id=146903 Just attached my updated version of the patch. This version requires SpamAssassin 2.20 (for the extra commands that the spamd daemon understands). It now displays a list of which rules were triggered for held messages, and can give messages from list members a bonus (defaults to 2), so that they are less likely to get held as spam. ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-03-26 09:21 Message: Logged In: YES user_id=146903 There is a fairly easy optimisation for this filter that I missed when writing it. It calls str() on the message object twice. It would be quicker to call str() on the message once. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=534577&group_i…

1 0

[ mailman-Patches-534577 ] Add SpamAssassin filter to mail pipeline
by SourceForge.net 16 Mar '03

16 Mar '03

Patches item #534577, was opened at 2002-03-25 16:17 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=534577&group_i… Category: list administration Group: Mailman 2.0.x Status: Open Resolution: None Priority: 1 Submitted By: James Henstridge (jhenstridge) Assigned to: Nobody/Anonymous (nobody) Summary: Add SpamAssassin filter to mail pipeline Initial Comment: This filter adds support for discarding or holding spam sent to the mailing list. It contacts a spamd daemon (from SpamAssassin -- http://spamassassin.taint.org) to score the message. If the score is above a certain threshold (default 10), the message is discarded and an entry is written to the vette log. If the score is above another lower threshold (default 5), the message is held for moderation. The SpamAssassin.py file should be installed in Mailman/Handlers/. The LIST_PIPELINE variable in Mailman/Handlers/HandlerAPI.py should be modified to include a 'SpamAssassin' item (I put it just after the existing 'SpamDetect' item). To change the defaults, the following can be added to the mm_cfg.py file: SPAMASSASSIN_HOST = 'host:port' # how to contact SA SPAMASSASSIN_DISCARD_SCORE = 10 SPAMASSASSIN_HOLD_SCORE = 5 If you don't want to discard messages, then DISCARD_SCORE can be set to something very high (1000 should do it). It looks the MM2.1 filter APIs have changed a bit, so this filter will need some modifications to work with that version. When I get round to upgrading, I might look into updating it. ---------------------------------------------------------------------- >Comment By: James Henstridge (jhenstridge) Date: 2003-03-17 13:46 Message: Logged In: YES user_id=146903 Attached is an updated version of the filter for adding SpamAssassin support to mailman. This version is targetted at Mailman 2.1.x. The code for talking to spamd has been split out into a separate file, so that it can be updated independently of the Mailman specific code. It has also been updated to work with SpamAssassin 2.50 (and should be a lot more robust to future additions to the spamd protocol). The filter has also been changed to use the list name as the username passed to spamd, which means that separate auto-whitelists and bayes databases can be maintained for each list. Installation is trivial. Simply copy spamd.py and SpamAssassin.py to the Mailman/Handlers directory and add the following line to Mailman/mm_cfg.py: GLOBAL_PIPELINE.insert(1, 'SpamAssassin') ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-08-23 14:32 Message: Logged In: YES user_id=81797 That last one had a missing quote. Try this patch: *** SpamAssassin.py.orig Fri Aug 23 00:28:59 2002 --- SpamAssassin.py Fri Aug 23 00:31:00 2002 *************** *** 30,45 **** from Mailman.Logging.Syslog import syslog from Hold import hold_for_approval ! SPAMD_PORT = 0 ! try: ! SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST ! i = string.find(SPAMD_HOST, ':') ! if i >= 0: ! SPAMD_HOST, SPAMD_PORT = SPAMD_HOST[:i], host[i+1:] ! try: SPAMD_PORT = int(SPAMD_PORT) ! except: SPAMD_PORT = None ! except: ! SPAMD_HOST = 'localhost' if not SPAMD_PORT: SPAMD_PORT = 783 try: DISCARD_SCORE = mm_cfg.SPAMASSASSIN_DISCARD_SCORE --- 30,44 ---- from Mailman.Logging.Syslog import syslog from Hold import hold_for_approval ! SPAMD_HOST = 'localhost' ! SPAMD_PORT = None ! if hasattr(mm_cfg, 'SPAMASSASSIN_HOST'): ! SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST ! try: ! SPAMD_HOST, SPAMD_PORT = string.split(SPAMD_HOST, ':', 1) ! SPAMD_PORT = int(SPAMD_PORT) ! except ValueError: ! SPAMD_PORT = None if not SPAMD_PORT: SPAMD_PORT = 783 try: DISCARD_SCORE = mm_cfg.SPAMASSASSIN_DISCARD_SCORE Sean ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-08-23 14:19 Message: Logged In: YES user_id=81797 How about changing that chunk of code to: SPAMD_HOST = 'localhost' SPAMD_PORT = None if hasattr(mm_cfg, 'SPAMASSASSIN_HOST): SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST try: SPAMD_HOST, SPAMD_PORT = string.split(SPAMD_HOST, ':', 1) SPAMD_PORT = int(SPAMD_PORT) except ValueError: SPAMD_PORT = None if not SPAMD_PORT: SPAMD_PORT = 783 This gets rid of the "bare except"s, and I think it's a little clearer than the previous code. The ValueError will be tripped if the string doesn't have a : in it, or if the int coercion fails. Though perhaps in that instance you'd want to log an error or something... Sean ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-08-23 14:18 Message: Logged In: YES user_id=81797 How about changing that chunk of code to: SPAMD_HOST = 'localhost' SPAMD_PORT = None if hasattr(mm_cfg, 'SPAMASSASSIN_HOST): SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST try: SPAMD_HOST, SPAMD_PORT = string.split(SPAMD_HOST, ':', 1) SPAMD_PORT = int(SPAMD_PORT) except ValueError: SPAMD_PORT = None if not SPAMD_PORT: SPAMD_PORT = 783 This gets rid of the "bare except"s, and I think it's a little clearer than the previous code. The ValueError will be tripped if the string doesn't have a : in it, or if the int coercion fails. Though perhaps in that instance you'd want to log an error or something... Sean ---------------------------------------------------------------------- Comment By: dann frazier (dannf) Date: 2002-08-18 02:11 Message: Logged In: YES user_id=146718 hey James, found a typo. also wanted to point out: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=139942&repeatmerged=yes --- SpamAssassin.py.orig Sat Aug 17 12:05:41 2002 +++ SpamAssassin.py Sat Aug 17 12:06:13 2002 @@ -35,7 +35,7 @@ SPAMD_HOST = mm_cfg.SPAMASSASSIN_HOST i = string.find(SPAMD_HOST, ':') if i >= 0: - SPAMD_HOST, SPAMD_PORT = SPAMD_HOST[:i], host[i+1:] + SPAMD_HOST, SPAMD_PORT = SPAMD_HOST[:i], SPAMD_HOST[i+1:] try: SPAMD_PORT = int(SPAMD_PORT) except: SPAMD_PORT = None except: ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-25 17:00 Message: Logged In: YES user_id=146903 remembering to check the "upload file" checkbox this time ... ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-25 16:59 Message: Logged In: YES user_id=146903 Yet another new version that fixes a small typo. With previous messages, you couldn't approve messages that had been identified as spam once (they would get identified again when the queue got processed, instead of passing the message through). ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-10 08:19 Message: Logged In: YES user_id=146903 The Mailman installation on mail.gnome.org also uses this filter. I don't think there are any stability problems with the filter. ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-07-10 05:16 Message: Logged In: YES user_id=81797 FYI, I ran the previous version since installation and it seemed to work fine. I didn't run into any problems, with probably 500 messages handled. I've updated to the new version and it seems ok so far, but I've only sent about 10 messages through. Sean ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-07-03 12:02 Message: Logged In: YES user_id=146903 Yet another version. There were some bugs in handling of certain error conditions when talking to spamd. These would result in exceptions and the messages staying in the delivery queue :( With the new version, the message will be passed through unchecked under these conditions, and a message will be added to the error log. ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2002-06-13 05:48 Message: Logged In: YES user_id=81797 FYI: I've been running the 2002-05-14 version of this patch with spamassassin 2.20 for the last day on our main mailman box and it seems to be working great. ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-05-14 14:04 Message: Logged In: YES user_id=146903 This version is essentially the same as the previous version, but adds compatibility with python > 1.5.2, which doesn't like you passing two arguments to socket.connect(). ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-04-27 14:17 Message: Logged In: YES user_id=146903 Just attached my updated version of the patch. This version requires SpamAssassin 2.20 (for the extra commands that the spamd daemon understands). It now displays a list of which rules were triggered for held messages, and can give messages from list members a bonus (defaults to 2), so that they are less likely to get held as spam. ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2002-03-26 09:21 Message: Logged In: YES user_id=146903 There is a fairly easy optimisation for this filter that I missed when writing it. It calls str() on the message object twice. It would be quicker to call str() on the message once. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=534577&group_i…

1 0