Mailman 3 March 2003 - Mailman-coders

[ mailman-Bugs-658261 ] transcheck error for double %
by SourceForge.net 17 Mar '03

17 Mar '03

Bugs item #658261, was opened at 2002-12-24 12:29 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=658261&group_i… Category: command line scripts Group: 2.1 (stable) >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Simone Piunno (pioppo) Assigned to: Simone Piunno (pioppo) Summary: transcheck error for double % Initial Comment: As reported by Daniel Buchmann, transcheck doesn't detect correctly when a literal % is expressed as a double %, e.g. %%(<variabelnavn>)s is detected a variable reference to interpolate insted of a simple text. The fix would require a much more complex parser, which is not worth it now but could be in 2.2. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-03-16 23:41 Message: Logged In: YES user_id=12800 Applied, thanks ---------------------------------------------------------------------- Comment By: Simone Piunno (pioppo) Date: 2003-03-16 14:15 Message: Logged In: YES user_id=227443 here is a small solution to the problem.... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=658261&group_i…

1 0

[ mailman-Bugs-704661 ] extra html opening and closing tags
by SourceForge.net 16 Mar '03

16 Mar '03

Bugs item #704661, was opened at 2003-03-16 16:35 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=704661&group_i… Category: configuring/installing Group: 2.0.x Status: Open Resolution: None Priority: 5 Submitted By: Carl C. Longnecker (longneck) Assigned to: Nobody/Anonymous (nobody) Summary: extra html opening and closing tags Initial Comment: mailman 2.0.13 i customized all of the public HTML pages using the mailman administration interface. they all look OK, except for the "Changing user options results page". check out this page: http://www.tampabaytot.org/mailman/listinfo/theology-on- tap_tampabaytot.org try and unsubscribe squeak(a)no.way with any password. when you get to the results page, it's white (should be yellow). if you look at the source, you'll notice there are two sets of html, body, head, etc. tags. They are not in the configuration page, so mailman must be adding them. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=704661&group_i…

1 0

[ mailman-Bugs-658261 ] transcheck error for double %
by SourceForge.net 16 Mar '03

16 Mar '03

Bugs item #658261, was opened at 2002-12-24 18:29 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=658261&group_i… Category: command line scripts Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Simone Piunno (pioppo) Assigned to: Simone Piunno (pioppo) Summary: transcheck error for double % Initial Comment: As reported by Daniel Buchmann, transcheck doesn't detect correctly when a literal % is expressed as a double %, e.g. %%(<variabelnavn>)s is detected a variable reference to interpolate insted of a simple text. The fix would require a much more complex parser, which is not worth it now but could be in 2.2. ---------------------------------------------------------------------- >Comment By: Simone Piunno (pioppo) Date: 2003-03-16 20:15 Message: Logged In: YES user_id=227443 here is a small solution to the problem.... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=658261&group_i…

1 0

[ mailman-Patches-640518 ] SpamAssassin handler
by SourceForge.net 16 Mar '03

16 Mar '03

Patches item #640518, was opened at 2002-11-19 13:26 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=640518&group_i… Category: list administration Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 5 Submitted By: Jon Parise (jparise) Assigned to: Nobody/Anonymous (nobody) Summary: SpamAssassin handler Initial Comment: I've updated the existing SpamAssassin patch (534577) for Mailman 2.1. ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2003-03-16 17:43 Message: Logged In: YES user_id=146903 If you haven't assigned copyright for your work to the FSF, don't say that your code is copyrighted by the FSF. Doing so could cause problems in the event of a lawsuit. Accurate copyright notices are essential. In answer to filfil's question, the code requires that spamd is running. However, if it can't contact spamd for some reason, the message will pass this filter, so that mail doesn't get lost. ---------------------------------------------------------------------- Comment By: Fil (filfil) Date: 2003-03-14 05:04 Message: Logged In: YES user_id=243444 Is it possible to modify that code so that it calls the classic spamassassin if the spamd daemon is not running? (Or is it already functioning this way?) ---------------------------------------------------------------------- Comment By: Sean Reifschneider (jafo) Date: 2003-02-07 15:23 Message: Logged In: YES user_id=81797 I can't get this code to work with Mailman 2.1. A message that triggers the hold for moderator starts bouncing messages from the list owner and just sits in a mail loop until I remove SpamAssassin from the filter chain, delivering a message for every loop to the admin interface. I spent a couple of hours looking at it, but I can't see why it is doing this. It's defeinitely in the Hold.hold_for_whatever, but I don't know why that's failing. Just thought I'd mention it. I guess we'll stay with 2.0 where it's working fine with the other patch-set. Sean ---------------------------------------------------------------------- Comment By: Jon Parise (jparise) Date: 2003-02-03 10:39 Message: Logged In: YES user_id=485579 Yes, use the version with the "footsie" code. I don't appear to have permission to delete the older version from this patch tracker. It doesn't make any special exceptions with regard to the list owner, but I'll have a look at making that part of the logic smarter. ---------------------------------------------------------------------- Comment By: Shamanic Acid (shamanicacid) Date: 2003-01-28 15:18 Message: Logged In: YES user_id=698712 I am a bit confused in which SpamAssassin.py file to use. There does not seem to be an embedded version number in the download links. The diff I see is as follows: $ diff SpamAssassin.1.py SpamAssassin.py 62,65d61 < # First, play footsie with _ so that the following are marked as translated, < # but aren't actually translated until we need the text later on. < def _(s): < return s 71,73d66 < reason = _('SpamAssassin identified this message as spam') < rejection = _('You message was identified as spam.') < 78,80d70 < reason = _('SpamAssassin identified this message as spam') < rejection = _('You message was identified as spam.') < Question # 1. Do I want to use the SpamAssassin.py file with the "footsie" code? Question # 2. Does the SpamAssassin.py code allow for exceptions when the e-mail is from the $list-owner ( bounces to moderator ) ? I ask because I ran into a problem with a mailer-loop occuring when SpamAssassin errantly tagged the $list-owner moderator bounces as spam. ( spamassasin marks pending e-mails from $list-owner with score 7.6 ) I have not read through all the code, I am curious if mlist.isMember(sender) includes the owner alias? Many Thanks in Advance ---------------------------------------------------------------------- Comment By: Jon Parise (jparise) Date: 2003-01-13 00:01 Message: Logged In: YES user_id=485579 I've updated the SpamAssassin handler to report a more detailed reason when a DiscardMessage and HoldMessage exception is raised. ---------------------------------------------------------------------- Comment By: Jon Parise (jparise) Date: 2003-01-01 08:33 Message: Logged In: YES user_id=485579 The attached patch adds the SpamAssassin handler to Mailman's mail processing pipelines. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2002-11-28 00:13 Message: Logged In: YES user_id=12800 I'm only moving this to the MM2.2/3.0 group so I can concentrate on patches for 2.1. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=640518&group_i…

1 0

[ mailman-Bugs-703941 ] Invited user can subscribe to any list (inc private lists)
by SourceForge.net 16 Mar '03

16 Mar '03

Bugs item #703941, was opened at 2003-03-14 20:03 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=703941&group_i… Category: security/privacy Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 8 Submitted By: Stuart Bishop (zenzen) Assigned to: Nobody/Anonymous (nobody) Summary: Invited user can subscribe to any list (inc private lists) Initial Comment: Currently, the Pending queue maintains no reference to what mailing list a subscription request is for. This is encoded in the URL, and isn't a security problem for subscriptions. However, Invitations are a special sort of subscription that bypasses the subscription approval step if the user accepts the invitation. So if a user munges the URL they are sent from http://wherever/invited_list/123cookie to http://whereever/private_list/123cookie, and goes to that link, they are subscribed to the private list with no notification to anyone. Simple solution may be to set userdesc.invited to the listname rather than just '1', and then when checking for the invited flag make sure that someone is hacking the system. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-03-16 02:09 Message: Logged In: YES user_id=12800 Fixed! ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-03-15 09:56 Message: Logged In: YES user_id=12800 Raising the priority so this must be fixed for 2.1.2 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=703941&group_i…

1 0

[ mailman-Patches-665569 ] make Postfix bounce detection work with newer postfix
by SourceForge.net 16 Mar '03

16 Mar '03

Patches item #665569, was opened at 2003-01-10 17:33 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=665569&group_i… Category: bounce processing Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: James Henstridge (jhenstridge) Assigned to: Nobody/Anonymous (nobody) Summary: make Postfix bounce detection work with newer postfix Initial Comment: Mailman does not recognise bounce messages from newer versions of Postfix. The content-type header on bounce messages looks like this: Content-Type: multipart/report; report-type=delivery-status; boundary="2892E4C0CF.1042189077/quoll.daa.com.au" Mailman only looks for bounce messages with type multipart/mixed, so skips them. The simple solution is to check for both content types (which should allow mailman to continue to work with old postfixes. The attached patch is against 2.0.x (haven't upgraded to MM2.1 yet), but the code is almost identical for 2.1 so the patch should be easy to apply. ---------------------------------------------------------------------- >Comment By: James Henstridge (jhenstridge) Date: 2003-03-16 10:57 Message: Logged In: YES user_id=146903 Not sure if this code is applicable to MM2.1. I guess the generic DSN bounce detection handles it. If there is another MM2.0.x bug fix release, it may be nice to apply. ---------------------------------------------------------------------- Comment By: James Henstridge (jhenstridge) Date: 2003-01-10 17:36 Message: Logged In: YES user_id=146903 Hmm. It seems to have lost the attachment ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=665569&group_i…

1 0

[ mailman-Patches-670167 ] fix i18n attachment description in archive
by SourceForge.net 15 Mar '03

15 Mar '03

Patches item #670167, was opened at 2003-01-18 05:58 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i… Category: Pipermail Group: Mailman 2.1 Status: Open Resolution: Accepted >Priority: 7 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: fix i18n attachment description in archive Initial Comment: Bug-ID 669081 (Major attachment handling bug!) is caused inaccurate handling of charset in Scrubber.py. This is caused by misuse of email functions (or by bug in email package). In Scrubber.py, attempt is made to get message charset by part.get_charset() but it returns only None, as far as I experimented. In this patch, message charset is extracted from regular expression pattern in content-type header. This also set the charset of internally crafted message part. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-24 04:34 Message: Logged In: YES user_id=67709 Uploading revised patch to fix more error. Sorry for the people downloaded earlier. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-24 01:39 Message: Logged In: YES user_id=67709 update my patch to fix error reported by sumeet File "/list/Mailman/Handlers/Scrubber.py", line 320, in process if not t.endswith('\n'): AttributeError: 'NoneType' object has no attribute 'endswith' ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-22 07:05 Message: Logged In: YES user_id=67709 This patch for Scrubber.py now include Bug-ID #691039. save_attachment() now returns (url, size), because in previous code, get_paylaod() is called before calling save_attachment() only to get the size. save_attachment() calls get_payload() inside. We might be able to discard the attachment if get_payload(decode=1) fail. (TBD: return discard message and size 0 ?) ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-20 01:31 Message: Logged In: YES user_id=67709 Increment priority because this is now a bug fix. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-04 06:08 Message: Logged In: YES user_id=67709 I made a new patch to fix embedded multipart messages are stripped bug. this patch is for CVS. see http://mail.python.org/pipermail/mailman-users/2003-February/026071.html ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 05:13 Message: Logged In: YES user_id=12800 Reopening so this issue doesn't get lost. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-20 04:03 Message: Logged In: YES user_id=67709 We, Japanese, need additional process of stringify and regenerate message instance.. Internal message is in 'euc-jp' but return value of get_content_charset() becomes 'iso-2022-jp' even though the get_payload() returns euc-jp text. The message and part body is converted to iso-2022-jp when it is output to SMTP (or whatever accepts in string format). ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-01-20 02:18 Message: Logged In: YES user_id=12800 Accepted, with changes. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-01-19 00:52 Message: Logged In: YES user_id=67709 Update of patch. Please backout the first one if you have already applied. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=670167&group_i…

1 0

[ mailman-Bugs-703941 ] Invited user can subscribe to any list (inc private lists)
by SourceForge.net 15 Mar '03

15 Mar '03

Bugs item #703941, was opened at 2003-03-14 20:03 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=703941&group_i… Category: security/privacy Group: 2.1 (stable) Status: Open Resolution: None >Priority: 8 Submitted By: Stuart Bishop (zenzen) Assigned to: Nobody/Anonymous (nobody) Summary: Invited user can subscribe to any list (inc private lists) Initial Comment: Currently, the Pending queue maintains no reference to what mailing list a subscription request is for. This is encoded in the URL, and isn't a security problem for subscriptions. However, Invitations are a special sort of subscription that bypasses the subscription approval step if the user accepts the invitation. So if a user munges the URL they are sent from http://wherever/invited_list/123cookie to http://whereever/private_list/123cookie, and goes to that link, they are subscribed to the private list with no notification to anyone. Simple solution may be to set userdesc.invited to the listname rather than just '1', and then when checking for the invited flag make sure that someone is hacking the system. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-03-15 09:56 Message: Logged In: YES user_id=12800 Raising the priority so this must be fixed for 2.1.2 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=703941&group_i…

1 0

[ mailman-Bugs-703941 ] Invited user can subscribe to any list (inc private lists)
by SourceForge.net 15 Mar '03

15 Mar '03

Bugs item #703941, was opened at 2003-03-15 12:03 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=703941&group_i… Category: security/privacy Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Stuart Bishop (zenzen) Assigned to: Nobody/Anonymous (nobody) Summary: Invited user can subscribe to any list (inc private lists) Initial Comment: Currently, the Pending queue maintains no reference to what mailing list a subscription request is for. This is encoded in the URL, and isn't a security problem for subscriptions. However, Invitations are a special sort of subscription that bypasses the subscription approval step if the user accepts the invitation. So if a user munges the URL they are sent from http://wherever/invited_list/123cookie to http://whereever/private_list/123cookie, and goes to that link, they are subscribed to the private list with no notification to anyone. Simple solution may be to set userdesc.invited to the listname rather than just '1', and then when checking for the invited flag make sure that someone is hacking the system. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=703941&group_i…

1 0

[ mailman-Bugs-695526 ] check_perms does not read mm_cfg.py
by SourceForge.net 14 Mar '03

14 Mar '03

Bugs item #695526, was opened at 2003-03-01 04:34 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=695526&group_i… Category: command line scripts Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Luigi Rosa (lrosa) Assigned to: Nobody/Anonymous (nobody) Summary: check_perms does not read mm_cfg.py Initial Comment: I modified the logs path in mm_cfg.py inserting the line LOG_DIR = '/var/log/mailman' and I verified that Mailman was logging in that directory After that, I run check_perms -v and I noticed that the script still verifies /usr/local/mailman/logs, but doesn't verify /var/log/mailman ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-03-14 00:31 Message: Logged In: YES user_id=12800 Fixed specifically to follow mm_cfg.LOG_DIR ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=695526&group_i…

1 0