Mailman 3 May 2003 - Mailman-coders

[ mailman-Bugs-740453 ] encoding problems (1/3)
by SourceForge.net 20 May '03

20 May '03

Bugs item #740453, was opened at 2003-05-20 15:32 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=740453&group_i… Category: mail delivery Group: 2.1 beta Status: Open Resolution: None Priority: 5 Submitted By: Fil (filfil) Assigned to: Nobody/Anonymous (nobody) Summary: encoding problems (1/3) Initial Comment: May 20 11:47:10 2003 (8944) Uncaught runner exception: ASCII decoding error: or May 20 11:47:10 2003 (8944) Traceback (most recent call last): File "/usr/local/mailman/Mailman/Queue/Runner.py", line 110, in _oneloop self._onefile(msg, msgdata) File "/usr/local/mailman/Mailman/Queue/Runner.py", line 160, in _onefile keepqueued = self._dispose(mlist, msg, msgdata) File "/usr/local/mailman/Mailman/Queue/CommandRunner.py", line 218, in _dispo res = Results(mlist, msg, msgdata) File "/usr/local/mailman/Mailman/Queue/CommandRunner.py", line 75, in __init_ subj = make_header(decode_header(subj)).__unicode__() File "/usr/local/mailman/pythonlib/email/Header.py", line 144, in make_header h.append(s, charset) File "/usr/local/mailman/pythonlib/email/Header.py", line 272, in append ustr = unicode(s, incodec, errors) UnicodeError: ASCII decoding error: ordinal not in range(128) May 20 11:47:10 2003 (8944) SHUNTING: 1052919608.508467+145b45eb26201772a1a52c3 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=740453&group_i…

1 0

[ mailman-Patches-601117 ] add sequencial number in subject prefix
by SourceForge.net 18 May '03

18 May '03

Patches item #601117, was opened at 2002-08-28 05:07 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=601117&group_i… Category: mail delivery Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 7 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: add sequencial number in subject prefix Initial Comment: This patch for 'CookHeaders.py' add an ability to add a sequencial number in the subject prefix. You can define a subject prefix like: [listname %d] Then, the subject line of delivered mail becomes: Subject: [listname 123] Hoge hoge When someone replied this mail, mailman receives a messages with: Subject: Re: [listname 123] Hoge hoge Then, this patch removes [listname \d+] part and deliver it with: Subject: [listname 124] Re: Hoge hoge And next, another person replies with Subject: Re: [listname 124] Re: Hoge hoge Then, (magically!) you get: Subject: [listname 125] Re: Hoge hoge Not with Re: Re: Hoge hoge. Looks like complicated but this patch has been working well with Japanese-enhanced Mailman for more than a year. Without %d, this patch works like current version, I believe. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-05-18 02:01 Message: Logged In: YES user_id=67709 Here is update of my patch for 2.1.2 ---------------------------------------------------------------------- Comment By: Mitchell Marks (jojoba2) Date: 2003-05-17 17:42 Message: Logged In: YES user_id=718482 Is there a version vor MM 2.1.2? I'm trying the older one but doesn't seem to work. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-27 05:33 Message: Logged In: YES user_id=67709 sorry for daily update but there was an error in i18n handling of '(no subject)' ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-26 01:25 Message: Logged In: YES user_id=67709 update of patch for 2.1.1 if the subject is all ascii, then cat the prefix and subject before it is instantiated. Hope to solve prefix only subject 1st line. Note: with this patch without $d, Re: [prefix] is now mungled to [prefix] Re:. This is useful if someone post new issue as follow up to old subject like; New subject bah bah was Re: [prefix] foo ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-14 11:33 Message: Logged In: YES user_id=67709 Hi, I am pleased you like this patch. Here is my current version attached. ---------------------------------------------------------------------- Comment By: Fabio Rossetti (fabiorossetti) Date: 2003-02-14 10:02 Message: Logged In: YES user_id=693899 If you need a quick fix to make the patch work with 2.1.1 here's my take (it's the diff file adapted to work with 2.1.1 CookHeaders.py) 17a18 > (sequence version) 221c222,223 < prefix = mlist.subject_prefix --- > prefix = mlist.subject_prefix.strip(); > if not prefix: return 237,243c239,250 < if prefix and subject: < pattern = re.escape(prefix.strip()) < for decodedsubj, charset in headerbits: < if re.search(pattern, decodedsubj, re.IGNORECASE): < # The subject's already got the prefix, so don't change it < return < del msg['subject'] --- > headerstring = '' > fws = '' > cset = None > for (s, c) in headerbits: > headerstring += fws + s > if c == None or c == 'us-ascii': > fws = ' ' > cset = Utils.GetCharSet(mlist.preferred_language) > else: > fws = '' > cset = c > # Note: searching prefix in subject is REMOVED. (seq version) 245a253,275 > else: > subject = headerstring > # If the subject_prefix contains '%d', it is replaced with the > # mailing list sequential number. Also, if the prefix is closed with > # [],(), or {}, the prefix in the responding post subject will be cared. > # sequential number format allows '%05d' like pattern. > p = re.compile('%\d*d') > if p.search(prefix,1): > # prefix have number, so we should search prefix w/number > # in subject. > prefix_pattern = p.sub(r'\s*\d+\s*', prefix) > else: > prefix_pattern = prefix > prefix_pattern = re.sub('([\[\(\{])', '\\\g<1>', prefix_pattern) > subject = re.sub(prefix_pattern, '', subject) > subject = re.compile('(RE:\s*)+', re.I).sub('Re: ', subject, 1) > # and substitute %d in prefix with post_id > try: > prefix = prefix % mlist.post_id > except: > pass > # Note that trailing space was stripped in seq version (TK) > prefix += ' ' 248,262c278,288 < for s, c in headerbits: < # Once again, convert the string to unicode. < if c is None: < c = Charset('iso-8859-1') < if not isinstance(c, Charset): < c = Charset(c) < if not _isunicode(s): < codec = c.input_codec or 'ascii' < try: < s = unicode(s, codec, 'replace') < except LookupError: < # Unknown codec, is this default reasonable? < s = unicode(s, Utils.GetCharSet (mlist.preferred_language), < 'replace') < h.append(s, c) --- > # in seq version, subject header is already concatnated > if not _isunicode(subject): > try: > subject = unicode(subject, cset, 'replace') > except LookupError: > # unknown codec > cset = Utils.GetCharSet(mlist.preferred_language) > subject = unicode(subject, cset, 'replace') > subject = subject.encode(cset) > h.append(subject, cset) > del msg['subject'] ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-12-20 04:31 Message: Logged In: YES user_id=67709 update for 2.1b6+ ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-10-31 05:59 Message: Logged In: YES user_id=67709 I have uploaded the patch with the same name as the old one. Please download the upper one because it's newer. Sorry for the inconvenience. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-10-31 05:53 Message: Logged In: YES user_id=67709 Patch ID 625482 (i18n List-Id) and this was merged for 2.1b4+ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=601117&group_i…

1 0

[ mailman-Patches-601117 ] add sequencial number in subject prefix
by SourceForge.net 17 May '03

17 May '03

Patches item #601117, was opened at 2002-08-28 00:07 Message generated for change (Comment added) made by jojoba2 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=601117&group_i… Category: mail delivery Group: Mailman 2.2 / 3.0 Status: Open Resolution: None Priority: 7 Submitted By: Tokio Kikuchi (tkikuchi) Assigned to: Nobody/Anonymous (nobody) Summary: add sequencial number in subject prefix Initial Comment: This patch for 'CookHeaders.py' add an ability to add a sequencial number in the subject prefix. You can define a subject prefix like: [listname %d] Then, the subject line of delivered mail becomes: Subject: [listname 123] Hoge hoge When someone replied this mail, mailman receives a messages with: Subject: Re: [listname 123] Hoge hoge Then, this patch removes [listname \d+] part and deliver it with: Subject: [listname 124] Re: Hoge hoge And next, another person replies with Subject: Re: [listname 124] Re: Hoge hoge Then, (magically!) you get: Subject: [listname 125] Re: Hoge hoge Not with Re: Re: Hoge hoge. Looks like complicated but this patch has been working well with Japanese-enhanced Mailman for more than a year. Without %d, this patch works like current version, I believe. ---------------------------------------------------------------------- Comment By: Mitchell Marks (jojoba2) Date: 2003-05-17 12:42 Message: Logged In: YES user_id=718482 Is there a version vor MM 2.1.2? I'm trying the older one but doesn't seem to work. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-26 23:33 Message: Logged In: YES user_id=67709 sorry for daily update but there was an error in i18n handling of '(no subject)' ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-25 19:25 Message: Logged In: YES user_id=67709 update of patch for 2.1.1 if the subject is all ascii, then cat the prefix and subject before it is instantiated. Hope to solve prefix only subject 1st line. Note: with this patch without $d, Re: [prefix] is now mungled to [prefix] Re:. This is useful if someone post new issue as follow up to old subject like; New subject bah bah was Re: [prefix] foo ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2003-02-14 05:33 Message: Logged In: YES user_id=67709 Hi, I am pleased you like this patch. Here is my current version attached. ---------------------------------------------------------------------- Comment By: Fabio Rossetti (fabiorossetti) Date: 2003-02-14 04:02 Message: Logged In: YES user_id=693899 If you need a quick fix to make the patch work with 2.1.1 here's my take (it's the diff file adapted to work with 2.1.1 CookHeaders.py) 17a18 > (sequence version) 221c222,223 < prefix = mlist.subject_prefix --- > prefix = mlist.subject_prefix.strip(); > if not prefix: return 237,243c239,250 < if prefix and subject: < pattern = re.escape(prefix.strip()) < for decodedsubj, charset in headerbits: < if re.search(pattern, decodedsubj, re.IGNORECASE): < # The subject's already got the prefix, so don't change it < return < del msg['subject'] --- > headerstring = '' > fws = '' > cset = None > for (s, c) in headerbits: > headerstring += fws + s > if c == None or c == 'us-ascii': > fws = ' ' > cset = Utils.GetCharSet(mlist.preferred_language) > else: > fws = '' > cset = c > # Note: searching prefix in subject is REMOVED. (seq version) 245a253,275 > else: > subject = headerstring > # If the subject_prefix contains '%d', it is replaced with the > # mailing list sequential number. Also, if the prefix is closed with > # [],(), or {}, the prefix in the responding post subject will be cared. > # sequential number format allows '%05d' like pattern. > p = re.compile('%\d*d') > if p.search(prefix,1): > # prefix have number, so we should search prefix w/number > # in subject. > prefix_pattern = p.sub(r'\s*\d+\s*', prefix) > else: > prefix_pattern = prefix > prefix_pattern = re.sub('([\[\(\{])', '\\\g<1>', prefix_pattern) > subject = re.sub(prefix_pattern, '', subject) > subject = re.compile('(RE:\s*)+', re.I).sub('Re: ', subject, 1) > # and substitute %d in prefix with post_id > try: > prefix = prefix % mlist.post_id > except: > pass > # Note that trailing space was stripped in seq version (TK) > prefix += ' ' 248,262c278,288 < for s, c in headerbits: < # Once again, convert the string to unicode. < if c is None: < c = Charset('iso-8859-1') < if not isinstance(c, Charset): < c = Charset(c) < if not _isunicode(s): < codec = c.input_codec or 'ascii' < try: < s = unicode(s, codec, 'replace') < except LookupError: < # Unknown codec, is this default reasonable? < s = unicode(s, Utils.GetCharSet (mlist.preferred_language), < 'replace') < h.append(s, c) --- > # in seq version, subject header is already concatnated > if not _isunicode(subject): > try: > subject = unicode(subject, cset, 'replace') > except LookupError: > # unknown codec > cset = Utils.GetCharSet(mlist.preferred_language) > subject = unicode(subject, cset, 'replace') > subject = subject.encode(cset) > h.append(subject, cset) > del msg['subject'] ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-12-19 22:31 Message: Logged In: YES user_id=67709 update for 2.1b6+ ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-10-30 23:59 Message: Logged In: YES user_id=67709 I have uploaded the patch with the same name as the old one. Please download the upper one because it's newer. Sorry for the inconvenience. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2002-10-30 23:53 Message: Logged In: YES user_id=67709 Patch ID 625482 (i18n List-Id) and this was merged for 2.1b4+ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=601117&group_i…

1 0

[ mailman-Bugs-728847 ] 2.1.2 Messages.Py
by SourceForge.net 16 May '03

16 May '03

Bugs item #728847, was opened at 2003-04-28 07:25 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=728847&group_i… Category: command line scripts Group: 2.1 (stable) >Status: Closed >Resolution: Invalid Priority: 5 Submitted By: David English (engush) Assigned to: Nobody/Anonymous (nobody) Summary: 2.1.2 Messages.Py Initial Comment: Fix: Edit line 205 of Messages.py add ) and remove line 206 "errors='replace')" otherwise the following error occurs when creating a new list: lostris:/usr/local/mailman/bin# ./newlist test Enter the email of the person running the list: blah(a)blah.org Initial test password: To finish creating your mailing list, you must edit your /etc/aliases (or equivalent) file by adding the following lines, and possibly running the `newaliases' program: ## test mailing list test: "|/usr/local/mailman/mail/mailman post test" test-admin: "|/usr/local/mailman/mail/mailman admin test" test-bounces: "|/usr/local/mailman/mail/mailman bounces test" test-confirm: "|/usr/local/mailman/mail/mailman confirm test" test-join: "|/usr/local/mailman/mail/mailman join test" test-leave: "|/usr/local/mailman/mail/mailman leave test" test-owner: "|/usr/local/mailman/mail/mailman owner test" test-request: "|/usr/local/mailman/mail/mailman request test" test-subscribe: "|/usr/local/mailman/mail/mailman subscribe test" test-unsubscribe: "|/usr/local/mailman/mail/mailman unsubscribe test" Hit enter to notify test owner... Traceback (most recent call last): File "./newlist", line 219, in ? main() File "./newlist", line 211, in main text, mlist.preferred_language) File "/usr/local/mailman/Mailman/Message.py", line 206, in __init__ errors='replace') TypeError: __init__() got an unexpected keyword argument 'errors' lostris:/usr/local/mailman/bin# ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-05-16 17:59 Message: Logged In: YES user_id=12800 Something's wrong with your installation -- perhaps you only partially updated? Mailman 2.1.2 should come with email 2.5.2 and its Header class __init__() does indeed take an errors argument. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=728847&group_i…

1 0

[ mailman-Patches-688410 ] better phrasing for listinfo page
by SourceForge.net 15 May '03

15 May '03

Patches item #688410, was opened at 2003-02-17 22:11 Message generated for change (Settings changed) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=688410&group_i… Category: Web UI Group: Mailman 2.1 >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Martin Pool (mbp) Assigned to: Nobody/Anonymous (nobody) Summary: better phrasing for listinfo page Initial Comment: The default listinfo page says "please send questions or comments to foo-owner(a)bar.org". The problem with this is that people repeatedly think "oh, I'll send my Samba question to the mail administrator, rather than to the mailing list." This patch attempts to make it more clear that the administrator address is for problems with the lists themselves. It has dropped the number of misdirected mails on our high-traffic site from a couple per week to almost zero. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-05-13 21:36 Message: Logged In: YES user_id=521 Please apply this. We continue to get people who misunderstand this text and send random questions to the postmaster. Yes, those people are pretty dumb (or more charitably, not good with English.) But it would be nice to make a simple change that avoided the problem. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-03-10 20:14 Message: Logged In: YES user_id=521 Here's the patch. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-03-10 19:38 Message: Logged In: YES user_id=521 Oops, I'll post it. ---------------------------------------------------------------------- Comment By: Thomas Wouters (twouters) Date: 2003-03-10 08:57 Message: Logged In: YES user_id=34209 There's no attached patch. Are you sure you clicked the 'Check to Ipload and Attach File' box ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=688410&group_i…

1 0

[ mailman-Patches-688410 ] better phrasing for listinfo page
by SourceForge.net 14 May '03

14 May '03

Patches item #688410, was opened at 2003-02-18 14:11 Message generated for change (Comment added) made by mbp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=688410&group_i… Category: Web UI Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Martin Pool (mbp) Assigned to: Nobody/Anonymous (nobody) Summary: better phrasing for listinfo page Initial Comment: The default listinfo page says "please send questions or comments to foo-owner(a)bar.org". The problem with this is that people repeatedly think "oh, I'll send my Samba question to the mail administrator, rather than to the mailing list." This patch attempts to make it more clear that the administrator address is for problems with the lists themselves. It has dropped the number of misdirected mails on our high-traffic site from a couple per week to almost zero. ---------------------------------------------------------------------- >Comment By: Martin Pool (mbp) Date: 2003-05-14 11:36 Message: Logged In: YES user_id=521 Please apply this. We continue to get people who misunderstand this text and send random questions to the postmaster. Yes, those people are pretty dumb (or more charitably, not good with English.) But it would be nice to make a simple change that avoided the problem. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-03-11 12:14 Message: Logged In: YES user_id=521 Here's the patch. ---------------------------------------------------------------------- Comment By: Martin Pool (mbp) Date: 2003-03-11 11:38 Message: Logged In: YES user_id=521 Oops, I'll post it. ---------------------------------------------------------------------- Comment By: Thomas Wouters (twouters) Date: 2003-03-11 00:57 Message: Logged In: YES user_id=34209 There's no attached patch. Are you sure you clicked the 'Check to Ipload and Attach File' box ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=688410&group_i…

1 0

[ mailman-Feature Requests-736895 ] temporary members, delivery disable on cc
by SourceForge.net 13 May '03

13 May '03

Feature Requests item #736895, was opened at 2003-05-13 16:04 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=350103&aid=736895&group_i… Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Pabs (pabs3) Assigned to: Nobody/Anonymous (nobody) Summary: temporary members, delivery disable on cc Initial Comment: when lists are open to non-members - either through admin approval, orfully open it would be nice if mailman could then deliver the rest of the thread initiated by that non-member to that non-member. this would need some kind of password for the non-member to turn off delivery, and a way for admins to also do this. related to this would be the ability to turn off delivery to email addresses that are listed as bcc/cc/to on arrival, this would prevent people from recieving duplicate posts, especially usefull for people who are used to the old behaviour of mailman (no temp members), who cc by habit ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=350103&aid=736895&group_i…

1 0

[ mailman-Bugs-736559 ] Subject wrap with tab character
by SourceForge.net 12 May '03

12 May '03

Bugs item #736559, was opened at 2003-05-12 17:05 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=736559&group_i… Category: mail delivery Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Swen Haubold (swen_haubold) Assigned to: Nobody/Anonymous (nobody) Summary: Subject wrap with tab character Initial Comment: Mailman: 2.1.2 The subject line is wrapped by a tab character, if the line contains more than 78 characters. In this case a space is replaced by an tab character. This behaviour gives trouble with some e-mail client and is also not handled by MHonArc correctly. In an e-mail client a long space is shown or a special character. MHonArc simply removes the tab character therefore two words are combined, e.g. the tab is inserted between the two word "and" and "delivery"; in the archive the subject contains the new word "anddelivery" ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=736559&group_i…

1 0

[ mailman-Bugs-730769 ] template access hierarchy is broken
by SourceForge.net 12 May '03

12 May '03

Bugs item #730769, was opened at 2003-05-01 09:24 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=730769&group_i… Category: Pipermail Group: 2.1 (stable) >Status: Closed >Resolution: Accepted Priority: 8 Submitted By: Richard Barrett (ppsys) Assigned to: Nobody/Anonymous (nobody) Summary: template access hierarchy is broken Initial Comment: The quick_maketext()function in HyperArch.py uses a caching scheme for templates extracted from one of the four possible sources of templates, i.e. general, site, domain and list specific templates. The caching scheme is broken because the key to the cache only uses the name of the template file and the language. Thus once a a file for a given langauge has been cached, regardless of which of the sources it was obtained from, it is that template that is used by all lists, regardless of the existence of a template in a preferred source for that particular list. The attached patch fixes this problem. Apply the patch with the MM build directory as current working directory using the command: patch -p1 < path-to-patch-file ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-05-12 11:20 Message: Logged In: YES user_id=12800 Accepted, with minor stylistic modifications. Thanks! ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-05-12 10:11 Message: Logged In: YES user_id=75166 My first reaction to fixing the problem was as bwarsaw suggests, just add the list name to the cache key. On consideration I decided the use of a two level cache is a justified and trivial complication. The top level cache maps (filename, lang, listname) -> filepath, potentially a many -> one mapping. The second level cache maps filepath -> filecontent, always a one -> one mapping. A single level cache would map (filename, lang, listname) -> filecontent, always a one -> one mapping, which would lead to multiple copies of the same template file content data being held in memory when multiple lists use the same template; arguably the norm on Mailman installations. Take my case of 460 lists using the same default English language templates. This waste of storage is trivially avoidable with the second cache dictionary. I have updated the patch to tcache-2.1.2-0.3.patch, which introduces the change in function name from Utils.real_maketext to Utils.findtext and propagates that change as necessary. Footnotes: The approach adopted is safe as HyperArch.quick_maketext () always calls Utils.findtext() with dict=None so that Utils.findtext() does no characterisation of the template content; this being deferred until HyperArch.quick_maketext() acts on the cache content. When multiple lists use the same template file, its contents will be re-acquired the first time each list first seeks to use it. This latter is a relatively minor inefficency which I thought preferable to more radical changes in the original Utils.maketext function to separate the path determination and file content acquisition aspects of its behaviour into different functions. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-05-12 00:08 Message: Logged In: YES user_id=12800 Do we need two caches? Isn't the important point here that the listname be included in the cache key? If so, maybe we just need one cache that maps (templatefile, lang, listname) to the template text. If you agree, please rework the patch accordingly. Also, rename Utils.real_maketext() to Utils.findtext() and change call sites accordingly. ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-05-01 11:09 Message: Logged In: YES user_id=75166 After doing some furehtr (proper) testing I hope version 2 of the patch will solve the problem ---------------------------------------------------------------------- Comment By: Richard Barrett (ppsys) Date: 2003-05-01 10:00 Message: Logged In: YES user_id=75166 And do not forget to mailmanctl restart after applying the patch! ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=730769&group_i…

1 0

[ mailman-Feature Requests-730814 ] HTML stripped regardless of filters
by SourceForge.net 12 May '03

12 May '03

Feature Requests item #730814, was opened at 2003-05-01 11:18 Message generated for change (Comment added) made by bwarsaw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=350103&aid=730814&group_i… >Category: None >Group: None Status: Open Resolution: None Priority: 5 Submitted By: Charles Hall (hallcp) Assigned to: Nobody/Anonymous (nobody) Summary: HTML stripped regardless of filters Initial Comment: If I enable "content-filtering", HTML is a;ways stripped out regardless of my other filter settings. I have tried to track this down and it appears that MimeDel.py is collapsing ALL multi-part emails to a single component. This leaves the plain text but strips off the HTML flavored portion. If I disable content-filtering, MimeDel is neutralized and HTML email works OK. The suspect function is "collapse_multipart_alternatives". FYI: my test emails were sent from Outlook. I posted and emailed to others on the Users mailing list, but no one responded that they have gotten filtering to work either. This looks like a real nice feature. I hope you guys can fix it. ---------------------------------------------------------------------- >Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-05-12 10:35 Message: Logged In: YES user_id=12800 If you go to the content filtering page in the admin u/i and read the category's descriptive paragraph, you'll see where the m/a collapsing behavior is defined. I'm not sure if you can convert this bug to a feature request, so I'll do it for you! ---------------------------------------------------------------------- Comment By: Charles Hall (hallcp) Date: 2003-05-12 10:11 Message: Logged In: YES user_id=747417 Barry, thanks for the comment. You may be correct. I was sending email with a plain/text and text/html component. If I understand you, this feature was designed to selectively filter "EXE" or "ZIP" attachments, not HTML vs plaintext. Can you point me to the docs on this? And how do I convert this bug to a feature request? Or do I just delete? (Can I?). Thanks again for the info. Charles. ---------------------------------------------------------------------- Comment By: Barry A. Warsaw (bwarsaw) Date: 2003-05-12 00:32 Message: Logged In: YES user_id=12800 When you say "collapsing ALLmulti-part emails to a single component", I think you mean all multipart/alternatives. If so, this is documented behavior. Now, it may not be /desired/ behavior, but that's a different issue. I would move this to feature requests to allow you to configure whether multipart/alternatives are collapsed or not. Please follow up here and let me know if I'm correct or not. If there are other problems with content filtering from mailman-users, please submit bug reports on each indivdiually. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=350103&aid=730814&group_i…

1 0