Mailman 3 October 2004 - Mailman-coders

[ mailman-Patches-995029 ] Patch against Mailman 2.1.5 release fixes bug #913397
by SourceForge.net Oct. 19, 2004

Oct. 19, 2004

Patches item #995029, was opened at 2004-07-21 06:40 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=995029&group_i… Category: list administration Group: Mailman 2.1 >Status: Closed Resolution: None Priority: 5 Submitted By: Eirik Dentz (edentz) Assigned to: Tokio Kikuchi (tkikuchi) Summary: Patch against Mailman 2.1.5 release fixes bug #913397 Initial Comment: Patch against 2.1.5 release to fix bug #913397 <https://sourceforge.net/tracker/index.php? func=detail&aid=913397&group_id=103&atid=100103> This hasn't been tested extensively and it may break other functionality, but it seems to produce the desired result of allowing user to change the case of the localpart of his/her email address when checking the "change globally" option on the options page. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2004-10-19 04:38 Message: Logged In: YES user_id=67709 merged in CVS MailList.py revision: 2.100.2.23 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=995029&group_i…

1 0

[ mailman-Bugs-913397 ] Subscriber E-Mail-Address: GlobalChange causes removal
by SourceForge.net Oct. 19, 2004

Oct. 19, 2004

Bugs item #913397, was opened at 2004-03-10 10:53 Message generated for change (Settings changed) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=913397&group_i… Category: None Group: 2.1 (stable) >Status: Closed Resolution: None Priority: 5 Submitted By: chris-taylor (chris-taylor) Assigned to: Tokio Kikuchi (tkikuchi) Summary: Subscriber E-Mail-Address: GlobalChange causes removal Initial Comment: A subscriber of some mailinglists on my site tried to change his email address globally. The change for one of the lists only affected a correction of upper- and lower-case letters in the local part of the address(e.g. will.smith@... -> Will.Smith@....). After confirming the change an error occured and the subscriber was completely unsubscribed from the list. Neither the old address nor the new address were registered in the subscribers list. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2004-10-19 04:37 Message: Logged In: YES user_id=67709 fixed in MailList.py revision: 2.100.2.23 ---------------------------------------------------------------------- Comment By: Eirik Dentz (edentz) Date: 2004-07-21 06:30 Message: Logged In: YES user_id=878352 Here is a patch against the 2.1.5 Mailman release: --- mailman-2.1.5/Mailman/MailList.py 2004-03-04 06:10:28.000000000 -0800 +++ mailman-2.1.5.patch/Mailman/MailList.py 2004-07-20 23:17: 09.000000000 -0700 @@ -1081,7 +1081,7 @@ # It's possible they were a member of this list, but choose to change # their membership globally. In that case, we simply remove the old # address. - if self.isMember(newaddr): + if self.getMemberCPAddress(oldaddr) == newaddr: self.removeMember(oldaddr) else: self.changeMemberAddress(oldaddr, newaddr) @@ -1101,7 +1101,7 @@ mlist.Lock() try: # Same logic as above, re newaddr is already a member - if mlist.isMember(newaddr): + if mlist.getMemberCPAddress(oldaddr) == newaddr: mlist.removeMember(oldaddr) else: mlist.changeMemberAddress(oldaddr, newaddr) ---------------------------------------------------------------------- Comment By: Eirik Dentz (edentz) Date: 2004-07-21 05:50 Message: Logged In: YES user_id=878352 I encountered this bug too. It doesn't look like it is fixed in 2.1.5 or CVS yet so I did a bit of searching through the Mailman source code and found the part(s) that causes the deletion of the member when attempting to change the case of the localpart of the email address. Lines 332 - 341 of Mailman/Cgi/options.py pass the global change address off and the actual deletion occurs in the ApprovedChangeMemberAddress() method in Mailman/MailList.py. If you change the first if statement in that method (should be line 1050 in Mailman version 2.1.4) from: if self.isMember(newaddr): to: if self.getMemberCPAddress(oldaddr) == newaddr: And then the last if statement (should be line 1070 in Mailman version 2.1.4) in the method from: if mlist.isMember(newaddr): to: if mlist.getMemberCPAddress(oldaddr) == newaddr: It should fix the bug. However I haven't tested this extensively and it may break other functionality. Eirik ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=913397&group_i…

1 0

[ mailman-Patches-923428 ] VERP subscription confirmations
by SourceForge.net Oct. 18, 2004

Oct. 18, 2004

Patches item #923428, was opened at 2004-03-25 20:16 Message generated for change (Settings changed) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=923428&group_i… Category: mail delivery Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Gordon Rowell (gordonr) >Assigned to: Tokio Kikuchi (tkikuchi) Summary: VERP subscription confirmations Initial Comment: From: Gordon Rowell <gordonr(a)gormand.com.au> To: mailman-developers(a)python.org [...] On Thu, Feb 05, 2004 at 09:44:05PM -0500, Gordon Rowell <gordonr(a)gormand.com.au> wrote: > If I enable VERP_CONFIRMATIONS and "Invite" > someone from the admin page, I get a VERP > invite and a "nice" Subject line: > [...] > It appears that the VERP confirmations are only > partially implemented, but maybe I've missed > something. > [...] The attached patch seems to DTRT for me. Gordon ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=923428&group_i…

1 0

[ mailman-Patches-960551 ] Bug: Plain digest with mixed charsets
by SourceForge.net Oct. 17, 2004

Oct. 17, 2004

Patches item #960551, was opened at 2004-05-26 04:18 Message generated for change (Settings changed) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=960551&group_i… Category: mail delivery Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Hatuka*nezumi (hatukanezumi) >Assigned to: Tokio Kikuchi (tkikuchi) Summary: Bug: Plain digest with mixed charsets Initial Comment: Plain digest including bodies: - encoded with charset not preferred by the list - including unkown characters will be shunted. This patch fixes this problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=960551&group_i…

1 0

[ mailman-Patches-995029 ] Patch against Mailman 2.1.5 release fixes bug #913397
by SourceForge.net Oct. 17, 2004

Oct. 17, 2004

Patches item #995029, was opened at 2004-07-21 06:40 Message generated for change (Settings changed) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=995029&group_i… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Eirik Dentz (edentz) >Assigned to: Tokio Kikuchi (tkikuchi) Summary: Patch against Mailman 2.1.5 release fixes bug #913397 Initial Comment: Patch against 2.1.5 release to fix bug #913397 <https://sourceforge.net/tracker/index.php? func=detail&aid=913397&group_id=103&atid=100103> This hasn't been tested extensively and it may break other functionality, but it seems to produce the desired result of allowing user to change the case of the localpart of his/her email address when checking the "change globally" option on the options page. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=995029&group_i…

1 0

[ mailman-Bugs-913397 ] Subscriber E-Mail-Address: GlobalChange causes removal
by SourceForge.net Oct. 17, 2004

Oct. 17, 2004

Bugs item #913397, was opened at 2004-03-10 10:53 Message generated for change (Settings changed) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=913397&group_i… Category: None Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: chris-taylor (chris-taylor) >Assigned to: Tokio Kikuchi (tkikuchi) Summary: Subscriber E-Mail-Address: GlobalChange causes removal Initial Comment: A subscriber of some mailinglists on my site tried to change his email address globally. The change for one of the lists only affected a correction of upper- and lower-case letters in the local part of the address(e.g. will.smith@... -> Will.Smith@....). After confirming the change an error occured and the subscriber was completely unsubscribed from the list. Neither the old address nor the new address were registered in the subscribers list. ---------------------------------------------------------------------- Comment By: Eirik Dentz (edentz) Date: 2004-07-21 06:30 Message: Logged In: YES user_id=878352 Here is a patch against the 2.1.5 Mailman release: --- mailman-2.1.5/Mailman/MailList.py 2004-03-04 06:10:28.000000000 -0800 +++ mailman-2.1.5.patch/Mailman/MailList.py 2004-07-20 23:17: 09.000000000 -0700 @@ -1081,7 +1081,7 @@ # It's possible they were a member of this list, but choose to change # their membership globally. In that case, we simply remove the old # address. - if self.isMember(newaddr): + if self.getMemberCPAddress(oldaddr) == newaddr: self.removeMember(oldaddr) else: self.changeMemberAddress(oldaddr, newaddr) @@ -1101,7 +1101,7 @@ mlist.Lock() try: # Same logic as above, re newaddr is already a member - if mlist.isMember(newaddr): + if mlist.getMemberCPAddress(oldaddr) == newaddr: mlist.removeMember(oldaddr) else: mlist.changeMemberAddress(oldaddr, newaddr) ---------------------------------------------------------------------- Comment By: Eirik Dentz (edentz) Date: 2004-07-21 05:50 Message: Logged In: YES user_id=878352 I encountered this bug too. It doesn't look like it is fixed in 2.1.5 or CVS yet so I did a bit of searching through the Mailman source code and found the part(s) that causes the deletion of the member when attempting to change the case of the localpart of the email address. Lines 332 - 341 of Mailman/Cgi/options.py pass the global change address off and the actual deletion occurs in the ApprovedChangeMemberAddress() method in Mailman/MailList.py. If you change the first if statement in that method (should be line 1050 in Mailman version 2.1.4) from: if self.isMember(newaddr): to: if self.getMemberCPAddress(oldaddr) == newaddr: And then the last if statement (should be line 1070 in Mailman version 2.1.4) in the method from: if mlist.isMember(newaddr): to: if mlist.getMemberCPAddress(oldaddr) == newaddr: It should fix the bug. However I haven't tested this extensively and it may break other functionality. Eirik ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=913397&group_i…

1 0

[ mailman-Patches-1029275 ] Maximum number of members per list.
by SourceForge.net Oct. 17, 2004

Oct. 17, 2004

Patches item #1029275, was opened at 2004-09-16 15:31 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1029275&group_… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None >Priority: 4 Submitted By: iamstratus (iamstratus) Assigned to: Nobody/Anonymous (nobody) Summary: Maximum number of members per list. Initial Comment: With this patch site administrators can control the maximum number of members per list. I really need this feature but it's my first attempt changing mailman code so i don't known if it's the best way to handle this situation and if a list administrator can override 'max_members'.Comments, anyone? I've patched mailman 2.1.5 and the mailman 2.1.5 official debian source package (through dpatch) and it seems to be working fine on my test server. The lists that doesn't have 'max_members'[*] or where it's 0 are unlimited and i've created (based on change_pw) the change_maxmembers script where you can change and print the 'max_members' attribute from a list (or many). [*] = How the new attributes situation is handled? On upgrade you add what's missing with the upgrade script or what? Hope that helps, Gustavo Franco -- <stratus(a)acm.org> RITS - http://www.rits.org.br/ p.s: It's being accepted i guess that we can ack some of the suggestions at the RFE #403310. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2004-10-17 04:23 Message: Logged In: YES user_id=67709 Looks like this patch is useful if an ISP is providing limited service or charging extra fee for increased list size. Since mailman is not only for ISPs, priority is lowered. I hope you can keep maintaining this patch here in the tracker. For your info, if you add a new variable in mlist class, you can update exsisting lists' variables through versions.py, Version.py, and bin/update. ---------------------------------------------------------------------- Comment By: iamstratus (iamstratus) Date: 2004-10-01 17:15 Message: Logged In: YES user_id=1121054 Hi, I'm sending this update to the previous patch.With this one you can create a list through web interface ('create' script) limiting the number of members. 8) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1029275&group_…

1 0

[ mailman-Patches-1045656 ] Race in LockFile.py resulting in extraneous log entries.
by SourceForge.net Oct. 15, 2004

Oct. 15, 2004

Patches item #1045656, was opened at 2004-10-12 14:50 Message generated for change (Comment added) made by grnbrg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1045656&group_… Category: mail delivery Group: Mailman 2.1 Status: Open Resolution: None Priority: 3 Submitted By: Brian Greenberg (grnbrg) Assigned to: Nobody/Anonymous (nobody) Summary: Race in LockFile.py resulting in extraneous log entries. Initial Comment: There is a race condition (that does not affect correct operation of Mailman) in .../Mailman/LockFile.py. This race results in entries to the "locks" log file (usually in pairs) that are unnecessary and confusing. If there is a process holding a lock for a file, and a process waiting for that lock to be freed, the following sequence can occur: 1) The waiting process executes os.link(). Since the running process still has the lock, this fails with EEXIST. 2) The running process releases the lock, and removes the lock file. 3) The waiting process proceeds with it's checks, and checks self.__linkcount() which returns -1 due to an ENOENT error. This throws an error into the "locks" log file. 4) The waiting process continues processing, checks it's timeout, and then checks to see if the lock lifetime has expired. The lifetime check is based on a call to self.__releasetime(), which returns -1, due to an ENOENT error. This results in the lockfile being declared stale, and self.__break() is called. This then throws a second error into the "locks" log file. The attached patch checks for these ENOENT errors, immediately restarting the loop when they are detected. It does not affect operation is the lock file exists and is held by another process. Brian Greenberg. ---------------------------------------------------------------------- >Comment By: Brian Greenberg (grnbrg) Date: 2004-10-15 09:22 Message: Logged In: YES user_id=902583 This would fix this bug, as long as CLOCK_SLOP is large enough. But I don't think it's the Right Thing, as you are returning a result that says that the lockfile has a lifetime, when it in fact simply no longer exists. For a function whose purpose is to report the mtime of the master lockfile, -1 is the correct response if the file doesn't exist. The code that calls that function should check for and interpret that condition. ---------------------------------------------------------------------- Comment By: SHIGENO Kazutaka (shigeno) Date: 2004-10-14 19:11 Message: Logged In: YES user_id=1138453 How about changing as follows about self.__releasetime()? @@ -448,7 +448,7 @@ return os.stat(self.__lockfile)[ST_MTIME] except OSError, e: if e.errno <> errno.ENOENT: raise - return -1 + return time.time() def __linkcount(self): try: ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1045656&group_…

1 0

[ mailman-Feature Requests-1047785 ] Obscure e-mail of administrator on the listinfo page
by SourceForge.net Oct. 15, 2004

Oct. 15, 2004

Feature Requests item #1047785, was opened at 2004-10-15 08:42 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=350103&aid=1047785&group_… Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: NancyS (nes49) Assigned to: Nobody/Anonymous (nobody) Summary: Obscure e-mail of administrator on the listinfo page Initial Comment: When an administrator's e-mail address is entered in the general options, that address appears in the footer of the listinfo page. For instance listname list run by someone at somehost but the mailto link under "someone at somehost" is still "mailto:listname-owner@listhost". Yes, I know that the entire page can be replaced with other HTML, but can there be an option to make the text for the link agree with the mailto, e.g. "listname- owner at listhost" instead of "advertising" what may be a real person's address as something associated with the list? -Nancy ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=350103&aid=1047785&group_…

1 0

[ mailman-Bugs-998384 ] Tend to Pending Moderator Requests breaks on a few lists
by SourceForge.net Oct. 15, 2004

Oct. 15, 2004

Bugs item #998384, was opened at 2004-07-27 00:15 Message generated for change (Comment added) made by zot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=998384&group_i… Category: Web/CGI Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Len Hatfield (lenhatfield) Assigned to: Nobody/Anonymous (nobody) Summary: Tend to Pending Moderator Requests breaks on a few lists Initial Comment: After upgrading from MM 2.0.3 to 2.1.5, I find that on just a couple of my lists when I access the web-admin interface and try to follow the "Tend to Pending Moderator Requests" link, I get the following bug announcement: Bug in Mailman version 2.1.5 We're sorry, we hit a bug! If you would like to help us identify the problem, please email a copy of this page to the webmaster for this site with a description of what happened. Thanks! Traceback: Traceback (most recent call last): File "/c/mm2/scripts/driver", line 87, in run_main main() File "/c/mm2/Mailman/Cgi/admindb.py", line 231, in main num = show_pending_subs(mlist, form) File "/c/mm2/Mailman/Cgi/admindb.py", line 274, in show_pending_subs pendingsubs = mlist.GetSubscriptionIds() File "/c/mm2/Mailman/ListAdmin.py", line 138, in GetSubscriptionIds return self.__getmsgids(SUBSCRIPTION) File "/c/mm2/Mailman/ListAdmin.py", line 130, in __getmsgids ids = [k for k, (op, data) in self.__db.items() if op == rtype] ValueError: unpack tuple of wrong size Python information: Variable Value sys.version 2.3.4 (#1, Jul 21 2004, 23:31:00) [GCC 2.95.3 20010315 (release)] sys.executable /usr/bin/python sys.prefix /usr/local sys.exec_prefix /usr/local sys.path /usr/local sys.platform linux2 Environment variables: Variable Value HTTP_REFERER http://wiz.cath.vt.edu/mailman/admin/hel-l SERVER_SOFTWARE Apache SCRIPT_NAME /mailman/admindb SERVER_SIGNATURE REQUEST_METHOD GET HTTP_KEEP_ALIVE 300 SERVER_PROTOCOL HTTP/1.1 QUERY_STRING HTTP_ACCEPT_CHARSET ISO-8859-1,utf-8;q=0.7,*;q=0.7 HTTP_USER_AGENT Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040628 Firefox/0.9.1 HTTP_CONNECTION keep-alive HTTP_COOKIE hel-l+admin=280200000069299d0541732800000034633337343331663037376464386366353661356532393638663262343937613764313365663234 SERVER_NAME wiz.cath.vt.edu REMOTE_ADDR 68.185.125.105 PATH_TRANSLATED /www/hel-l SERVER_PORT 80 SERVER_ADDR 128.173.51.243 DOCUMENT_ROOT /www PYTHONPATH /c/mm2 SCRIPT_FILENAME /c/mm2/cgi-bin/admindb SERVER_ADMIN lhat(a)wiz.cath.vt.edu HTTP_HOST wiz.cath.vt.edu REQUEST_URI /mailman/admindb/hel-l HTTP_ACCEPT text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5 GATEWAY_INTERFACE CGI/1.1 REMOTE_PORT 61615 HTTP_ACCEPT_LANGUAGE en-us,en;q=0.5 HTTP_ACCEPT_ENCODING gzip,deflate UNIQUE_ID QQWdLICtM-MAAEji16U PATH_INFO /hel-l ---------------------------------------------------------------------- Comment By: Zot O'Connor (zot) Date: 2004-10-15 04:58 Message: Logged In: YES user_id=79680 I am seeing the same exact thing. Traceback (most recent call last): File "/var/mailman/scripts/driver", line 87, in run_main main() File "/var/mailman/Mailman/Cgi/admindb.py", line 231, in main num = show_pending_subs(mlist, form) File "/var/mailman/Mailman/Cgi/admindb.py", line 274, in show_pending_subs pendingsubs = mlist.GetSubscriptionIds() File "/var/mailman/Mailman/ListAdmin.py", line 138, in GetSubscriptionIds return self.__getmsgids(SUBSCRIPTION) File "/var/mailman/Mailman/ListAdmin.py", line 130, in __getmsgids ids = [k for k, (op, data) in self.__db.items() if op == rtype] ValueError: unpack tuple of wrong size sys.version 2.3.3 (#1, May 7 2004, 10:31:40) [GCC 3.3.3 20040412 (Red Hat Linux 3.3.3-7)] sys.executable /usr/bin/python sys.prefix /usr sys.exec_prefix /usr sys.path /usr sys.platform linux2 The environment vars were a bit off for PATH_TRANSLATED and DOCUMENT_ROOT But evertyhing else seems to be working. Is anyone looking at this bug? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=998384&group_i…

1 0