Mailman 3 August 2004 - Mailman-coders

[ mailman-Bugs-1013079 ] spam filters get removed when changing other privacy pages
by SourceForge.net 20 Aug '04

20 Aug '04

Bugs item #1013079, was opened at 2004-08-20 15:23 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1013079&group_… Category: security/privacy Group: 2.1 beta Status: Open Resolution: None Priority: 5 Submitted By: Ralph Siemsen (ralphs) Assigned to: Nobody/Anonymous (nobody) Summary: spam filters get removed when changing other privacy pages Initial Comment: Error report on behalf of Russell King (rmk+bugzilla(a)arm.linux.org.uk): Description of problem: If you enter some header_filter_rules in the mailman admin pages (Privacy->Spam filters) and click "submit" they are added to the list configuration database. However, if you now go to one of the other Privacy pages and click "submit" and return to the Spam Filters page, you'll find that your header_filter_rules settings have been removed. This appears to be caused by the handleForm function in ~mailman/Mailman/Gui/Privacy.py not checking to see which subsection is being submitted before processing the data for and setting the mlist.header_filter_rules list configuration variable. Version-Release number of selected component (if applicable): mailman-2.1.5-7 How reproducible: Always Steps to Reproduce: 1. Create list. 2. Go to the Privacy->Spam filters page, add some header_filter_rules and hit submit. 3. Go to the Privacy->Sender filters page but don't hit submit 4. Go back to Spam filters and note that they're still present 5. Return to Sender filters and hit submit 6. Go back to Spam filters and note that they've been removed. Actual Results: All spam filters are removed. Expected Results: Spam filter settings should be retained. Also reported to redhat bugzilla: http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=130479 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1013079&group_…

1 0

[ mailman-Bugs-974759 ] HTML email and attachment archiving inconsistencies
by SourceForge.net 20 Aug '04

20 Aug '04

Bugs item #974759, was opened at 2004-06-17 15:16 Message generated for change (Comment added) made by fergusdonohue You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=974759&group_i… Category: Pipermail Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Nick Bower (nickbower) Assigned to: Nobody/Anonymous (nobody) Summary: HTML email and attachment archiving inconsistencies Initial Comment: With archiving set to on and content filtering off (default options everywhere), I've encountered inconsistencies with the mail archiving and multipart attachments. If I send a HTML email, the arhived message correctly shows the text/plain porition with a link to the HTML version. However if I send a HTML email with an image attachment, the archived message shows nothing except for the link to the image. The original message (in either plain text or HTML) is lost. I would have expected the same plain text view with now 2 links to both the HTML part and image attachment. I've tested this with Outlook and Evolution. Note that if I send 1 or more images attached to a plain text message, everything works as expected. Thanks, Nick ---------------------------------------------------------------------- Comment By: Fergus Donohue (fergusdonohue) Date: 2004-08-20 15:55 Message: Logged In: YES user_id=1107982 This is happening to me on Mailman 2.1.5 on Solaris. It probably merits more than a P5 based on the numbers of users who send text and html messages from outlook? If anyone likes I can send a shell script that generates this behaviour by piping data to port 25. I've tested the patches for Scrubber.py but they don't rectify this problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=974759&group_i…

1 0

[ mailman-Bugs-1012925 ] cc rejects to admins
by SourceForge.net 20 Aug '04

20 Aug '04

Bugs item #1012925, was opened at 2004-08-20 07:27 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1012925&group_… Category: None Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Aahz (aahz) Assigned to: Nobody/Anonymous (nobody) Summary: cc rejects to admins Initial Comment: It'd be useful if you could optionally cc reject messages to the admin address of a list (so that multiple admins keep track of what's going on). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1012925&group_…

1 0

[ mailman-Patches-1008983 ] qrunner w/ multiple slices crashing.
by SourceForge.net 13 Aug '04

13 Aug '04

Patches item #1008983, was opened at 2004-08-13 16:45 Message generated for change (Settings changed) made by grnbrg You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008983&group_… Category: mail delivery Group: Mailman 2.1 Status: Open Resolution: None >Priority: 7 Submitted By: Brian Greenberg (grnbrg) Assigned to: Nobody/Anonymous (nobody) Summary: qrunner w/ multiple slices crashing. Initial Comment: When running qrunner with multiple instances of a particular class (ie: qrunner -r OutgoingRunner:0:4 -r OutgoingRunner:1:4 -r OutgoingRunner:2:4 -r OutgoingRunner:3:4 ) the qrunner processes for this class will periodically crash, leaving the following traces: logs/qrunner: Aug 13 15:27:51 2004 (29188) Master qrunner detected subprocess exit (pid: 23829, sig: None, sts: 1, class: OutgoingRunner, slice: 1/4) [restarting] logs/error: Aug 13 15:27:51 2004 qrunner(23829): Traceback (most recent call last): Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/bin/qrunner", line 270, in ? Aug 13 15:27:51 2004 qrunner(23829): main() Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/bin/qrunner", line 230, in main Aug 13 15:27:51 2004 qrunner(23829): qrunner.run() Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/Mailman/Queue/Runner.py", line 70, in run Aug 13 15:27:51 2004 qrunner(23829): filecnt = self._oneloop() Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/Mailman/Queue/Runner.py", line 99, in _oneloop Aug 13 15:27:51 2004 qrunner(23829): msg, msgdata = self._switchboard.dequeue(filebase) Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/Mailman/Queue/Switchboard.py", line 143, in dequeue Aug 13 15:27:51 2004 qrunner(23829): fp = open(filename) Aug 13 15:27:51 2004 qrunner(23829): IOError : [Errno 2] No such file or directory: '/var/priv/mail/mailman/qfiles/out/1092428866.8410051+70dcb0bb96e6460d8cd2a a8103cce318cfa3ed1f.pck' This is caused by a logic error in mailman/Mailman/Queues/Switchboard.py:files. Specifically, when there are not multiple slices running for a particular qrunner class, self.__upper and self.__lower are both set to None in Switchboard.py:__init__. Switchboard.py:files contains the statement: if not lower or (lower <= long(digest, 16) < upper): times[float](when)] = filebase ie: if there is only one slice (because "lower" is not "None") or if this filename is within the range of the slice that this qrunner is managing, then add it to the list. The problem is that the first slice of any multi-slice qrunner has a lower bound of "0". This means that slice "0" of any multi-slice qrunner will act on *all* files in a given queue, which in turn results in race conditions wherein slice 0 and slice n will begin to process a message, one will complete processing and remove the file, and the other will crash. Patch: *** Switchboard.py Fri Aug 13 16:43:12 2004 --- Switchboard.py_new Fri Aug 13 16:43:48 2004 *************** *** 164,170 **** when, digest = filebase.split('+') # Throw out any files which don't match our bitrange. BAW: test # performance and end-cases of this algorithm. ! if not lower or (lower <= long(digest, 16) < upper): times[float(when)] = filebase # FIFO sort keys = times.keys() --- 164,170 ---- when, digest = filebase.split('+') # Throw out any files which don't match our bitrange. BAW: test # performance and end-cases of this algorithm. ! if (lower == upper) or (lower <= long(digest, 16) < upper): times[float(when)] = filebase # FIFO sort keys = times.keys() Brian Greenberg -- grnbrg(a)cc.umanitoba.ca ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008983&group_…

1 0

[ mailman-Patches-1008983 ] qrunner w/ multiple slices crashing.
by SourceForge.net 13 Aug '04

13 Aug '04

Patches item #1008983, was opened at 2004-08-13 16:45 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008983&group_… Category: mail delivery Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Brian Greenberg (grnbrg) Assigned to: Nobody/Anonymous (nobody) Summary: qrunner w/ multiple slices crashing. Initial Comment: When running qrunner with multiple instances of a particular class (ie: qrunner -r OutgoingRunner:0:4 -r OutgoingRunner:1:4 -r OutgoingRunner:2:4 -r OutgoingRunner:3:4 ) the qrunner processes for this class will periodically crash, leaving the following traces: logs/qrunner: Aug 13 15:27:51 2004 (29188) Master qrunner detected subprocess exit (pid: 23829, sig: None, sts: 1, class: OutgoingRunner, slice: 1/4) [restarting] logs/error: Aug 13 15:27:51 2004 qrunner(23829): Traceback (most recent call last): Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/bin/qrunner", line 270, in ? Aug 13 15:27:51 2004 qrunner(23829): main() Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/bin/qrunner", line 230, in main Aug 13 15:27:51 2004 qrunner(23829): qrunner.run() Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/Mailman/Queue/Runner.py", line 70, in run Aug 13 15:27:51 2004 qrunner(23829): filecnt = self._oneloop() Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/Mailman/Queue/Runner.py", line 99, in _oneloop Aug 13 15:27:51 2004 qrunner(23829): msg, msgdata = self._switchboard.dequeue(filebase) Aug 13 15:27:51 2004 qrunner(23829): File "/usr/local/mailman/Mailman/Queue/Switchboard.py", line 143, in dequeue Aug 13 15:27:51 2004 qrunner(23829): fp = open(filename) Aug 13 15:27:51 2004 qrunner(23829): IOError : [Errno 2] No such file or directory: '/var/priv/mail/mailman/qfiles/out/1092428866.8410051+70dcb0bb96e6460d8cd2a a8103cce318cfa3ed1f.pck' This is caused by a logic error in mailman/Mailman/Queues/Switchboard.py:files. Specifically, when there are not multiple slices running for a particular qrunner class, self.__upper and self.__lower are both set to None in Switchboard.py:__init__. Switchboard.py:files contains the statement: if not lower or (lower <= long(digest, 16) < upper): times[float](when)] = filebase ie: if there is only one slice (because "lower" is not "None") or if this filename is within the range of the slice that this qrunner is managing, then add it to the list. The problem is that the first slice of any multi-slice qrunner has a lower bound of "0". This means that slice "0" of any multi-slice qrunner will act on *all* files in a given queue, which in turn results in race conditions wherein slice 0 and slice n will begin to process a message, one will complete processing and remove the file, and the other will crash. Patch: *** Switchboard.py Fri Aug 13 16:43:12 2004 --- Switchboard.py_new Fri Aug 13 16:43:48 2004 *************** *** 164,170 **** when, digest = filebase.split('+') # Throw out any files which don't match our bitrange. BAW: test # performance and end-cases of this algorithm. ! if not lower or (lower <= long(digest, 16) < upper): times[float(when)] = filebase # FIFO sort keys = times.keys() --- 164,170 ---- when, digest = filebase.split('+') # Throw out any files which don't match our bitrange. BAW: test # performance and end-cases of this algorithm. ! if (lower == upper) or (lower <= long(digest, 16) < upper): times[float(when)] = filebase # FIFO sort keys = times.keys() Brian Greenberg -- grnbrg(a)cc.umanitoba.ca ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008983&group_…

1 0

[ mailman-Patches-1008865 ] patch to add 'Spam' disposition
by SourceForge.net 13 Aug '04

13 Aug '04

Patches item #1008865, was opened at 2004-08-13 18:09 Message generated for change (Settings changed) made by chriscog You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008865&group_… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Chris Cogdon (chriscog) Assigned to: Nobody/Anonymous (nobody) >Summary: patch to add 'Spam' disposition Initial Comment: This patch will add a 'Spam' disposition option to the admindb page (and the associuated handlers). Selecting 'Spam' will both forward the mail to a pre-programmed spam handler address (eg: spamcop, or spamassassin's bayesian filter), and discard the mail. This is MUCH easier than hitting 'defer', 'forward', and pasting an address; one wants to spend as little time as possible handling spam. Note that this patch does NOT handle any i18n issues. I don't know how to do that... if given some pointers on how, I'm most happy to, though. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008865&group_…

1 0

[ mailman-Patches-1008865 ] patch to add 'Spam' dispostion
by SourceForge.net 13 Aug '04

13 Aug '04

Patches item #1008865, was opened at 2004-08-13 18:09 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008865&group_… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Chris Cogdon (chriscog) Assigned to: Nobody/Anonymous (nobody) Summary: patch to add 'Spam' dispostion Initial Comment: This patch will add a 'Spam' disposition option to the admindb page (and the associuated handlers). Selecting 'Spam' will both forward the mail to a pre-programmed spam handler address (eg: spamcop, or spamassassin's bayesian filter), and discard the mail. This is MUCH easier than hitting 'defer', 'forward', and pasting an address; one wants to spend as little time as possible handling spam. Note that this patch does NOT handle any i18n issues. I don't know how to do that... if given some pointers on how, I'm most happy to, though. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1008865&group_…

1 0

[ mailman-Bugs-1007706 ] Reply-To not preserved if it contains 2 addresses or more
by SourceForge.net 12 Aug '04

12 Aug '04

Bugs item #1007706, was opened at 2004-08-11 22:54 Message generated for change (Settings changed) made by acli You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1007706&group_… Category: None Group: 2.1 (stable) >Status: Deleted >Resolution: Invalid Priority: 5 Submitted By: Ambrose C. LI (acli) Assigned to: Nobody/Anonymous (nobody) Summary: Reply-To not preserved if it contains 2 addresses or more Initial Comment: If I send a piece of mail to a mailman (2.1.4) managed list with a Reply-To in the form Reply-To: foo(a)example.org, bar(a)example.org the mail, when actually delivered, will only contain Reply-To: foo(a)example.org i.e., only the first address in Reply-To will be preserved; the rest is discarded. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1007706&group_…

1 0

[ mailman-Bugs-1007706 ] Reply-To not preserved if it contains 2 addresses or more
by SourceForge.net 12 Aug '04

12 Aug '04

Bugs item #1007706, was opened at 2004-08-11 22:54 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1007706&group_… Category: None Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Ambrose C. LI (acli) Assigned to: Nobody/Anonymous (nobody) Summary: Reply-To not preserved if it contains 2 addresses or more Initial Comment: If I send a piece of mail to a mailman (2.1.4) managed list with a Reply-To in the form Reply-To: foo(a)example.org, bar(a)example.org the mail, when actually delivered, will only contain Reply-To: foo(a)example.org i.e., only the first address in Reply-To will be preserved; the rest is discarded. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1007706&group_…

1 0

[ mailman-Patches-1007477 ] list_members filter by moderated/unmoderated
by SourceForge.net 11 Aug '04

11 Aug '04

Patches item #1007477, was opened at 2004-08-11 18:53 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1007477&group_… Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: Jeff Bailey (jbailey999) Assigned to: Nobody/Anonymous (nobody) Summary: list_members filter by moderated/unmoderated Initial Comment: list_members should have the ability to see who can post and who can't. MM2.0 made it easy to find this inforamtion, so this is a regression. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1007477&group_…

1 0