Mailman 3 January 2006 - Mailman-coders

[ mailman-Bugs-1400128 ] edithtml.py missing import
by SourceForge.net 08 Jan '06

08 Jan '06

Bugs item #1400128, was opened at 2006-01-09 06:13 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1400128&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: configuring/installing Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Cliff Wells (cliffwells18) Assigned to: Nobody/Anonymous (nobody) Summary: edithtml.py missing import Initial Comment: You can't save edited pages because edithtml.py fails to import the re module. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2006-01-09 07:44 Message: Logged In: YES user_id=67709 It was fixed it in the CVS. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2006-01-09 06:50 Message: Logged In: YES user_id=67709 Please add import re line in the first part of edithtml.py file. Sorry for the inconvenience. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1400128&group_…

1 0

[ mailman-Bugs-1395683 ] UnicodeError running arch
by SourceForge.net 08 Jan '06

08 Jan '06

Bugs item #1395683, was opened at 2006-01-03 01:12 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1395683&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: command line scripts Group: 2.1 (stable) >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: Michael Wallis (kf6spf) Assigned to: Nobody/Anonymous (nobody) Summary: UnicodeError running arch Initial Comment: I just deployed the latest release (2.1.7 stable) and decided to rebuild an archive. I'm getting the following error trace caused by it hitting high-order byte characters. These were not a problem when I first built the archive from 2.1.6 so something may have changed. Pickling archive state into /usr/local/mailman/archives/private/basfa/pipermail.pck Traceback (most recent call last): File "bin/arch", line 200, in ? main() File "bin/arch", line 188, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 585, in processUnixMailbox self.add_article(a) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 626, in add_article filename)) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 1116, in write_article f.write(article.as_text()) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 579, in as_text '\g<1>' + _(' at ') + '\g<2>', body) File "/usr/lib/python2.2/sre.py", line 143, in sub return _compile(pattern, 0).sub(repl, string, count) UnicodeError: ASCII decoding error: ordinal not in range(128) ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2006-01-09 07:41 Message: Logged In: YES user_id=67709 Hi, I've just committed this patch in the CVS. I'll be releasing 2.1.8 but, in the meantime, please use this patch. Sorry for the inconvenience. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-06 05:43 Message: Logged In: YES user_id=1123998 I have deleted my patch # 161995 to avoid confusion as patch # 162200 is the correct one. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2006-01-05 02:50 Message: Logged In: YES user_id=67709 Here is a revised patch to incorporate non-ascii '_at_' replacement. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-03 18:20 Message: Logged In: YES user_id=1123998 One other followup note on this. The problem can also occur when archiving an individual post to a list. In this case, the HTML file for the post will be written but not indexed; the post will not be added to the .txt file; the error will be logged in the 'error' log, and the message will be shunted. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-03 17:28 Message: Logged In: YES user_id=1123998 The previous patch wasn't effective in all circumstances. I have replaced it again. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-03 05:21 Message: Logged In: YES user_id=1123998 I've developed a new patch which I've attached here in place of the previous one. I think the new patch actually fixes the problem. Please try it and report. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-03 01:54 Message: Logged In: YES user_id=1123998 I also observed this problem. It will be properly fixed. In the mean time, I have attached a patch - HyperArch.patch - which will allow you to rebuild the full archive. The patch is not a real fix for the problem however, as the problem messages will not have email addresses obscured in the body of the message in the monthly .txt files. The HTML archive will be OK. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1395683&group_…

1 0

[ mailman-Bugs-1400128 ] edithtml.py missing import
by SourceForge.net 08 Jan '06

08 Jan '06

Bugs item #1400128, was opened at 2006-01-09 06:13 Message generated for change (Comment added) made by tkikuchi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1400128&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: configuring/installing Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Cliff Wells (cliffwells18) Assigned to: Nobody/Anonymous (nobody) Summary: edithtml.py missing import Initial Comment: You can't save edited pages because edithtml.py fails to import the re module. ---------------------------------------------------------------------- >Comment By: Tokio Kikuchi (tkikuchi) Date: 2006-01-09 06:50 Message: Logged In: YES user_id=67709 Please add import re line in the first part of edithtml.py file. Sorry for the inconvenience. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1400128&group_…

1 0

[ mailman-Bugs-1400128 ] edithtml.py missing import
by SourceForge.net 08 Jan '06

08 Jan '06

Bugs item #1400128, was opened at 2006-01-08 22:13 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1400128&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: configuring/installing Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Cliff Wells (cliffwells18) Assigned to: Nobody/Anonymous (nobody) Summary: edithtml.py missing import Initial Comment: You can't save edited pages because edithtml.py fails to import the re module. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1400128&group_…

1 0

[ mailman-Patches-1399065 ] link in approval request emails directly to the held message
by SourceForge.net 07 Jan '06

07 Jan '06

Patches item #1399065, was opened at 2006-01-07 02:33 Message generated for change (Comment added) made by justdave72 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1399065&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: David Miller (justdave72) Assigned to: Nobody/Anonymous (nobody) Summary: link in approval request emails directly to the held message Initial Comment: The emails currently sent to a list moderator include a URL you can click to go visit the moderation queue. But it loads the entire queue. If you get a lot of spam, you probably have a habit of just ignoring the approval requests if they're spam. This can make the size of your queue pretty large after a while (even if you're using a cron job to expire old requests), and make it difficult to find the message you want to approve when you get one worth approving. Include in the email is an attached email with a 40-digit token which you can reply to and send a password in order to approve the message. Trying to remember a list password when I moderate 85 lists is nuts (that's what my browser's password autofill is for), and I don't like the idea of mailing my site password around in cleartext. The admindb interface on the Web UI already has the ability to display a single message (when you click the [1] or [2] in front of the subject line). So why not use it, and have the moderator approval request mails list link directly to that? This patch modifies admindb in the web interface to accept a confirmation token in the msgid parameter, in addition to the sequence ID within the queue. It decides which it got by checking the length (if it's 40 digits, it's a token), and if it's a token, it looks up the sequence number and feeds that to the existing single-message display code. It also modifies the held message handler to add the cookie to the variables passed to the message template, and modifies the postauth.txt template to add that cookie to the URL included in the email. With this patch applied, clicking the link in the email takes you to the single-message view in the request queue, where you can do what you want with just that message. I wrote this patch against 2.1.5 (that's what ships with RHEL4), but it appears to apply cleanly to 2.1.7 also. ---------------------------------------------------------------------- >Comment By: David Miller (justdave72) Date: 2006-01-07 03:32 Message: Logged In: YES user_id=648592 OK, after discussion on IRC, I've modified the patch a bit... In order to avoid modifying localized templates, it now modifies the admindb_url variable before passing it to the template. Also cleaned up some leftover debugging messages. ---------------------------------------------------------------------- Comment By: David Miller (justdave72) Date: 2006-01-07 02:39 Message: Logged In: YES user_id=648592 Also of note, I only modified the English template... if you use other languages (or if this gets taken for a release) the same modification will need to be made to the postauth.txt template in the other language directories as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1399065&group_…

1 0

[ mailman-Patches-1399065 ] link in approval request emails directly to the held message
by SourceForge.net 06 Jan '06

06 Jan '06

Patches item #1399065, was opened at 2006-01-07 02:33 Message generated for change (Comment added) made by justdave72 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1399065&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: David Miller (justdave72) Assigned to: Nobody/Anonymous (nobody) Summary: link in approval request emails directly to the held message Initial Comment: The emails currently sent to a list moderator include a URL you can click to go visit the moderation queue. But it loads the entire queue. If you get a lot of spam, you probably have a habit of just ignoring the approval requests if they're spam. This can make the size of your queue pretty large after a while (even if you're using a cron job to expire old requests), and make it difficult to find the message you want to approve when you get one worth approving. Include in the email is an attached email with a 40-digit token which you can reply to and send a password in order to approve the message. Trying to remember a list password when I moderate 85 lists is nuts (that's what my browser's password autofill is for), and I don't like the idea of mailing my site password around in cleartext. The admindb interface on the Web UI already has the ability to display a single message (when you click the [1] or [2] in front of the subject line). So why not use it, and have the moderator approval request mails list link directly to that? This patch modifies admindb in the web interface to accept a confirmation token in the msgid parameter, in addition to the sequence ID within the queue. It decides which it got by checking the length (if it's 40 digits, it's a token), and if it's a token, it looks up the sequence number and feeds that to the existing single-message display code. It also modifies the held message handler to add the cookie to the variables passed to the message template, and modifies the postauth.txt template to add that cookie to the URL included in the email. With this patch applied, clicking the link in the email takes you to the single-message view in the request queue, where you can do what you want with just that message. I wrote this patch against 2.1.5 (that's what ships with RHEL4), but it appears to apply cleanly to 2.1.7 also. ---------------------------------------------------------------------- >Comment By: David Miller (justdave72) Date: 2006-01-07 02:39 Message: Logged In: YES user_id=648592 Also of note, I only modified the English template... if you use other languages (or if this gets taken for a release) the same modification will need to be made to the postauth.txt template in the other language directories as well. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1399065&group_…

1 0

[ mailman-Patches-1399065 ] link in approval request emails directly to the held message
by SourceForge.net 06 Jan '06

06 Jan '06

Patches item #1399065, was opened at 2006-01-07 02:33 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1399065&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: list administration Group: Mailman 2.1 Status: Open Resolution: None Priority: 5 Submitted By: David Miller (justdave72) Assigned to: Nobody/Anonymous (nobody) Summary: link in approval request emails directly to the held message Initial Comment: The emails currently sent to a list moderator include a URL you can click to go visit the moderation queue. But it loads the entire queue. If you get a lot of spam, you probably have a habit of just ignoring the approval requests if they're spam. This can make the size of your queue pretty large after a while (even if you're using a cron job to expire old requests), and make it difficult to find the message you want to approve when you get one worth approving. Include in the email is an attached email with a 40-digit token which you can reply to and send a password in order to approve the message. Trying to remember a list password when I moderate 85 lists is nuts (that's what my browser's password autofill is for), and I don't like the idea of mailing my site password around in cleartext. The admindb interface on the Web UI already has the ability to display a single message (when you click the [1] or [2] in front of the subject line). So why not use it, and have the moderator approval request mails list link directly to that? This patch modifies admindb in the web interface to accept a confirmation token in the msgid parameter, in addition to the sequence ID within the queue. It decides which it got by checking the length (if it's 40 digits, it's a token), and if it's a token, it looks up the sequence number and feeds that to the existing single-message display code. It also modifies the held message handler to add the cookie to the variables passed to the message template, and modifies the postauth.txt template to add that cookie to the URL included in the email. With this patch applied, clicking the link in the email takes you to the single-message view in the request queue, where you can do what you want with just that message. I wrote this patch against 2.1.5 (that's what ships with RHEL4), but it appears to apply cleanly to 2.1.7 also. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=300103&aid=1399065&group_…

1 0

[ mailman-Bugs-1399021 ] newlist creates archive placeholder with bad link
by SourceForge.net 06 Jan '06

06 Jan '06

Bugs item #1399021, was opened at 2006-01-06 21:05 Message generated for change (Comment added) made by msapiro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1399021&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: command line scripts Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Michael Crusoe (khedron) Assigned to: Nobody/Anonymous (nobody) Summary: newlist creates archive placeholder with bad link Initial Comment: The placeholder for the archive includes a bad link to the signup page. Example @: http://lopsa.org/pipermail/creationtest/ bad link: http://lopsa.org/cgi-bin/mailmanlistinfo/creationtest Presumed correct link: http://lopsa.org/cgi-bin/mailman/listinfo/creationtest Thanks for reviewing this bug. ---------------------------------------------------------------------- >Comment By: Mark Sapiro (msapiro) Date: 2006-01-06 22:40 Message: Logged In: YES user_id=1123998 It appears you have changed (overridden) DEFAULT_URL_PATTERN in mm_cfg.py and left off the trailing slash. You first need to fix that and then run fix_url to fix the existing lists. Run bin/fix_url.py for instructions. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1399021&group_…

1 0

[ mailman-Bugs-1399021 ] newlist creates archive placeholder with bad link
by SourceForge.net 06 Jan '06

06 Jan '06

Bugs item #1399021, was opened at 2006-01-06 22:05 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1399021&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: command line scripts Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Michael Crusoe (khedron) Assigned to: Nobody/Anonymous (nobody) Summary: newlist creates archive placeholder with bad link Initial Comment: The placeholder for the archive includes a bad link to the signup page. Example @: http://lopsa.org/pipermail/creationtest/ bad link: http://lopsa.org/cgi-bin/mailmanlistinfo/creationtest Presumed correct link: http://lopsa.org/cgi-bin/mailman/listinfo/creationtest Thanks for reviewing this bug. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1399021&group_…

1 0

[ mailman-Bugs-1395683 ] UnicodeError running arch
by SourceForge.net 05 Jan '06

05 Jan '06

Bugs item #1395683, was opened at 2006-01-02 17:12 Message generated for change (Comment added) made by msapiro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1395683&group_… Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: command line scripts Group: 2.1 (stable) Status: Open Resolution: None Priority: 5 Submitted By: Michael Wallis (kf6spf) Assigned to: Nobody/Anonymous (nobody) Summary: UnicodeError running arch Initial Comment: I just deployed the latest release (2.1.7 stable) and decided to rebuild an archive. I'm getting the following error trace caused by it hitting high-order byte characters. These were not a problem when I first built the archive from 2.1.6 so something may have changed. Pickling archive state into /usr/local/mailman/archives/private/basfa/pipermail.pck Traceback (most recent call last): File "bin/arch", line 200, in ? main() File "bin/arch", line 188, in main archiver.processUnixMailbox(fp, start, end) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 585, in processUnixMailbox self.add_article(a) File "/usr/local/mailman/Mailman/Archiver/pipermail.py", line 626, in add_article filename)) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 1116, in write_article f.write(article.as_text()) File "/usr/local/mailman/Mailman/Archiver/HyperArch.py", line 579, in as_text '\g<1>' + _(' at ') + '\g<2>', body) File "/usr/lib/python2.2/sre.py", line 143, in sub return _compile(pattern, 0).sub(repl, string, count) UnicodeError: ASCII decoding error: ordinal not in range(128) ---------------------------------------------------------------------- >Comment By: Mark Sapiro (msapiro) Date: 2006-01-05 21:43 Message: Logged In: YES user_id=1123998 I have deleted my patch # 161995 to avoid confusion as patch # 162200 is the correct one. ---------------------------------------------------------------------- Comment By: Tokio Kikuchi (tkikuchi) Date: 2006-01-04 18:50 Message: Logged In: YES user_id=67709 Here is a revised patch to incorporate non-ascii '_at_' replacement. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-03 10:20 Message: Logged In: YES user_id=1123998 One other followup note on this. The problem can also occur when archiving an individual post to a list. In this case, the HTML file for the post will be written but not indexed; the post will not be added to the .txt file; the error will be logged in the 'error' log, and the message will be shunted. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-03 09:28 Message: Logged In: YES user_id=1123998 The previous patch wasn't effective in all circumstances. I have replaced it again. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-02 21:21 Message: Logged In: YES user_id=1123998 I've developed a new patch which I've attached here in place of the previous one. I think the new patch actually fixes the problem. Please try it and report. ---------------------------------------------------------------------- Comment By: Mark Sapiro (msapiro) Date: 2006-01-02 17:54 Message: Logged In: YES user_id=1123998 I also observed this problem. It will be properly fixed. In the mean time, I have attached a patch - HyperArch.patch - which will allow you to rebuild the full archive. The patch is not a real fix for the problem however, as the problem messages will not have email addresses obscured in the body of the message in the monthly .txt files. The HTML archive will be OK. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1395683&group_…

1 0