Mailman 3 October 2013 - Mailman-coders

[Bug 543618] [NEW] test breaks if existing mailman.cfg is found
by Patrick Ben Koetter 24 Mar '15

24 Mar '15

Public bug reported: The test program reports an error if it detects an existing mailman.cfg: Failure in test test_current_working_directory (mailman.tests.test_configfile.TestConfigFileSearch) Traceback (most recent call last): File "/usr/lib/python2.6/unittest.py", line 279, in run testMethod() File "/root/mailman/src/mailman/tests/test_configfile.py", line 107, in test_current_working_directory self.assertEqual(found, config_file) File "/usr/lib/python2.6/unittest.py", line 350, in failUnlessEqual (msg or '%r != %r' % (first, second)) AssertionError: '/etc/mailman.cfg' != u'/tmp/tmpVfAIyB/home/alex/mailman/hacking/mailman.cfg' I believe it should not do this. It should either silently ignore the difference or use the test mailman.cfg or ... but not break. ** Affects: mailman Importance: Undecided Status: New ** Tags: 3.0 mailman -- test breaks if existing mailman.cfg is found https://bugs.launchpad.net/bugs/543618 You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman.

4 6

[Bug 967951] [NEW] The LMTP runner should reject messages with duplicate Message-IDs
by Barry Warsaw 06 Mar '15

06 Mar '15

Public bug reported: Subject says it all. Mailman 3 requires unique Message-IDs for posts. ** Affects: mailman Importance: Undecided Status: New ** Tags: easy mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/967951 Title: The LMTP runner should reject messages with duplicate Message-IDs To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/967951/+subscriptions

6 8

[Merge] lp:~mgill25/mailman/mailman into lp:mailman
by Manish Gill 06 Mar '15

06 Mar '15

Manish Gill has proposed merging lp:~mgill25/mailman/mailman into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) Related bugs: Bug #1166911 in GNU Mailman: "domain option for `bin/mailman lists` doesn't work as expected" https://bugs.launchpad.net/mailman/+bug/1166911 For more details, see: https://code.launchpad.net/~mgill25/mailman/mailman/+merge/157920 Fix for #1166911 -- https://code.launchpad.net/~mgill25/mailman/mailman/+merge/157920 Your team Mailman Coders is requested to review the proposed merge of lp:~mgill25/mailman/mailman into lp:mailman.

2 1

[Bug 1234567] [NEW] Czech catalog bug
by Jan Kratochvil 31 Jan '15

31 Jan '15

Public bug reported: obvious ** Affects: mailman Importance: Undecided Status: New ** Patch added: "fix" https://bugs.launchpad.net/bugs/1234567/+attachment/3856819/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1234567 Title: Czech catalog bug To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1234567/+subscriptions

4 5

[Bug 1158721] [NEW] Emails without a text/plain part crash the Approved rule
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: If an email has no plain text part, the Approved rule will crash with the following message: AttributeError: 'NoneType' object has no attribute 'get_payload' The attached patch fixes the bug and adds a unit test for it. It's been generated from the current bzr branch. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "mailman-notextpart.patch" https://bugs.launchpad.net/bugs/1158721/+attachment/3590081/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1158721 Title: Emails without a text/plain part crash the Approved rule To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1158721/+subscriptions

2 5

[Bug 1170347] [NEW] Digest handler crashes on non-ascii messages with no encoding header
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: I found an interesting bug in the to_digest handler: when a message is not ascii only but has no encoding defined (which happens in the wild unfortunately), the mailbox will crash when adding the message on line 58 of handlers/to_digest.py. The reason is that due to the mailman-specific email.message.Message modifications, some of the headers are unicode strings. As a consequence, when the mailbox.add code from the standard library serializes the email, it merges unicode strings with bytestrings, which result in an unicode string. If this string contains non-ascii characters, python will raise an UnicodeDecodeError doing so. The solution for that is to call the as_string() method before adding to the mailbox, it will do the serialization properly. I'm attaching the fix (one-liner) and a testcase to reproduce it (much larger). ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 ** Patch added: "mailman-digestunicode.patch" https://bugs.launchpad.net/bugs/1170347/+attachment/3647526/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1170347 Title: Digest handler crashes on non-ascii messages with no encoding header To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1170347/+subscriptions

2 6

[Bug 1130957] [NEW] Unicode errors in mailman3
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: This is with mailman3. I'm getting the following unicode errors: Feb 20 23:07:43 2013 (13496) Uncaught runner exception: Expected unicode, found <type 'str'>: 'foobar(a)example.com' Feb 20 23:07:43 2013 (13496) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 228, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/runners/outgoing.py", line 93, in _dispose self._func(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/mta/deliver.py", line 93, in deliver refused = agent.deliver(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/mta/base.py", line 167, in deliver member = mlist.members.get_member(recipient) File "/srv/dev/mailman/mailman/src/mailman/database/transaction.py", line 78, in wrapper return function(args[0], config.db.store, *args[1:], **kws) File "/srv/dev/mailman/mailman/src/mailman/model/roster.py", line 111, in get_member Address.email == address, File "/srv/dev/mailman/venv/lib/python2.7/site-packages/storm-0.19-py2.7-linux-x86_64.egg/storm/expr.py", line 412, in __eq__ other = getattr(self, "variable_factory", Variable)(value=other) File "/srv/dev/mailman/venv/lib/python2.7/site-packages/storm-0.19-py2.7-linux-x86_64.egg/storm/variables.py", line 396, in parse_set % (type(value), value)) TypeError: Expected unicode, found <type 'str'>: 'foobar(a)example.com' Feb 20 23:07:43 2013 (13496) SHUNTING: 1361401663.441109+267302c50d71d512974fe5caa7aa0214eab699f6 ----------------- Feb 20 22:20:45 2013 (13337) Uncaught runner exception: decoding Unicode is not supported Feb 20 22:20:45 2013 (13337) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 228, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 344, in _dispose rfc1153_digest.add_message(message, count) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 269, in add_message payload = unicode(payload, 'us-ascii', 'replace') TypeError: decoding Unicode is not supported Feb 20 22:20:45 2013 (13337) SHUNTING: 1361398845.847068+d12dc2ef44dcca60ade2fc94f6f830bd09a6b912 Feb 20 22:20:52 2013 (13337) Uncaught runner exception: decoding Unicode is not supported Feb 20 22:20:52 2013 (13337) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 228, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 344, in _dispose rfc1153_digest.add_message(message, count) File "/srv/dev/mailman/mailman/src/mailman/runners/digest.py", line 269, in add_message payload = unicode(payload, 'us-ascii', 'replace') TypeError: decoding Unicode is not supported Feb 20 22:20:52 2013 (13337) SHUNTING: 1361398852.901291+bc2f1ab7dad828020238e06815fd2b4adab0fe61 The attached patch fixes both tracebacks. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 ** Patch added: "mailman-unicode.patch" https://bugs.launchpad.net/bugs/1130957/+attachment/3539184/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1130957 Title: Unicode errors in mailman3 To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1130957/+subscriptions

5 12

[Bug 1130696] [NEW] AttributeError: Message instance has no attribute 'sender'
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: This is with mailman3: Feb 20 14:23:07 2013 (5721) Uncaught runner exception: MIMEMultipart instance has no attribute 'sender' Feb 20 14:23:07 2013 (5721) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 218, in _process_one_file elif msg.sender: AttributeError: MIMEMultipart instance has no attribute 'sender' Feb 20 14:23:07 2013 (5721) SHUNTING: 1361370187.943257+1fba5014964bdeae413f5280cd0f4d2cb5f7727b Feb 20 14:23:07 2013 (5721) Uncaught runner exception: Message instance has no attribute 'sender' Feb 20 14:23:07 2013 (5721) Traceback (most recent call last): File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 145, in _one_iteration self._process_one_file(msg, msgdata) File "/srv/dev/mailman/mailman/src/mailman/core/runner.py", line 218, in _process_one_file elif msg.sender: AttributeError: Message instance has no attribute 'sender' Feb 20 14:23:08 2013 (5721) SHUNTING: 1361370187.973463+909c4b5e80497ec67e97765281e7ada77a865143 The message seems to be originating from mailman, it's a digest. I'm attaching a very simple patch that handles the case where there is no sender header. ** Affects: mailman Importance: Undecided Status: New ** Tags: easy mailman3 ** Patch added: "mailman-nosender.patch" https://bugs.launchpad.net/bugs/1130696/+attachment/3538395/+files/mailman-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1130696 Title: AttributeError: Message instance has no attribute 'sender' To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1130696/+subscriptions

2 4

[Bug 1060951] [NEW] Bug getting i18n'ed attachment filenames (RFC2231)
by Aurélien Bompard 30 Dec '14

30 Dec '14

Public bug reported: RFC 2231 allows filenames to have non-ascii characters. The get_filename() method in Python's Message class handles this by calling email.utils.collapse_rfc2231_value() at the end of get_filename. This method returns the filename in Unicode. This fails in Mailman because the mailman.email.message.Message class has a wrapper around get() and __getitem__() to return unicode headers. As a result, the collapse_rfc2231_value() tries to transforms into unicode an already unicode string, and I get the following exception: File "/usr/lib/python2.7/email/utils.py", line 319, in collapse_rfc2231_value return unicode(rawval, charset, errors) TypeError: decoding Unicode is not supported A possible solution to this would be to make Mailman's Message get_filename() method be more than just an exception-catching wrapper, and re-implement the original get_filename() method, inserting a conversion to str before calling collapse_rfc2231_value(). Does this make sense ? Any other idea for a possible solution ? ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1060951 Title: Bug getting i18n'ed attachment filenames (RFC2231) To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1060951/+subscriptions

3 8

[Bug 1157854] [NEW] test_not_enough_parameters hangs on OS X
by Barry Warsaw 30 Nov '14

30 Nov '14

Public bug reported: test_not_enough_parameters (mailman.rest.tests.test_users.TestLogin) This test hangs completely on OS X 10.6.8 and 10.8.2. It does not hang on Ubuntu 13.04 AFAICT. Commenting out this test allows the rest of the test suite to run to completion, although I get three test failures (on OS X 10.8.2). test_cannot_create_duplicate_list (mailman.rest.tests.test_lists.TestLists) test_cannot_create_list_in_missing_domain (mailman.rest.tests.test_lists.TestLists) test_existing_user_error (mailman.rest.tests.test_users.TestUsers) Further, C-c leaves the RESTRunner running. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1157854 Title: test_not_enough_parameters hangs on OS X To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1157854/+subscriptions

1 3