Mailman 3 August 2014 - Mailman-coders

[Bug 1332918] [NEW] Mailman 3.0 ListArchiverSet.__init__() broken
by NotTheEvilOne Nov. 30, 2014

Nov. 30, 2014

Public bug reported: Hi, I'm currently developing an alternative archiver for Mailman 3.0 and ran into the following issue: Jun 21 21:27:13 2014 (23814) Uncaught runner exception: Expected unicode, found <type 'str'>: 'my_archiver_name' Jun 21 21:27:13 2014 (23814) Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/mailman/core/runner.py", line 169, in _one_iteration self._process_one_file(msg, msgdata) File "/usr/lib/python2.7/dist-packages/mailman/core/runner.py", line 252, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/usr/lib/python2.7/dist-packages/mailman/runners/pipeline.py", line 36, in _dispose process(mlist, msg, msgdata, pipeline) File "/usr/lib/python2.7/dist-packages/mailman/core/pipelines.py", line 66, in process handler.process(mlist, msg, msgdata) File "/usr/lib/python2.7/dist-packages/mailman/handlers/rfc_2369.py", line 120, in process process(mlist, msg, msgdata) File "/usr/lib/python2.7/dist-packages/mailman/handlers/rfc_2369.py", line 87, in process archiver_set = IListArchiverSet(mlist) File "/usr/lib/python2.7/dist-packages/zope/component/_api.py", line 156, in adapter_hook return sitemanager.queryAdapter(object, interface, name, default) File "/usr/lib/python2.7/dist-packages/zope/component/registry.py", line 228, in queryAdapter return self.adapters.queryAdapter(object, interface, name, default) File "/usr/lib/python2.7/dist-packages/mailman/model/mailinglist.py", line 591, in __init__ ListArchiver.name == archiver_name)).one() File "/usr/lib/python2.7/dist-packages/storm/expr.py", line 412, in __eq__ other = getattr(self, "variable_factory", Variable)(value=other) File "/usr/lib/python2.7/dist-packages/storm/variables.py", line 396, in parse_set % (type(value), value)) Please find attached a patch. ** Affects: mailman Importance: Undecided Status: New ** Patch added: "Convert "archiver_name" into unicode in "ListArchiverSet.__init__()"" https://bugs.launchpad.net/bugs/1332918/+attachment/4136576/+files/0002-mai… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1332918 Title: Mailman 3.0 ListArchiverSet.__init__() broken To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1332918/+subscriptions

2 2

[Bug 1332919] [NEW] Mailman 3.0 PostgreSQL scheme not up-to-date
by NotTheEvilOne Nov. 30, 2014

Nov. 30, 2014

Public bug reported: Hi, Mailman 3.0 can be used with PostgreSQL as well when changes from "20130406000000" are applied for PostgreSQL as well. "mm_20130406000000.py" doesn't contain the required implementation for PostgreSQL and "postgres.sql" is not up-to-date. ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1332919 Title: Mailman 3.0 PostgreSQL scheme not up-to-date To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1332919/+subscriptions

2 2

[Bug 1157854] [NEW] test_not_enough_parameters hangs on OS X
by Barry Warsaw Nov. 30, 2014

Nov. 30, 2014

Public bug reported: test_not_enough_parameters (mailman.rest.tests.test_users.TestLogin) This test hangs completely on OS X 10.6.8 and 10.8.2. It does not hang on Ubuntu 13.04 AFAICT. Commenting out this test allows the rest of the test suite to run to completion, although I get three test failures (on OS X 10.8.2). test_cannot_create_duplicate_list (mailman.rest.tests.test_lists.TestLists) test_cannot_create_list_in_missing_domain (mailman.rest.tests.test_lists.TestLists) test_existing_user_error (mailman.rest.tests.test_users.TestUsers) Further, C-c leaves the RESTRunner running. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1157854 Title: test_not_enough_parameters hangs on OS X To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1157854/+subscriptions

1 3

[Bug 1343137] [NEW] listarchiver table missing from postgresql schema
by John Naggets Nov. 29, 2014

Nov. 29, 2014

Public bug reported: I am currently testing Mailman3 with PostgreSQL and found out that the listarchiver table is missing from the PostgreSQL schema (database/schema/postgres.sql). It is correctly included in SQLite migration schema though (database/schema/sqlite_20130406000000_01.sql). Due to the missing listarchiver table I get the following exception: Jul 16 17:56:36 2014 (25554) Uncaught runner exception: relation "listarchiver" does not exist LINE 1: ...tarchiver.mailing_list_id, listarchiver.name FROM listarchiv... ^ Jul 16 17:56:36 2014 (25554) Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/mailman/core/runner.py", line 169, in _one_iteration self._process_one_file(msg, msgdata) File "/usr/local/lib/python2.7/dist-packages/mailman/core/runner.py", line 252, in _process_one_file keepqueued = self._dispose(mlist, msg, msgdata) File "/usr/local/lib/python2.7/dist-packages/mailman/runners/pipeline.py", line 36, in _dispose process(mlist, msg, msgdata, pipeline) File "/usr/local/lib/python2.7/dist-packages/mailman/core/pipelines.py", line 66, in process handler.process(mlist, msg, msgdata) File "/usr/local/lib/python2.7/dist-packages/mailman/handlers/rfc_2369.py", line 120, in process process(mlist, msg, msgdata) File "/usr/local/lib/python2.7/dist-packages/mailman/handlers/rfc_2369.py", line 87, in process archiver_set = IListArchiverSet(mlist) File "/usr/local/lib/python2.7/dist-packages/zope/component/hookable.py", line 33, in __call__ return self.__implementation(*args, **kw) File "/usr/local/lib/python2.7/dist-packages/zope/component/_api.py", line 156, in adapter_hook return sitemanager.queryAdapter(object, interface, name, default) File "/usr/local/lib/python2.7/dist-packages/zope/interface/registry.py", line 234, in queryAdapter return self.adapters.queryAdapter(object, interface, name, default) File "/usr/local/lib/python2.7/dist-packages/mailman/model/mailinglist.py", line 591, in __init__ ListArchiver.name == archiver_name)).one() File "/usr/local/lib/python2.7/dist-packages/storm/store.py", line 1158, in one result = self._store._connection.execute(select) File "/usr/local/lib/python2.7/dist-packages/storm/databases/postgres.py", line 266, in execute return Connection.execute(self, statement, params, noresult) File "/usr/local/lib/python2.7/dist-packages/storm/database.py", line 241, in execute raw_cursor = self.raw_execute(statement, params) File "/usr/local/lib/python2.7/dist-packages/storm/databases/postgres.py", line 276, in raw_execute return Connection.raw_execute(self, statement, params) File "/usr/local/lib/python2.7/dist-packages/storm/database.py", line 374, in raw_execute self._run_execution(raw_cursor, args, params, statement) File "/usr/local/lib/python2.7/dist-packages/storm/database.py", line 388, in _run_execution self._check_disconnect(raw_cursor.execute, *args) File "/usr/local/lib/python2.7/dist-packages/storm/database.py", line 454, in _check_disconnect return function(*args, **kwargs) ProgrammingError: relation "listarchiver" does not exist LINE 1: ...tarchiver.mailing_list_id, listarchiver.name FROM listarchiv... ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1343137 Title: listarchiver table missing from postgresql schema To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1343137/+subscriptions

3 4

[Bug 880613] [NEW] PostgreSQL constraints disabled
by Barry Warsaw Nov. 29, 2014

Nov. 29, 2014

Public bug reported: In src/mailman/database/sql/postgres.sql, several foreign key constraints have been commented out because otherwise the test suite, or other aspects do not work. This is probably because there are cases where Mailman violates these constraints, but SQLite3 (the default database) does not care. All disabled constraints are marked with XXX in the above file. Really, these should be fixed. ** Affects: mailman Importance: Medium Status: Confirmed ** Tags: mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/880613 Title: PostgreSQL constraints disabled To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/880613/+subscriptions

1 2

[Bug 1091586] [NEW] Frequent OperationalError: database is locked with sqlite
by Aurélien Bompard Nov. 26, 2014

Nov. 26, 2014

Public bug reported: I'm seeing frequent locking errors with SQLite on the current version of mailman3 from bzr. Here's an example traceback : Traceback (most recent call last): File "/srv/dev/mailman/bin/runner", line 9, in <module> load_entry_point('mailman==3.0.0b2-', 'console_scripts', 'runner')() File "/srv/dev/mailman/mailman3/mailman/src/mailman/bin/runner.py", line 253, in main runner.run() File "/srv/dev/mailman/mailman3/mailman/src/mailman/core/runner.py", line 96, in run filecnt = self._one_iteration() File "/srv/dev/mailman/mailman3/mailman/src/mailman/core/runner.py", line 173, in _one_iteration config.db.commit() File "/srv/dev/mailman/mailman3/mailman/src/mailman/database/base.py", line 77, in commit self.store.commit() File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/store.py", line 122, in commit self._connection.commit() File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/databases/sqlite.py", line 126, in commit self.raw_execute("COMMIT", _end=True) File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/databases/sqlite.py", line 154, in raw_execute return Connection.raw_execute(self, statement, params) File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/database.py", line 322, in raw_execute self._check_disconnect(raw_cursor.execute, *args) File "/srv/dev/mailman/lib/python2.6/site-packages/storm-0.19-py2.6-linux-x86_64.egg/storm/database.py", line 371, in _check_disconnect return function(*args, **kwargs) sqlite3.OperationalError: database is locked It happens during the normal processing of Mailman, not while using the API (to my knowledge), so it seems different from bug #856004. I can reproduce this easily by letting Mailman work for some time. After the locking error, new messages are stuck in var/queue/pipeline: $ ls var/queue/* var/queue/archive: var/queue/bad: var/queue/bounces: var/queue/command: var/queue/digest: var/queue/in: var/queue/lmtp: var/queue/nntp: var/queue/out: var/queue/pipeline: 1355781960.9870529+18f0acdf07aab616f793ecf76acfa1994e62b3a9.pck 1355799347.787621+213f3a6a971717ad1ba27f3d56b65767747a45da.pck 1355814973.8623891+4e66eeadef9b8c9ae99e4ed022c6c93f5af75c05.pck 1355782349.546113+ee14cb323574b647d9014f742e3f505e388d553e.pck 1355800543.460628+c455625c1ad86a5a77c9c515fcb6d555ba439b19.pck 1355815808.8860879+ca3fb5f45999e47c92756489daa951672ba4304d.pck 1355792739.8787439+19973fbcf763f036655aa0a7d477231246afdfbd.pck 1355802301.7830889+7989a3199c7eb491b65176937c0c1658cca9d46d.pck 1355820018.1813829+5005ded04da3574a7f3cd7472c9d635c577b6c32.pck 1355794764.597765+6cf379ad16c948117bb65f0aed0b3c230268ffd2.pck 1355803681.7455051+52d185cdcaecaf883bd43f375f5253567f5cd568.pck 1355822188.0491021+6a3cab9831d03b4f94475f745fa508c5126116b4.pck 1355794889.8323901+e14e25e342ec59709266040d830d7e12be2a1261.pck 1355805362.052228+422e573a6117edb7aae1acf9150ac58c210cedba.pck 1355822293.2363911+627f13dd2121bcb0f1916bc0448cc3b8adc9ad1f.pck 1355795937.2442579+62193d05ee80c6a22213cf2ff211c135fb7d38d9.pck 1355807374.9844501+8de57ab53819fac59d64705bcc56f86899d22634.pck 1355798662.8335559+554da4e7690e116e6fabee5764ac69829dc25685.pck 1355808273.143533+ed1acbf580c596ed921e062ece575877f0c9304b.pck var/queue/rest: var/queue/retry: var/queue/shunt: 1355776302.1302171+c657867b33bf6e37554ff83ee26f4096a77c1114.pck var/queue/virgin: And I need to restart mailman to make it process them again. The locked caused the message to be shunted. I'll attach the mailman.log file, where you'll see many "database is locked" errors, happening on different requests. ** Affects: mailman Importance: Undecided Status: New -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1091586 Title: Frequent OperationalError: database is locked with sqlite To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1091586/+subscriptions

2 8

[Bug 1236297] [NEW] Unicode errors with PostgreSQL and RawStr fields
by Aurélien Bompard Nov. 26, 2014

Nov. 26, 2014

Public bug reported: When using PostgreSQL as a database, it's impossible to set the moderator_password field of a mailing list, which is of type RawStr. To be precise, it's possible to set it, but getting it back from the database after a commit will cause a TypeError with the message: "Expected str, found <type 'unicode'>" as if PostgreSQL always returned unicode on TEXT fields and Storm did not convert them to bytestrings. I get no errors on an SQLite database. I don't know if the problem comes from Mailman or Storm. I have written a python script to reproduce it, see the attached file. There are comments, it should be easily readable. ** Affects: mailman Importance: Undecided Status: New ** Tags: mailman3 ** Attachment added: "test-mm-storm-unicode.py" https://bugs.launchpad.net/bugs/1236297/+attachment/3864008/+files/test-mm-… -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1236297 Title: Unicode errors with PostgreSQL and RawStr fields To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1236297/+subscriptions

2 5

[Bug 1230130] [NEW] The mailinglist interface specifies the "administrative" attribute instead of "administrivia"
by Aurélien Bompard Nov. 25, 2014

Nov. 25, 2014

Public bug reported: In the IMailingList interface, there is an "administrative" attribute which is said to control "administrivia" checks. But apparently, in the model and in the code, this attribute is called "administrivia", as in Mailman 2.1. Unless I'm missing something, the interface attribute should be renamed. ** Affects: mailman Importance: Undecided Status: New ** Tags: easy mailman3 -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1230130 Title: The mailinglist interface specifies the "administrative" attribute instead of "administrivia" To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1230130/+subscriptions

1 1

[Merge] lp:~barry/mailman/falcon into lp:mailman
by Barry Warsaw Nov. 15, 2014

Nov. 15, 2014

Barry Warsaw has proposed merging lp:~barry/mailman/falcon into lp:mailman. Requested reviews: Mailman Coders (mailman-coders) For more details, see: https://code.launchpad.net/~barry/mailman/falcon/+merge/230913 Port from restish to falcon for the REST API framework. This currently depends on an unmerged falcon pull request: https://github.com/racker/falcon/pull/307 -- https://code.launchpad.net/~barry/mailman/falcon/+merge/230913 Your team Mailman Coders is requested to review the proposed merge of lp:~barry/mailman/falcon into lp:mailman.

2 1

[Bug 1082746] [NEW] Automated processes can swamp a list with web subscription requests.
by Mark Sapiro Oct. 2, 2014

Oct. 2, 2014

Public bug reported: There are discussions of this in threads at <http://mail.python.org/pipermail/mailman- users/2012-October/074213.html>, <http://mail.python.org/pipermail /mailman-users/2012-October/074278.html> and <http://mail.python.org/pipermail/mailman- users/2012-November/074412.html>. The Mailman developers do not think there is any way to prevent this other that disabling web subscribe entirely, as by definition, subscription requests come from unauthenticated users. However, an attempt will be made to mitigate this by making a site option to include a dynamically generated hidden hash in the subscribe form which will at least require an automated process to first GET and parse the listinfo form immediately prior to POSTing it. ** Affects: mailman Importance: Medium Assignee: Mark Sapiro (msapiro) Status: In Progress -- You received this bug notification because you are a member of Mailman Coders, which is subscribed to GNU Mailman. https://bugs.launchpad.net/bugs/1082746 Title: Automated processes can swamp a list with web subscription requests. To manage notifications about this bug go to: https://bugs.launchpad.net/mailman/+bug/1082746/+subscriptions

3 8