Bugs item #1913963, was opened at 2008-03-13 17:38 Message generated for change (Comment added) made by msapiro You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1913963&group_id=103 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: mail delivery Group: 2.1 beta Status: Open Resolution: None Priority: 5 Private: No Submitted By: James E. Blair (corvus_at_gnu)
Assigned to: Mark Sapiro (msapiro) Summary: Better error checking for MM list in accept_these_nonmembers
Initial Comment: As of the 2.1.10 beta series, accept_these_nonmembers and other related fields accept the name of another mailing list in the form "@listname", or "@listname@hostname". Currently a user can specify a list's own name in its accept_these_nonmembers fields. This should not be allowed for two reasons: 1) It's confusing for users -- it would be better to simply use a list's own moderation feature rather than specifying that members of a list can post by listing the name of the list in a field where you specify non-members that can post. 2) It causes a new MailList object for a list to be created inside of a section of code that already has a locked MailList object for the same list. This is a source of potential lock problems that does not occur elsewhere in the Mailman source. I'm attaching a patch that handles this condition as well as improving the error reporting for the case where the user specifies a list that doesn't exist. Additionally, the patch adds protection in the GUI so that users are not permitted to enter either the name of the list they are editing, or a list that does not exist (the latter was already a suggestion in the comments). ----------------------------------------------------------------------
Comment By: Mark Sapiro (msapiro) Date: 2008-03-13 19:01
Message: Logged In: YES user_id=1123998 Originator: NO You can take it to the bank. Make a release - get a new bug report. ;-) (2.1.10b4 was packaged and uploaded less than an hour befor this report) Thanks for the report. I will incorporate at least some of your patch before the next 2.1.10 release. A couple of notes. Regarding 1) - intentionally putting the name of 'this list' in *_these_nonmembers will never have an effect since a post from anyone who is a member will be handled based on that members moderate flag, and *_these_nonmembers will never be consulted. A further argument for preventing it from being done. Regarding not allowing a non-existent list name, I decided to allow it at the time to permit creating a 'list of nonmembers allowed to post', and adding that list to this list's accept_these_nonmembers to be done in either order. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=100103&aid=1913963&group_id=103